Commit 1bd8d6cd authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Theodore Ts'o

ext4: in ext4_seek_{hole,data}, return -ENXIO for negative offsets

In the ext4 implementations of SEEK_HOLE and SEEK_DATA, make sure we
return -ENXIO for negative offsets instead of banging around inside
the extent code and returning -EFSCORRUPTED.
Reported-by: default avatarMateusz S <muttdini@gmail.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org # 4.6
parent 901ed070
...@@ -595,7 +595,7 @@ static loff_t ext4_seek_data(struct file *file, loff_t offset, loff_t maxsize) ...@@ -595,7 +595,7 @@ static loff_t ext4_seek_data(struct file *file, loff_t offset, loff_t maxsize)
inode_lock(inode); inode_lock(inode);
isize = i_size_read(inode); isize = i_size_read(inode);
if (offset >= isize) { if (offset < 0 || offset >= isize) {
inode_unlock(inode); inode_unlock(inode);
return -ENXIO; return -ENXIO;
} }
...@@ -658,7 +658,7 @@ static loff_t ext4_seek_hole(struct file *file, loff_t offset, loff_t maxsize) ...@@ -658,7 +658,7 @@ static loff_t ext4_seek_hole(struct file *file, loff_t offset, loff_t maxsize)
inode_lock(inode); inode_lock(inode);
isize = i_size_read(inode); isize = i_size_read(inode);
if (offset >= isize) { if (offset < 0 || offset >= isize) {
inode_unlock(inode); inode_unlock(inode);
return -ENXIO; return -ENXIO;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment