Commit 28ba1b1d authored by Anders Roxell's avatar Anders Roxell Committed by Liviu Dudau

drm: mali-dp: Mark expected switch fall-through

Now that -Wimplicit-fallthrough is passed to GCC by default, the
following warnings shows up:

../drivers/gpu/drm/arm/malidp_hw.c: In function ‘malidp_format_get_bpp’:
../drivers/gpu/drm/arm/malidp_hw.c:387:8: warning: this statement may fall
 through [-Wimplicit-fallthrough=]
    bpp = 30;
    ~~~~^~~~
../drivers/gpu/drm/arm/malidp_hw.c:388:3: note: here
   case DRM_FORMAT_YUV420_10BIT:
   ^~~~
../drivers/gpu/drm/arm/malidp_hw.c: In function ‘malidp_se_irq’:
../drivers/gpu/drm/arm/malidp_hw.c:1311:4: warning: this statement may fall
 through [-Wimplicit-fallthrough=]
    drm_writeback_signal_completion(&malidp->mw_connector, 0);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/arm/malidp_hw.c:1313:3: note: here
   case MW_START:
   ^~~~

Rework to add a 'break;' in a case that didn't have it so that
the compiler doesn't warn about fall-through.

Cc: stable@vger.kernel.org # v5.2+
Fixes: b8207562 ("drm/arm/malidp: Specified the rotation memory requirements for AFBC YUV formats")
Acked-by: default avatarLiviu Dudau <liviu.dudau@arm.com>
Signed-off-by: default avatarAnders Roxell <anders.roxell@linaro.org>
Signed-off-by: default avatarLiviu Dudau <Liviu.Dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190730153056.3606-1-anders.roxell@linaro.org
parent 57d83965
...@@ -385,6 +385,7 @@ int malidp_format_get_bpp(u32 fmt) ...@@ -385,6 +385,7 @@ int malidp_format_get_bpp(u32 fmt)
switch (fmt) { switch (fmt) {
case DRM_FORMAT_VUY101010: case DRM_FORMAT_VUY101010:
bpp = 30; bpp = 30;
break;
case DRM_FORMAT_YUV420_10BIT: case DRM_FORMAT_YUV420_10BIT:
bpp = 15; bpp = 15;
break; break;
...@@ -1309,7 +1310,7 @@ static irqreturn_t malidp_se_irq(int irq, void *arg) ...@@ -1309,7 +1310,7 @@ static irqreturn_t malidp_se_irq(int irq, void *arg)
break; break;
case MW_RESTART: case MW_RESTART:
drm_writeback_signal_completion(&malidp->mw_connector, 0); drm_writeback_signal_completion(&malidp->mw_connector, 0);
/* fall through to a new start */ /* fall through - to a new start */
case MW_START: case MW_START:
/* writeback started, need to emulate one-shot mode */ /* writeback started, need to emulate one-shot mode */
hw->disable_memwrite(hwdev); hw->disable_memwrite(hwdev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment