Commit 2a740902 authored by Brian Masney's avatar Brian Masney Committed by Jonathan Cameron

staging: iio: tsl2x7x: add range checking to three sysfs attributes

The sysfs attributes in_illuminance0_target_input,
in_illuminance0_calibrate, and in_proximity0_calibrate did not have
proper range checking in place so this patch adds the correct range
checks.
Signed-off-by: default avatarBrian Masney <masneyb@onstation.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 5a1f2de1
...@@ -814,15 +814,13 @@ static ssize_t in_illuminance0_target_input_store(struct device *dev, ...@@ -814,15 +814,13 @@ static ssize_t in_illuminance0_target_input_store(struct device *dev,
{ {
struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct tsl2X7X_chip *chip = iio_priv(indio_dev); struct tsl2X7X_chip *chip = iio_priv(indio_dev);
unsigned long value; u16 value;
int ret; int ret;
if (kstrtoul(buf, 0, &value)) if (kstrtou16(buf, 0, &value))
return -EINVAL; return -EINVAL;
if (value)
chip->settings.als_cal_target = value; chip->settings.als_cal_target = value;
ret = tsl2x7x_invoke_change(indio_dev); ret = tsl2x7x_invoke_change(indio_dev);
if (ret < 0) if (ret < 0)
return ret; return ret;
...@@ -838,14 +836,12 @@ static ssize_t in_illuminance0_calibrate_store(struct device *dev, ...@@ -838,14 +836,12 @@ static ssize_t in_illuminance0_calibrate_store(struct device *dev,
bool value; bool value;
int ret; int ret;
if (strtobool(buf, &value)) if (kstrtobool(buf, &value) || !value)
return -EINVAL; return -EINVAL;
if (value) {
ret = tsl2x7x_als_calibrate(indio_dev); ret = tsl2x7x_als_calibrate(indio_dev);
if (ret < 0) if (ret < 0)
return ret; return ret;
}
ret = tsl2x7x_invoke_change(indio_dev); ret = tsl2x7x_invoke_change(indio_dev);
if (ret < 0) if (ret < 0)
...@@ -932,14 +928,12 @@ static ssize_t in_proximity0_calibrate_store(struct device *dev, ...@@ -932,14 +928,12 @@ static ssize_t in_proximity0_calibrate_store(struct device *dev,
bool value; bool value;
int ret; int ret;
if (strtobool(buf, &value)) if (kstrtobool(buf, &value) || !value)
return -EINVAL; return -EINVAL;
if (value) {
ret = tsl2x7x_prox_cal(indio_dev); ret = tsl2x7x_prox_cal(indio_dev);
if (ret < 0) if (ret < 0)
return ret; return ret;
}
ret = tsl2x7x_invoke_change(indio_dev); ret = tsl2x7x_invoke_change(indio_dev);
if (ret < 0) if (ret < 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment