Commit 33fa9fe3 authored by Christian König's avatar Christian König Committed by Alex Deucher

drm/radeon: fix R600_PTE_GART handling

That didn't worked correctly any more and opened up a security problem.
Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ed5cb43f
...@@ -771,8 +771,7 @@ void cik_sdma_vm_set_page(struct radeon_device *rdev, ...@@ -771,8 +771,7 @@ void cik_sdma_vm_set_page(struct radeon_device *rdev,
trace_radeon_vm_set_page(pe, addr, count, incr, flags); trace_radeon_vm_set_page(pe, addr, count, incr, flags);
/* XXX: How to distinguish between GART and other system memory pages? */ if ((flags & R600_PTE_GART_MASK) == R600_PTE_GART_MASK) {
if (flags & R600_PTE_SYSTEM) {
uint64_t src = rdev->gart.table_addr + (addr >> 12) * 8; uint64_t src = rdev->gart.table_addr + (addr >> 12) * 8;
while (count) { while (count) {
unsigned bytes = count * 8; unsigned bytes = count * 8;
......
...@@ -864,9 +864,9 @@ struct radeon_mec { ...@@ -864,9 +864,9 @@ struct radeon_mec {
#define R600_PTE_FRAG_64KB (4 << 7) #define R600_PTE_FRAG_64KB (4 << 7)
#define R600_PTE_FRAG_256KB (6 << 7) #define R600_PTE_FRAG_256KB (6 << 7)
/* flags used for GART page table entries on R600+ */ /* flags needed to be set so we can copy directly from the GART table */
#define R600_PTE_GART ( R600_PTE_VALID | R600_PTE_SYSTEM | R600_PTE_SNOOPED \ #define R600_PTE_GART_MASK ( R600_PTE_READABLE | R600_PTE_WRITEABLE | \
| R600_PTE_READABLE | R600_PTE_WRITEABLE) R600_PTE_SYSTEM | R600_PTE_VALID )
struct radeon_vm_pt { struct radeon_vm_pt {
struct radeon_bo *bo; struct radeon_bo *bo;
......
...@@ -79,8 +79,7 @@ void si_dma_vm_set_page(struct radeon_device *rdev, ...@@ -79,8 +79,7 @@ void si_dma_vm_set_page(struct radeon_device *rdev,
trace_radeon_vm_set_page(pe, addr, count, incr, flags); trace_radeon_vm_set_page(pe, addr, count, incr, flags);
/* XXX: How to distinguish between GART and other system memory pages? */ if ((flags & R600_PTE_GART_MASK) == R600_PTE_GART_MASK) {
if (flags & R600_PTE_SYSTEM) {
uint64_t src = rdev->gart.table_addr + (addr >> 12) * 8; uint64_t src = rdev->gart.table_addr + (addr >> 12) * 8;
while (count) { while (count) {
unsigned bytes = count * 8; unsigned bytes = count * 8;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment