Commit 39c01bf9 authored by Borislav Petkov's avatar Borislav Petkov Committed by Al Viro

amdkfd: Copy from the proper user command pointer

8f1d57c1 ("amdkfd: don't open-code memdup_user()") mistakenly uses
an uninitialized local pointer, gcc complains:

  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c: In function ‘kfd_ioctl_dbg_address_watch’:
  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:562:12: warning: ‘args_buff’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    args_buff = memdup_user(args_buff,
                ^

Fix it.
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent e8ecde25
...@@ -558,8 +558,7 @@ static int kfd_ioctl_dbg_address_watch(struct file *filep, ...@@ -558,8 +558,7 @@ static int kfd_ioctl_dbg_address_watch(struct file *filep,
return -EINVAL; return -EINVAL;
/* this is the actual buffer to work with */ /* this is the actual buffer to work with */
args_buff = memdup_user(cmd_from_user,
args_buff = memdup_user(args_buff,
args->buf_size_in_bytes - sizeof(*args)); args->buf_size_in_bytes - sizeof(*args));
if (IS_ERR(args_buff)) if (IS_ERR(args_buff))
return PTR_ERR(args_buff); return PTR_ERR(args_buff);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment