Commit 3a5fd0db authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Vinod Koul

dmaengine: tegra210-adma: Fix an error handling path in 'tegra_adma_probe()'

Commit b53611fb ("dmaengine: tegra210-adma: Fix crash during probe")
has moved some code in the probe function and reordered the error handling
path accordingly.
However, a goto has been missed.

Fix it and goto the right label if 'dma_async_device_register()' fails, so
that all resources are released.

Fixes: b53611fb ("dmaengine: tegra210-adma: Fix crash during probe")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarJon Hunter <jonathanh@nvidia.com>
Acked-by: default avatarThierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20200516214205.276266-1-christophe.jaillet@wanadoo.frSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent be4054b8
...@@ -900,7 +900,7 @@ static int tegra_adma_probe(struct platform_device *pdev) ...@@ -900,7 +900,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
ret = dma_async_device_register(&tdma->dma_dev); ret = dma_async_device_register(&tdma->dma_dev);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "ADMA registration failed: %d\n", ret); dev_err(&pdev->dev, "ADMA registration failed: %d\n", ret);
goto irq_dispose; goto rpm_put;
} }
ret = of_dma_controller_register(pdev->dev.of_node, ret = of_dma_controller_register(pdev->dev.of_node,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment