Commit 3d6f1c72 authored by Stephen Boyd's avatar Stephen Boyd

clk: axi-clkgen: Remove sometimes impossible check

The size of unsigned long on 64-bit architectures is equal to the
size of u64, so this check is impossible there. This throws off
static checkers:

drivers/clk/clk-axi-clkgen.c:331 axi_clkgen_recalc_rate() warn:
impossible condition '(tmp > (~0)) => (0-u64max > u64max)'

Let's change this code to use min_t() instead so that we
get the same effect on architectures where sizeof(unsigned long)
doesn't equal sizeof(u64).

Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent 62d1e782
...@@ -328,10 +328,7 @@ static unsigned long axi_clkgen_recalc_rate(struct clk_hw *clk_hw, ...@@ -328,10 +328,7 @@ static unsigned long axi_clkgen_recalc_rate(struct clk_hw *clk_hw,
tmp = (unsigned long long)(parent_rate / d) * m; tmp = (unsigned long long)(parent_rate / d) * m;
do_div(tmp, dout); do_div(tmp, dout);
if (tmp > ULONG_MAX) return min_t(unsigned long long, tmp, ULONG_MAX);
return ULONG_MAX;
return tmp;
} }
static int axi_clkgen_enable(struct clk_hw *clk_hw) static int axi_clkgen_enable(struct clk_hw *clk_hw)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment