Commit 408af87a authored by Jesper Juhl's avatar Jesper Juhl Committed by Linus Torvalds

Clean up relay_alloc_page_array() slightly by using vzalloc rather than vmalloc and memset

We can optimize kernel/relay.c::relay_alloc_page_array() slightly by
using vzalloc.  The patch makes these changes:

 - use vzalloc instead of vmalloc+memset.
 - remove redundant local variable 'array'.
 - declare local 'pa_size' as const.

Cuts down nicely on both source and object-code size.
Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Acked-by: default avatarPekka Enberg <penberg@kernel.org>
Acked-by: default avatarMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9a8a0cad
...@@ -70,17 +70,10 @@ static const struct vm_operations_struct relay_file_mmap_ops = { ...@@ -70,17 +70,10 @@ static const struct vm_operations_struct relay_file_mmap_ops = {
*/ */
static struct page **relay_alloc_page_array(unsigned int n_pages) static struct page **relay_alloc_page_array(unsigned int n_pages)
{ {
struct page **array; const size_t pa_size = n_pages * sizeof(struct page *);
size_t pa_size = n_pages * sizeof(struct page *); if (pa_size > PAGE_SIZE)
return vzalloc(pa_size);
if (pa_size > PAGE_SIZE) { return kzalloc(pa_size, GFP_KERNEL);
array = vmalloc(pa_size);
if (array)
memset(array, 0, pa_size);
} else {
array = kzalloc(pa_size, GFP_KERNEL);
}
return array;
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment