Commit 428fc0af authored by Jason Gunthorpe's avatar Jason Gunthorpe Committed by Linus Torvalds

include/linux/log2.h: add missing () around n in roundup_pow_of_two()

Otherwise gcc generates warnings if the expression is complicated.

Fixes: 312a0c17 ("[PATCH] LOG2: Alter roundup_pow_of_two() so that it can use a ilog2() on a constant")
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Link: https://lkml.kernel.org/r/0-v1-8a2697e3c003+41165-log_brackets_jgg@nvidia.comSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e5a59d30
...@@ -173,7 +173,7 @@ unsigned long __rounddown_pow_of_two(unsigned long n) ...@@ -173,7 +173,7 @@ unsigned long __rounddown_pow_of_two(unsigned long n)
#define roundup_pow_of_two(n) \ #define roundup_pow_of_two(n) \
( \ ( \
__builtin_constant_p(n) ? ( \ __builtin_constant_p(n) ? ( \
(n == 1) ? 1 : \ ((n) == 1) ? 1 : \
(1UL << (ilog2((n) - 1) + 1)) \ (1UL << (ilog2((n) - 1) + 1)) \
) : \ ) : \
__roundup_pow_of_two(n) \ __roundup_pow_of_two(n) \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment