Commit 42b8d994 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] vmscan.c: dont reclaim too many pages

The shrink_zone() logic can, under some circumstances, cause far too many
pages to be reclaimed.  Say, we're scanning at high priority and suddenly hit
a large number of reclaimable pages on the LRU.

Change things so we bale out when SWAP_CLUSTER_MAX pages have been reclaimed.
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 2332dc78
...@@ -62,6 +62,9 @@ struct scan_control { ...@@ -62,6 +62,9 @@ struct scan_control {
unsigned long nr_mapped; /* From page_state */ unsigned long nr_mapped; /* From page_state */
/* How many pages shrink_cache() should reclaim */
int nr_to_reclaim;
/* Ask shrink_caches, or shrink_zone to scan at this priority */ /* Ask shrink_caches, or shrink_zone to scan at this priority */
unsigned int priority; unsigned int priority;
...@@ -586,6 +589,7 @@ static void shrink_cache(struct zone *zone, struct scan_control *sc) ...@@ -586,6 +589,7 @@ static void shrink_cache(struct zone *zone, struct scan_control *sc)
if (current_is_kswapd()) if (current_is_kswapd())
mod_page_state(kswapd_steal, nr_freed); mod_page_state(kswapd_steal, nr_freed);
mod_page_state_zone(zone, pgsteal, nr_freed); mod_page_state_zone(zone, pgsteal, nr_freed);
sc->nr_to_reclaim -= nr_freed;
spin_lock_irq(&zone->lru_lock); spin_lock_irq(&zone->lru_lock);
/* /*
...@@ -815,6 +819,8 @@ shrink_zone(struct zone *zone, struct scan_control *sc) ...@@ -815,6 +819,8 @@ shrink_zone(struct zone *zone, struct scan_control *sc)
else else
nr_inactive = 0; nr_inactive = 0;
sc->nr_to_reclaim = SWAP_CLUSTER_MAX;
while (nr_active || nr_inactive) { while (nr_active || nr_inactive) {
if (nr_active) { if (nr_active) {
sc->nr_to_scan = min(nr_active, sc->nr_to_scan = min(nr_active,
...@@ -828,6 +834,8 @@ shrink_zone(struct zone *zone, struct scan_control *sc) ...@@ -828,6 +834,8 @@ shrink_zone(struct zone *zone, struct scan_control *sc)
(unsigned long)SWAP_CLUSTER_MAX); (unsigned long)SWAP_CLUSTER_MAX);
nr_inactive -= sc->nr_to_scan; nr_inactive -= sc->nr_to_scan;
shrink_cache(zone, sc); shrink_cache(zone, sc);
if (sc->nr_to_reclaim <= 0)
break;
} }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment