Commit 444c7043 authored by M. Vefa Bicakci's avatar M. Vefa Bicakci Committed by Greg Kroah-Hartman

staging: rtl8723au: else is not generally useful after a return

Correct a checkpatch.pl warning regarding rtl8723au's
rtw_security.c::crc32_init pointing out that having an else statement
after a break or a return is not useful.

drivers/staging/rtl8723au/core/rtw_security.c:105:
	WARNING: else is not generally useful after a break or return
Signed-off-by: default avatarM. Vefa Bicakci <m.v.b@runbox.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c3cc7593
...@@ -99,22 +99,24 @@ static u8 crc32_reverseBit(u8 data) ...@@ -99,22 +99,24 @@ static u8 crc32_reverseBit(u8 data)
static void crc32_init(void) static void crc32_init(void)
{ {
if (bcrc32initialized == 1)
return;
else{
int i, j; int i, j;
u32 c; u32 c;
u8 *p = (u8 *)&c, *p1; u8 *p, *p1;
u8 k; u8 k;
if (bcrc32initialized == 1)
return;
p = (u8 *) &c;
c = 0x12340000; c = 0x12340000;
for (i = 0; i < 256; ++i) { for (i = 0; i < 256; ++i) {
k = crc32_reverseBit((u8)i); k = crc32_reverseBit((u8)i);
for (c = ((u32)k) << 24, j = 8; j > 0; --j) { for (c = ((u32)k) << 24, j = 8; j > 0; --j) {
c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1); c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
} }
p1 = (u8 *)&crc32_table[i]; p1 = (u8 *)&crc32_table[i];
p1[0] = crc32_reverseBit(p[3]); p1[0] = crc32_reverseBit(p[3]);
...@@ -122,8 +124,8 @@ static void crc32_init(void) ...@@ -122,8 +124,8 @@ static void crc32_init(void)
p1[2] = crc32_reverseBit(p[1]); p1[2] = crc32_reverseBit(p[1]);
p1[3] = crc32_reverseBit(p[0]); p1[3] = crc32_reverseBit(p[0]);
} }
bcrc32initialized = 1; bcrc32initialized = 1;
}
} }
static u32 getcrc32(u8 *buf, int len) static u32 getcrc32(u8 *buf, int len)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment