Commit 4a2b9c37 authored by Dan Siemon's avatar Dan Siemon Committed by David S. Miller

net_sched: fix ip_tos2prio

ECN support incorrectly maps ECN BESTEFFORT packets to TC_PRIO_FILLER
(1) instead of TC_PRIO_BESTEFFORT (0)

This means ECN enabled flows are placed in pfifo_fast/prio low priority
band, giving ECN enabled flows [ECT(0) and CE codepoints] higher drop
probabilities.

This is rather unfortunate, given we would like ECN being more widely
used.

Ref : http://www.coverfire.com/archives/2011/03/13/pfifo_fast-and-ecn/Signed-off-by: default avatarDan Siemon <dan@coverfire.com>
Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Cc: Dave Täht <d@taht.net>
Cc: Jonathan Morton <chromatix99@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 73137147
...@@ -204,7 +204,7 @@ static struct dst_ops ipv4_dst_ops = { ...@@ -204,7 +204,7 @@ static struct dst_ops ipv4_dst_ops = {
const __u8 ip_tos2prio[16] = { const __u8 ip_tos2prio[16] = {
TC_PRIO_BESTEFFORT, TC_PRIO_BESTEFFORT,
ECN_OR_COST(FILLER), ECN_OR_COST(BESTEFFORT),
TC_PRIO_BESTEFFORT, TC_PRIO_BESTEFFORT,
ECN_OR_COST(BESTEFFORT), ECN_OR_COST(BESTEFFORT),
TC_PRIO_BULK, TC_PRIO_BULK,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment