Commit 4a788547 authored by Lukas Wunner's avatar Lukas Wunner Committed by Daniel Vetter

drm/amdgpu: Don't leak runtime pm ref on driver unload

amdgpu_driver_load_kms() calls pm_runtime_put_autosuspend() if
amdgpu_device_is_px(dev), but amdgpu_driver_unload_kms() calls
pm_runtime_get_sync() unconditionally. We therefore leak a runtime pm
ref whenever amdgpu is unloaded on a non-PX machine or if runpm=0. The
GPU will subsequently never runtime suspend after loading amdgpu again.

Fix by taking the runtime pm ref under the same condition that it was
released on driver load.

Fixes: d38ceaf9 ("drm/amdgpu: add core driver (v4)")
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/86364eeb5711323608930c4f0f69046792ff6d3c.1465392124.git.lukas@wunner.de
parent 8fecb6a9
...@@ -60,7 +60,9 @@ int amdgpu_driver_unload_kms(struct drm_device *dev) ...@@ -60,7 +60,9 @@ int amdgpu_driver_unload_kms(struct drm_device *dev)
if (adev->rmmio == NULL) if (adev->rmmio == NULL)
goto done_free; goto done_free;
if (amdgpu_device_is_px(dev)) {
pm_runtime_get_sync(dev->dev); pm_runtime_get_sync(dev->dev);
}
amdgpu_amdkfd_device_fini(adev); amdgpu_amdkfd_device_fini(adev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment