Skip to content

L
linux
Commit 500320b7 authored by Arushi Singhal's avatar Arushi Singhal Committed by Greg Kroah-Hartman
Browse files
Options

staging: rtl8712: remove unnecessary parentheses 

Remove unnecessary parentheses around variables to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: default avatarArushi Singhal <arushisinghal19971997@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a51935a5
Show whitespace changes
Inline Side-by-side
Showing with 41 additions and 41 deletions
drivers/staging/rtl8712/recv_linux.c
View file @ 500320b7
...@@ -111,8 +111,8 @@ void r8712_recv_indicatepkt(struct _adapter *padapter, ...@@ -111,8 +111,8 @@ void r8712_recv_indicatepkt(struct _adapter *padapter,
_pkt *skb; _pkt *skb;
struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib; struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
precvpriv = &(padapter->recvpriv); precvpriv = &padapter->recvpriv;
pfree_recv_queue = &(precvpriv->free_recv_queue); pfree_recv_queue = &precvpriv->free_recv_queue;
skb = precv_frame->u.hdr.pkt; skb = precv_frame->u.hdr.pkt;
if (!skb) if (!skb)
goto _recv_indicatepkt_drop; goto _recv_indicatepkt_drop;
......
drivers/staging/rtl8712/rtl8712_cmd.c
View file @ 500320b7
...@@ -320,7 +320,7 @@ int r8712_cmd_thread(void *context) ...@@ -320,7 +320,7 @@ int r8712_cmd_thread(void *context)
struct tx_desc *pdesc; struct tx_desc *pdesc;
void (*pcmd_callback)(struct _adapter *dev, struct cmd_obj *pcmd); void (*pcmd_callback)(struct _adapter *dev, struct cmd_obj *pcmd);
struct _adapter *padapter = context; struct _adapter *padapter = context;
struct cmd_priv *pcmdpriv = &(padapter->cmdpriv); struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
struct completion *cmd_queue_comp = struct completion *cmd_queue_comp =
&pcmdpriv->cmd_queue_comp; &pcmdpriv->cmd_queue_comp;
struct mutex *pwctrl_lock = &padapter->pwrctrlpriv.mutex_lock; struct mutex *pwctrl_lock = &padapter->pwrctrlpriv.mutex_lock;
...@@ -334,7 +334,7 @@ int r8712_cmd_thread(void *context) ...@@ -334,7 +334,7 @@ int r8712_cmd_thread(void *context)
if (r8712_register_cmd_alive(padapter) != _SUCCESS) if (r8712_register_cmd_alive(padapter) != _SUCCESS)
continue; continue;
_next: _next:
pcmd = r8712_dequeue_cmd(&(pcmdpriv->cmd_queue)); pcmd = r8712_dequeue_cmd(&pcmdpriv->cmd_queue);
if (!(pcmd)) { if (!(pcmd)) {
r8712_unregister_cmd_alive(padapter); r8712_unregister_cmd_alive(padapter);
continue; continue;
...@@ -419,7 +419,7 @@ int r8712_cmd_thread(void *context) ...@@ -419,7 +419,7 @@ int r8712_cmd_thread(void *context)
} }
/* free all cmd_obj resources */ /* free all cmd_obj resources */
do { do {
pcmd = r8712_dequeue_cmd(&(pcmdpriv->cmd_queue)); pcmd = r8712_dequeue_cmd(&pcmdpriv->cmd_queue);
if (!pcmd) if (!pcmd)
break; break;
r8712_free_cmd_obj(pcmd); r8712_free_cmd_obj(pcmd);
...@@ -433,7 +433,7 @@ void r8712_event_handle(struct _adapter *padapter, __le32 *peventbuf) ...@@ -433,7 +433,7 @@ void r8712_event_handle(struct _adapter *padapter, __le32 *peventbuf)
u8 evt_code, evt_seq; u8 evt_code, evt_seq;
u16 evt_sz; u16 evt_sz;
void (*event_callback)(struct _adapter *dev, u8 *pbuf); void (*event_callback)(struct _adapter *dev, u8 *pbuf);
struct evt_priv *pevt_priv = &(padapter->evtpriv); struct evt_priv *pevt_priv = &padapter->evtpriv;
if (!peventbuf) if (!peventbuf)
goto _abort_event_; goto _abort_event_;
......
drivers/staging/rtl8712/rtl8712_led.c
View file @ 500320b7
...@@ -181,11 +181,11 @@ static void SwLedOff(struct _adapter *padapter, struct LED_871x *pLed) ...@@ -181,11 +181,11 @@ static void SwLedOff(struct _adapter *padapter, struct LED_871x *pLed)
*/ */
void r8712_InitSwLeds(struct _adapter *padapter) void r8712_InitSwLeds(struct _adapter *padapter)
{ {
struct led_priv *pledpriv = &(padapter->ledpriv); struct led_priv *pledpriv = &padapter->ledpriv;
pledpriv->LedControlHandler = LedControl871x; pledpriv->LedControlHandler = LedControl871x;
InitLed871x(padapter, &(pledpriv->SwLed0), LED_PIN_LED0); InitLed871x(padapter, &pledpriv->SwLed0, LED_PIN_LED0);
InitLed871x(padapter, &(pledpriv->SwLed1), LED_PIN_LED1); InitLed871x(padapter, &pledpriv->SwLed1, LED_PIN_LED1);
} }
/* Description: /* Description:
...@@ -193,10 +193,10 @@ void r8712_InitSwLeds(struct _adapter *padapter) ...@@ -193,10 +193,10 @@ void r8712_InitSwLeds(struct _adapter *padapter)
*/ */
void r8712_DeInitSwLeds(struct _adapter *padapter) void r8712_DeInitSwLeds(struct _adapter *padapter)
{ {
struct led_priv *ledpriv = &(padapter->ledpriv); struct led_priv *ledpriv = &padapter->ledpriv;
DeInitLed871x(&(ledpriv->SwLed0)); DeInitLed871x(&ledpriv->SwLed0);
DeInitLed871x(&(ledpriv->SwLed1)); DeInitLed871x(&ledpriv->SwLed1);
} }
/* Description: /* Description:
...@@ -206,7 +206,7 @@ void r8712_DeInitSwLeds(struct _adapter *padapter) ...@@ -206,7 +206,7 @@ void r8712_DeInitSwLeds(struct _adapter *padapter)
static void SwLedBlink(struct LED_871x *pLed) static void SwLedBlink(struct LED_871x *pLed)
{ {
struct _adapter *padapter = pLed->padapter; struct _adapter *padapter = pLed->padapter;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
u8 bStopBlinking = false; u8 bStopBlinking = false;
/* Change LED according to BlinkingLedState specified. */ /* Change LED according to BlinkingLedState specified. */
...@@ -281,14 +281,14 @@ static void SwLedBlink(struct LED_871x *pLed) ...@@ -281,14 +281,14 @@ static void SwLedBlink(struct LED_871x *pLed)
static void SwLedBlink1(struct LED_871x *pLed) static void SwLedBlink1(struct LED_871x *pLed)
{ {
struct _adapter *padapter = pLed->padapter; struct _adapter *padapter = pLed->padapter;
struct led_priv *ledpriv = &(padapter->ledpriv); struct led_priv *ledpriv = &padapter->ledpriv;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct eeprom_priv *peeprompriv = &(padapter->eeprompriv); struct eeprom_priv *peeprompriv = &padapter->eeprompriv;
struct LED_871x *pLed1 = &(ledpriv->SwLed1); struct LED_871x *pLed1 = &ledpriv->SwLed1;
u8 bStopBlinking = false; u8 bStopBlinking = false;
if (peeprompriv->CustomerID == RT_CID_819x_CAMEO) if (peeprompriv->CustomerID == RT_CID_819x_CAMEO)
pLed = &(ledpriv->SwLed1); pLed = &ledpriv->SwLed1;
/* Change LED according to BlinkingLedState specified. */ /* Change LED according to BlinkingLedState specified. */
if (pLed->BlinkingLedState == LED_STATE_ON) if (pLed->BlinkingLedState == LED_STATE_ON)
SwLedOn(padapter, pLed); SwLedOn(padapter, pLed);
...@@ -499,7 +499,7 @@ static void SwLedBlink2(struct LED_871x *pLed) ...@@ -499,7 +499,7 @@ static void SwLedBlink2(struct LED_871x *pLed)
static void SwLedBlink3(struct LED_871x *pLed) static void SwLedBlink3(struct LED_871x *pLed)
{ {
struct _adapter *padapter = pLed->padapter; struct _adapter *padapter = pLed->padapter;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
u8 bStopBlinking = false; u8 bStopBlinking = false;
/* Change LED according to BlinkingLedState specified. */ /* Change LED according to BlinkingLedState specified. */
...@@ -593,8 +593,8 @@ static void SwLedBlink3(struct LED_871x *pLed) ...@@ -593,8 +593,8 @@ static void SwLedBlink3(struct LED_871x *pLed)
static void SwLedBlink4(struct LED_871x *pLed) static void SwLedBlink4(struct LED_871x *pLed)
{ {
struct _adapter *padapter = pLed->padapter; struct _adapter *padapter = pLed->padapter;
struct led_priv *ledpriv = &(padapter->ledpriv); struct led_priv *ledpriv = &padapter->ledpriv;
struct LED_871x *pLed1 = &(ledpriv->SwLed1); struct LED_871x *pLed1 = &ledpriv->SwLed1;
u8 bStopBlinking = false; u8 bStopBlinking = false;
/* Change LED according to BlinkingLedState specified. */ /* Change LED according to BlinkingLedState specified. */
...@@ -844,7 +844,7 @@ static void BlinkWorkItemCallback(struct work_struct *work) ...@@ -844,7 +844,7 @@ static void BlinkWorkItemCallback(struct work_struct *work)
{ {
struct LED_871x *pLed = container_of(work, struct LED_871x, struct LED_871x *pLed = container_of(work, struct LED_871x,
BlinkWorkItem); BlinkWorkItem);
struct led_priv *ledpriv = &(pLed->padapter->ledpriv); struct led_priv *ledpriv = &pLed->padapter->ledpriv;
switch (ledpriv->LedStrategy) { switch (ledpriv->LedStrategy) {
case SW_LED_MODE0: case SW_LED_MODE0:
...@@ -886,13 +886,13 @@ static void BlinkWorkItemCallback(struct work_struct *work) ...@@ -886,13 +886,13 @@ static void BlinkWorkItemCallback(struct work_struct *work)
static void SwLedControlMode1(struct _adapter *padapter, static void SwLedControlMode1(struct _adapter *padapter,
enum LED_CTL_MODE LedAction) enum LED_CTL_MODE LedAction)
{ {
struct led_priv *ledpriv = &(padapter->ledpriv); struct led_priv *ledpriv = &padapter->ledpriv;
struct LED_871x *pLed = &(ledpriv->SwLed0); struct LED_871x *pLed = &ledpriv->SwLed0;
struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct sitesurvey_ctrl *psitesurveyctrl = &(pmlmepriv->sitesurveyctrl); struct sitesurvey_ctrl *psitesurveyctrl = &pmlmepriv->sitesurveyctrl;
if (padapter->eeprompriv.CustomerID == RT_CID_819x_CAMEO) if (padapter->eeprompriv.CustomerID == RT_CID_819x_CAMEO)
pLed = &(ledpriv->SwLed1); pLed = &ledpriv->SwLed1;
switch (LedAction) { switch (LedAction) {
case LED_CTL_START_TO_LINK: case LED_CTL_START_TO_LINK:
case LED_CTL_NO_LINK: case LED_CTL_NO_LINK:
...@@ -1106,9 +1106,9 @@ static void SwLedControlMode1(struct _adapter *padapter, ...@@ -1106,9 +1106,9 @@ static void SwLedControlMode1(struct _adapter *padapter,
static void SwLedControlMode2(struct _adapter *padapter, static void SwLedControlMode2(struct _adapter *padapter,
enum LED_CTL_MODE LedAction) enum LED_CTL_MODE LedAction)
{ {
struct led_priv *ledpriv = &(padapter->ledpriv); struct led_priv *ledpriv = &padapter->ledpriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct LED_871x *pLed = &(ledpriv->SwLed0); struct LED_871x *pLed = &ledpriv->SwLed0;
switch (LedAction) { switch (LedAction) {
case LED_CTL_SITE_SURVEY: case LED_CTL_SITE_SURVEY:
...@@ -1239,9 +1239,9 @@ static void SwLedControlMode2(struct _adapter *padapter, ...@@ -1239,9 +1239,9 @@ static void SwLedControlMode2(struct _adapter *padapter,
static void SwLedControlMode3(struct _adapter *padapter, static void SwLedControlMode3(struct _adapter *padapter,
enum LED_CTL_MODE LedAction) enum LED_CTL_MODE LedAction)
{ {
struct led_priv *ledpriv = &(padapter->ledpriv); struct led_priv *ledpriv = &padapter->ledpriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct LED_871x *pLed = &(ledpriv->SwLed0); struct LED_871x *pLed = &ledpriv->SwLed0;
switch (LedAction) { switch (LedAction) {
case LED_CTL_SITE_SURVEY: case LED_CTL_SITE_SURVEY:
...@@ -1383,10 +1383,10 @@ static void SwLedControlMode3(struct _adapter *padapter, ...@@ -1383,10 +1383,10 @@ static void SwLedControlMode3(struct _adapter *padapter,
static void SwLedControlMode4(struct _adapter *padapter, static void SwLedControlMode4(struct _adapter *padapter,
enum LED_CTL_MODE LedAction) enum LED_CTL_MODE LedAction)
{ {
struct led_priv *ledpriv = &(padapter->ledpriv); struct led_priv *ledpriv = &padapter->ledpriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct LED_871x *pLed = &(ledpriv->SwLed0); struct LED_871x *pLed = &ledpriv->SwLed0;
struct LED_871x *pLed1 = &(ledpriv->SwLed1); struct LED_871x *pLed1 = &ledpriv->SwLed1;
switch (LedAction) { switch (LedAction) {
case LED_CTL_START_TO_LINK: case LED_CTL_START_TO_LINK:
...@@ -1650,12 +1650,12 @@ static void SwLedControlMode4(struct _adapter *padapter, ...@@ -1650,12 +1650,12 @@ static void SwLedControlMode4(struct _adapter *padapter,
static void SwLedControlMode5(struct _adapter *padapter, static void SwLedControlMode5(struct _adapter *padapter,
enum LED_CTL_MODE LedAction) enum LED_CTL_MODE LedAction)
{ {
struct led_priv *ledpriv = &(padapter->ledpriv); struct led_priv *ledpriv = &padapter->ledpriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct LED_871x *pLed = &(ledpriv->SwLed0); struct LED_871x *pLed = &ledpriv->SwLed0;
if (padapter->eeprompriv.CustomerID == RT_CID_819x_CAMEO) if (padapter->eeprompriv.CustomerID == RT_CID_819x_CAMEO)
pLed = &(ledpriv->SwLed1); pLed = &ledpriv->SwLed1;
switch (LedAction) { switch (LedAction) {
case LED_CTL_POWER_ON: case LED_CTL_POWER_ON:
...@@ -1723,9 +1723,9 @@ static void SwLedControlMode5(struct _adapter *padapter, ...@@ -1723,9 +1723,9 @@ static void SwLedControlMode5(struct _adapter *padapter,
static void SwLedControlMode6(struct _adapter *padapter, static void SwLedControlMode6(struct _adapter *padapter,
enum LED_CTL_MODE LedAction) enum LED_CTL_MODE LedAction)
{ {
struct led_priv *ledpriv = &(padapter->ledpriv); struct led_priv *ledpriv = &padapter->ledpriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct LED_871x *pLed = &(ledpriv->SwLed0); struct LED_871x *pLed = &ledpriv->SwLed0;
switch (LedAction) { switch (LedAction) {
case LED_CTL_POWER_ON: case LED_CTL_POWER_ON:
...@@ -1737,7 +1737,7 @@ static void SwLedControlMode6(struct _adapter *padapter, ...@@ -1737,7 +1737,7 @@ static void SwLedControlMode6(struct _adapter *padapter,
pLed->CurrLedState = LED_STATE_ON; pLed->CurrLedState = LED_STATE_ON;
pLed->BlinkingLedState = LED_STATE_ON; pLed->BlinkingLedState = LED_STATE_ON;
pLed->bLedBlinkInProgress = false; pLed->bLedBlinkInProgress = false;
mod_timer(&(pLed->BlinkTimer), jiffies + msecs_to_jiffies(0)); mod_timer(&pLed->BlinkTimer, jiffies + msecs_to_jiffies(0));
break; break;
case LED_CTL_TX: case LED_CTL_TX:
case LED_CTL_RX: case LED_CTL_RX:
...@@ -1807,7 +1807,7 @@ static void SwLedControlMode6(struct _adapter *padapter, ...@@ -1807,7 +1807,7 @@ static void SwLedControlMode6(struct _adapter *padapter,
*/ */
void LedControl871x(struct _adapter *padapter, enum LED_CTL_MODE LedAction) void LedControl871x(struct _adapter *padapter, enum LED_CTL_MODE LedAction)
{ {
struct led_priv *ledpriv = &(padapter->ledpriv); struct led_priv *ledpriv = &padapter->ledpriv;
if (!ledpriv->bRegUseLed) if (!ledpriv->bRegUseLed)
return; return;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7