Commit 5053e3a3 authored by Markus Elfring's avatar Markus Elfring Committed by Lee Jones

mfd: abx500-core: Improve two size determinations in abx500_register_ops()

Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent a5e20bfa
...@@ -37,14 +37,12 @@ int abx500_register_ops(struct device *dev, struct abx500_ops *ops) ...@@ -37,14 +37,12 @@ int abx500_register_ops(struct device *dev, struct abx500_ops *ops)
{ {
struct abx500_device_entry *dev_entry; struct abx500_device_entry *dev_entry;
dev_entry = devm_kzalloc(dev, dev_entry = devm_kzalloc(dev, sizeof(*dev_entry), GFP_KERNEL);
sizeof(struct abx500_device_entry),
GFP_KERNEL);
if (!dev_entry) if (!dev_entry)
return -ENOMEM; return -ENOMEM;
dev_entry->dev = dev; dev_entry->dev = dev;
memcpy(&dev_entry->ops, ops, sizeof(struct abx500_ops)); memcpy(&dev_entry->ops, ops, sizeof(*ops));
list_add_tail(&dev_entry->list, &abx500_list); list_add_tail(&dev_entry->list, &abx500_list);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment