Commit 50bf14b3 authored by Akinobu Mita's avatar Akinobu Mita Committed by Greg Kroah-Hartman

pci: fix __pci_register_driver error handling

__pci_register_driver() error path forgot to unwind.
driver_unregister() needs to be called when pci_create_newid_file() failed.
Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 0dcb2b7e
...@@ -445,9 +445,12 @@ int __pci_register_driver(struct pci_driver *drv, struct module *owner) ...@@ -445,9 +445,12 @@ int __pci_register_driver(struct pci_driver *drv, struct module *owner)
/* register with core */ /* register with core */
error = driver_register(&drv->driver); error = driver_register(&drv->driver);
if (error)
return error;
if (!error)
error = pci_create_newid_file(drv); error = pci_create_newid_file(drv);
if (error)
driver_unregister(&drv->driver);
return error; return error;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment