Commit 51ace261 authored by dan.carpenter@oracle.com's avatar dan.carpenter@oracle.com Committed by Willy Tarreau

spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()

commit e33d085d upstream.

'!' has higher precedence than comparisons so the original condition
is equivalent to "if (xspi->remaining_bytes == 0)".  This makes the
static checkers complain.

xspi->remaining_bytes is signed and from looking at the code
briefly, I think it might be able to go negative.  I suspect that
going negative may cause a bug, but I don't have the hardware and
can't test.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
Signed-off-by: default avatarWilly Tarreau <w@1wt.eu>
parent 78308a4a
...@@ -315,7 +315,7 @@ static int xilinx_spi_txrx_bufs(struct spi_device *spi, struct spi_transfer *t) ...@@ -315,7 +315,7 @@ static int xilinx_spi_txrx_bufs(struct spi_device *spi, struct spi_transfer *t)
} }
/* See if there is more data to send */ /* See if there is more data to send */
if (!xspi->remaining_bytes > 0) if (xspi->remaining_bytes <= 0)
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment