Commit 51d7cfc6 authored by Linus Torvalds's avatar Linus Torvalds

Merge branch 'for-linus' of git://git390.osdl.marist.edu/pub/scm/linux-2.6

* 'for-linus' of git://git390.osdl.marist.edu/pub/scm/linux-2.6:
  [S390] cio: deregister ccw device when pgid disband failed
  [S390] cio: Use device_schedule_callback() for removing disconnected devices.
  [S390] Fix section annotations.
  [S390] raw3270: use mutex instead of semaphore
  [S390] arch/s390/kernel/debug.c: use mutex instead of semaphore
  [S390] dasd_eer: use mutex instead of semaphore
  [S390] Add exception handler for diagnose 224
parents 5983b125 3ecb0a5a
...@@ -481,9 +481,17 @@ static void *diag204_store(void) ...@@ -481,9 +481,17 @@ static void *diag204_store(void)
/* Diagnose 224 functions */ /* Diagnose 224 functions */
static void diag224(void *ptr) static int diag224(void *ptr)
{ {
asm volatile("diag %0,%1,0x224" : :"d" (0), "d"(ptr) : "memory"); int rc = -ENOTSUPP;
asm volatile(
" diag %1,%2,0x224\n"
"0: lhi %0,0x0\n"
"1:\n"
EX_TABLE(0b,1b)
: "+d" (rc) :"d" (0), "d" (ptr) : "memory");
return rc;
} }
static int diag224_get_name_table(void) static int diag224_get_name_table(void)
...@@ -492,7 +500,10 @@ static int diag224_get_name_table(void) ...@@ -492,7 +500,10 @@ static int diag224_get_name_table(void)
diag224_cpu_names = kmalloc(PAGE_SIZE, GFP_KERNEL | GFP_DMA); diag224_cpu_names = kmalloc(PAGE_SIZE, GFP_KERNEL | GFP_DMA);
if (!diag224_cpu_names) if (!diag224_cpu_names)
return -ENOMEM; return -ENOMEM;
diag224(diag224_cpu_names); if (diag224(diag224_cpu_names)) {
kfree(diag224_cpu_names);
return -ENOTSUPP;
}
EBCASC(diag224_cpu_names + 16, (*diag224_cpu_names + 1) * 16); EBCASC(diag224_cpu_names + 16, (*diag224_cpu_names + 1) * 16);
return 0; return 0;
} }
......
...@@ -163,7 +163,7 @@ unsigned int debug_feature_version = __DEBUG_FEATURE_VERSION; ...@@ -163,7 +163,7 @@ unsigned int debug_feature_version = __DEBUG_FEATURE_VERSION;
static debug_info_t *debug_area_first = NULL; static debug_info_t *debug_area_first = NULL;
static debug_info_t *debug_area_last = NULL; static debug_info_t *debug_area_last = NULL;
static DECLARE_MUTEX(debug_lock); static DEFINE_MUTEX(debug_mutex);
static int initialized; static int initialized;
...@@ -576,7 +576,7 @@ debug_input(struct file *file, const char __user *user_buf, size_t length, ...@@ -576,7 +576,7 @@ debug_input(struct file *file, const char __user *user_buf, size_t length,
int rc = 0; int rc = 0;
file_private_info_t *p_info; file_private_info_t *p_info;
down(&debug_lock); mutex_lock(&debug_mutex);
p_info = ((file_private_info_t *) file->private_data); p_info = ((file_private_info_t *) file->private_data);
if (p_info->view->input_proc) if (p_info->view->input_proc)
rc = p_info->view->input_proc(p_info->debug_info_org, rc = p_info->view->input_proc(p_info->debug_info_org,
...@@ -584,7 +584,7 @@ debug_input(struct file *file, const char __user *user_buf, size_t length, ...@@ -584,7 +584,7 @@ debug_input(struct file *file, const char __user *user_buf, size_t length,
length, offset); length, offset);
else else
rc = -EPERM; rc = -EPERM;
up(&debug_lock); mutex_unlock(&debug_mutex);
return rc; /* number of input characters */ return rc; /* number of input characters */
} }
...@@ -602,7 +602,7 @@ debug_open(struct inode *inode, struct file *file) ...@@ -602,7 +602,7 @@ debug_open(struct inode *inode, struct file *file)
file_private_info_t *p_info; file_private_info_t *p_info;
debug_info_t *debug_info, *debug_info_snapshot; debug_info_t *debug_info, *debug_info_snapshot;
down(&debug_lock); mutex_lock(&debug_mutex);
debug_info = file->f_path.dentry->d_inode->i_private; debug_info = file->f_path.dentry->d_inode->i_private;
/* find debug view */ /* find debug view */
for (i = 0; i < DEBUG_MAX_VIEWS; i++) { for (i = 0; i < DEBUG_MAX_VIEWS; i++) {
...@@ -653,7 +653,7 @@ debug_open(struct inode *inode, struct file *file) ...@@ -653,7 +653,7 @@ debug_open(struct inode *inode, struct file *file)
file->private_data = p_info; file->private_data = p_info;
debug_info_get(debug_info); debug_info_get(debug_info);
out: out:
up(&debug_lock); mutex_unlock(&debug_mutex);
return rc; return rc;
} }
...@@ -688,7 +688,7 @@ debug_register (char *name, int pages_per_area, int nr_areas, int buf_size) ...@@ -688,7 +688,7 @@ debug_register (char *name, int pages_per_area, int nr_areas, int buf_size)
if (!initialized) if (!initialized)
BUG(); BUG();
down(&debug_lock); mutex_lock(&debug_mutex);
/* create new debug_info */ /* create new debug_info */
...@@ -702,7 +702,7 @@ debug_register (char *name, int pages_per_area, int nr_areas, int buf_size) ...@@ -702,7 +702,7 @@ debug_register (char *name, int pages_per_area, int nr_areas, int buf_size)
if (!rc){ if (!rc){
printk(KERN_ERR "debug: debug_register failed for %s\n",name); printk(KERN_ERR "debug: debug_register failed for %s\n",name);
} }
up(&debug_lock); mutex_unlock(&debug_mutex);
return rc; return rc;
} }
...@@ -716,9 +716,9 @@ debug_unregister(debug_info_t * id) ...@@ -716,9 +716,9 @@ debug_unregister(debug_info_t * id)
{ {
if (!id) if (!id)
goto out; goto out;
down(&debug_lock); mutex_lock(&debug_mutex);
debug_info_put(id); debug_info_put(id);
up(&debug_lock); mutex_unlock(&debug_mutex);
out: out:
return; return;
...@@ -1054,11 +1054,11 @@ __init debug_init(void) ...@@ -1054,11 +1054,11 @@ __init debug_init(void)
int rc = 0; int rc = 0;
s390dbf_sysctl_header = register_sysctl_table(s390dbf_dir_table); s390dbf_sysctl_header = register_sysctl_table(s390dbf_dir_table);
down(&debug_lock); mutex_lock(&debug_mutex);
debug_debugfs_root_entry = debugfs_create_dir(DEBUG_DIR_ROOT,NULL); debug_debugfs_root_entry = debugfs_create_dir(DEBUG_DIR_ROOT,NULL);
printk(KERN_INFO "debug: Initialization complete\n"); printk(KERN_INFO "debug: Initialization complete\n");
initialized = 1; initialized = 1;
up(&debug_lock); mutex_unlock(&debug_mutex);
return rc; return rc;
} }
......
...@@ -102,7 +102,7 @@ static struct resource data_resource = { ...@@ -102,7 +102,7 @@ static struct resource data_resource = {
/* /*
* cpu_init() initializes state that is per-CPU. * cpu_init() initializes state that is per-CPU.
*/ */
void __devinit cpu_init (void) void __cpuinit cpu_init(void)
{ {
int addr = hard_smp_processor_id(); int addr = hard_smp_processor_id();
...@@ -915,7 +915,7 @@ setup_arch(char **cmdline_p) ...@@ -915,7 +915,7 @@ setup_arch(char **cmdline_p)
setup_zfcpdump(console_devno); setup_zfcpdump(console_devno);
} }
void print_cpu_info(struct cpuinfo_S390 *cpuinfo) void __cpuinit print_cpu_info(struct cpuinfo_S390 *cpuinfo)
{ {
printk("cpu %d " printk("cpu %d "
#ifdef CONFIG_SMP #ifdef CONFIG_SMP
......
...@@ -492,7 +492,7 @@ static unsigned int __init smp_count_cpus(void) ...@@ -492,7 +492,7 @@ static unsigned int __init smp_count_cpus(void)
/* /*
* Activate a secondary processor. * Activate a secondary processor.
*/ */
int __devinit start_secondary(void *cpuvoid) int __cpuinit start_secondary(void *cpuvoid)
{ {
/* Setup the cpu */ /* Setup the cpu */
cpu_init(); cpu_init();
...@@ -741,7 +741,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) ...@@ -741,7 +741,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
smp_create_idle(cpu); smp_create_idle(cpu);
} }
void __devinit smp_prepare_boot_cpu(void) void __init smp_prepare_boot_cpu(void)
{ {
BUG_ON(smp_processor_id() != 0); BUG_ON(smp_processor_id() != 0);
...@@ -750,7 +750,7 @@ void __devinit smp_prepare_boot_cpu(void) ...@@ -750,7 +750,7 @@ void __devinit smp_prepare_boot_cpu(void)
current_set[0] = current; current_set[0] = current;
} }
void smp_cpus_done(unsigned int max_cpus) void __init smp_cpus_done(unsigned int max_cpus)
{ {
cpu_present_map = cpu_possible_map; cpu_present_map = cpu_possible_map;
} }
......
...@@ -14,9 +14,9 @@ ...@@ -14,9 +14,9 @@
#include <linux/moduleparam.h> #include <linux/moduleparam.h>
#include <linux/device.h> #include <linux/device.h>
#include <linux/poll.h> #include <linux/poll.h>
#include <linux/mutex.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
#include <asm/semaphore.h>
#include <asm/atomic.h> #include <asm/atomic.h>
#include <asm/ebcdic.h> #include <asm/ebcdic.h>
...@@ -514,7 +514,7 @@ void dasd_eer_disable(struct dasd_device *device) ...@@ -514,7 +514,7 @@ void dasd_eer_disable(struct dasd_device *device)
* to transfer in a readbuffer, which is protected by the readbuffer_mutex. * to transfer in a readbuffer, which is protected by the readbuffer_mutex.
*/ */
static char readbuffer[PAGE_SIZE]; static char readbuffer[PAGE_SIZE];
static DECLARE_MUTEX(readbuffer_mutex); static DEFINE_MUTEX(readbuffer_mutex);
static int dasd_eer_open(struct inode *inp, struct file *filp) static int dasd_eer_open(struct inode *inp, struct file *filp)
{ {
...@@ -579,7 +579,7 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf, ...@@ -579,7 +579,7 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf,
struct eerbuffer *eerb; struct eerbuffer *eerb;
eerb = (struct eerbuffer *) filp->private_data; eerb = (struct eerbuffer *) filp->private_data;
if (down_interruptible(&readbuffer_mutex)) if (mutex_lock_interruptible(&readbuffer_mutex))
return -ERESTARTSYS; return -ERESTARTSYS;
spin_lock_irqsave(&bufferlock, flags); spin_lock_irqsave(&bufferlock, flags);
...@@ -588,7 +588,7 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf, ...@@ -588,7 +588,7 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf,
/* has been deleted */ /* has been deleted */
eerb->residual = 0; eerb->residual = 0;
spin_unlock_irqrestore(&bufferlock, flags); spin_unlock_irqrestore(&bufferlock, flags);
up(&readbuffer_mutex); mutex_unlock(&readbuffer_mutex);
return -EIO; return -EIO;
} else if (eerb->residual > 0) { } else if (eerb->residual > 0) {
/* OK we still have a second half of a record to deliver */ /* OK we still have a second half of a record to deliver */
...@@ -602,7 +602,7 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf, ...@@ -602,7 +602,7 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf,
if (!tc) { if (!tc) {
/* no data available */ /* no data available */
spin_unlock_irqrestore(&bufferlock, flags); spin_unlock_irqrestore(&bufferlock, flags);
up(&readbuffer_mutex); mutex_unlock(&readbuffer_mutex);
if (filp->f_flags & O_NONBLOCK) if (filp->f_flags & O_NONBLOCK)
return -EAGAIN; return -EAGAIN;
rc = wait_event_interruptible( rc = wait_event_interruptible(
...@@ -610,7 +610,7 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf, ...@@ -610,7 +610,7 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf,
eerb->head != eerb->tail); eerb->head != eerb->tail);
if (rc) if (rc)
return rc; return rc;
if (down_interruptible(&readbuffer_mutex)) if (mutex_lock_interruptible(&readbuffer_mutex))
return -ERESTARTSYS; return -ERESTARTSYS;
spin_lock_irqsave(&bufferlock, flags); spin_lock_irqsave(&bufferlock, flags);
} }
...@@ -626,11 +626,11 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf, ...@@ -626,11 +626,11 @@ static ssize_t dasd_eer_read(struct file *filp, char __user *buf,
spin_unlock_irqrestore(&bufferlock, flags); spin_unlock_irqrestore(&bufferlock, flags);
if (copy_to_user(buf, readbuffer, effective_count)) { if (copy_to_user(buf, readbuffer, effective_count)) {
up(&readbuffer_mutex); mutex_unlock(&readbuffer_mutex);
return -EFAULT; return -EFAULT;
} }
up(&readbuffer_mutex); mutex_unlock(&readbuffer_mutex);
return effective_count; return effective_count;
} }
......
...@@ -487,7 +487,7 @@ struct raw3270_ua { /* Query Reply structure for Usable Area */ ...@@ -487,7 +487,7 @@ struct raw3270_ua { /* Query Reply structure for Usable Area */
} __attribute__ ((packed)); } __attribute__ ((packed));
static struct diag210 raw3270_init_diag210; static struct diag210 raw3270_init_diag210;
static DECLARE_MUTEX(raw3270_init_sem); static DEFINE_MUTEX(raw3270_init_mutex);
static int static int
raw3270_init_irq(struct raw3270_view *view, struct raw3270_request *rq, raw3270_init_irq(struct raw3270_view *view, struct raw3270_request *rq,
...@@ -713,7 +713,7 @@ raw3270_size_device(struct raw3270 *rp) ...@@ -713,7 +713,7 @@ raw3270_size_device(struct raw3270 *rp)
{ {
int rc; int rc;
down(&raw3270_init_sem); mutex_lock(&raw3270_init_mutex);
rp->view = &raw3270_init_view; rp->view = &raw3270_init_view;
raw3270_init_view.dev = rp; raw3270_init_view.dev = rp;
if (MACHINE_IS_VM) if (MACHINE_IS_VM)
...@@ -722,7 +722,7 @@ raw3270_size_device(struct raw3270 *rp) ...@@ -722,7 +722,7 @@ raw3270_size_device(struct raw3270 *rp)
rc = __raw3270_size_device(rp); rc = __raw3270_size_device(rp);
raw3270_init_view.dev = NULL; raw3270_init_view.dev = NULL;
rp->view = NULL; rp->view = NULL;
up(&raw3270_init_sem); mutex_unlock(&raw3270_init_mutex);
if (rc == 0) { /* Found something. */ if (rc == 0) { /* Found something. */
/* Try to find a model. */ /* Try to find a model. */
rp->model = 0; rp->model = 0;
...@@ -749,7 +749,7 @@ raw3270_reset_device(struct raw3270 *rp) ...@@ -749,7 +749,7 @@ raw3270_reset_device(struct raw3270 *rp)
{ {
int rc; int rc;
down(&raw3270_init_sem); mutex_lock(&raw3270_init_mutex);
memset(&rp->init_request, 0, sizeof(rp->init_request)); memset(&rp->init_request, 0, sizeof(rp->init_request));
memset(&rp->init_data, 0, sizeof(rp->init_data)); memset(&rp->init_data, 0, sizeof(rp->init_data));
/* Store reset data stream to init_data/init_request */ /* Store reset data stream to init_data/init_request */
...@@ -764,7 +764,7 @@ raw3270_reset_device(struct raw3270 *rp) ...@@ -764,7 +764,7 @@ raw3270_reset_device(struct raw3270 *rp)
rc = raw3270_start_init(rp, &raw3270_init_view, &rp->init_request); rc = raw3270_start_init(rp, &raw3270_init_view, &rp->init_request);
raw3270_init_view.dev = NULL; raw3270_init_view.dev = NULL;
rp->view = NULL; rp->view = NULL;
up(&raw3270_init_sem); mutex_unlock(&raw3270_init_mutex);
return rc; return rc;
} }
......
...@@ -296,30 +296,57 @@ static void ccw_device_unregister(struct ccw_device *cdev) ...@@ -296,30 +296,57 @@ static void ccw_device_unregister(struct ccw_device *cdev)
device_del(&cdev->dev); device_del(&cdev->dev);
} }
static void ccw_device_remove_orphan_cb(struct device *dev)
{
struct ccw_device *cdev = to_ccwdev(dev);
ccw_device_unregister(cdev);
put_device(&cdev->dev);
}
static void ccw_device_remove_sch_cb(struct device *dev)
{
struct subchannel *sch;
sch = to_subchannel(dev);
css_sch_device_unregister(sch);
/* Reset intparm to zeroes. */
sch->schib.pmcw.intparm = 0;
cio_modify(sch);
put_device(&sch->dev);
}
static void static void
ccw_device_remove_disconnected(struct ccw_device *cdev) ccw_device_remove_disconnected(struct ccw_device *cdev)
{ {
struct subchannel *sch;
unsigned long flags; unsigned long flags;
int rc;
/* /*
* Forced offline in disconnected state means * Forced offline in disconnected state means
* 'throw away device'. * 'throw away device'.
*/ */
if (ccw_device_is_orphan(cdev)) { if (ccw_device_is_orphan(cdev)) {
/* Deregister ccw device. */ /*
* Deregister ccw device.
* Unfortunately, we cannot do this directly from the
* attribute method.
*/
spin_lock_irqsave(cdev->ccwlock, flags); spin_lock_irqsave(cdev->ccwlock, flags);
cdev->private->state = DEV_STATE_NOT_OPER; cdev->private->state = DEV_STATE_NOT_OPER;
spin_unlock_irqrestore(cdev->ccwlock, flags); spin_unlock_irqrestore(cdev->ccwlock, flags);
ccw_device_unregister(cdev); rc = device_schedule_callback(&cdev->dev,
put_device(&cdev->dev); ccw_device_remove_orphan_cb);
return ; if (rc)
dev_info(&cdev->dev, "Couldn't unregister orphan\n");
return;
} }
sch = to_subchannel(cdev->dev.parent); /* Deregister subchannel, which will kill the ccw device. */
css_sch_device_unregister(sch); rc = device_schedule_callback(cdev->dev.parent,
/* Reset intparm to zeroes. */ ccw_device_remove_sch_cb);
sch->schib.pmcw.intparm = 0; if (rc)
cio_modify(sch); dev_info(&cdev->dev,
put_device(&sch->dev); "Couldn't unregister disconnected device\n");
} }
int int
......
...@@ -688,6 +688,12 @@ ccw_device_disband_done(struct ccw_device *cdev, int err) ...@@ -688,6 +688,12 @@ ccw_device_disband_done(struct ccw_device *cdev, int err)
ccw_device_done(cdev, DEV_STATE_BOXED); ccw_device_done(cdev, DEV_STATE_BOXED);
break; break;
default: default:
cdev->private->flags.donotify = 0;
if (get_device(&cdev->dev)) {
PREPARE_WORK(&cdev->private->kick_work,
ccw_device_call_sch_unregister);
queue_work(ccw_device_work, &cdev->private->kick_work);
}
ccw_device_done(cdev, DEV_STATE_NOT_OPER); ccw_device_done(cdev, DEV_STATE_NOT_OPER);
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment