Commit 5334b342 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab

media: gspca: Stop using GFP_DMA for buffers for USB bulk transfers

The recent "x86 ZONE_DMA love" discussion at LSF/MM pointed out that some
gspca sub-drivvers are using GFP_DMA to allocate buffers which are used
for USB bulk transfers, there is absolutely no need for this, drop it.

Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 6159e12e
...@@ -321,7 +321,7 @@ static void jl2005c_dostream(struct work_struct *work) ...@@ -321,7 +321,7 @@ static void jl2005c_dostream(struct work_struct *work)
int ret; int ret;
u8 *buffer; u8 *buffer;
buffer = kmalloc(JL2005C_MAX_TRANSFER, GFP_KERNEL | GFP_DMA); buffer = kmalloc(JL2005C_MAX_TRANSFER, GFP_KERNEL);
if (!buffer) { if (!buffer) {
pr_err("Couldn't allocate USB buffer\n"); pr_err("Couldn't allocate USB buffer\n");
goto quit_stream; goto quit_stream;
......
...@@ -217,7 +217,7 @@ static void sq905_dostream(struct work_struct *work) ...@@ -217,7 +217,7 @@ static void sq905_dostream(struct work_struct *work)
u8 *data; u8 *data;
u8 *buffer; u8 *buffer;
buffer = kmalloc(SQ905_MAX_TRANSFER, GFP_KERNEL | GFP_DMA); buffer = kmalloc(SQ905_MAX_TRANSFER, GFP_KERNEL);
if (!buffer) { if (!buffer) {
pr_err("Couldn't allocate USB buffer\n"); pr_err("Couldn't allocate USB buffer\n");
goto quit_stream; goto quit_stream;
......
...@@ -138,7 +138,7 @@ static void sq905c_dostream(struct work_struct *work) ...@@ -138,7 +138,7 @@ static void sq905c_dostream(struct work_struct *work)
int ret; int ret;
u8 *buffer; u8 *buffer;
buffer = kmalloc(SQ905C_MAX_TRANSFER, GFP_KERNEL | GFP_DMA); buffer = kmalloc(SQ905C_MAX_TRANSFER, GFP_KERNEL);
if (!buffer) { if (!buffer) {
pr_err("Couldn't allocate USB buffer\n"); pr_err("Couldn't allocate USB buffer\n");
goto quit_stream; goto quit_stream;
......
...@@ -182,7 +182,7 @@ static void vicam_dostream(struct work_struct *work) ...@@ -182,7 +182,7 @@ static void vicam_dostream(struct work_struct *work)
frame_sz = gspca_dev->cam.cam_mode[gspca_dev->curr_mode].sizeimage + frame_sz = gspca_dev->cam.cam_mode[gspca_dev->curr_mode].sizeimage +
HEADER_SIZE; HEADER_SIZE;
buffer = kmalloc(frame_sz, GFP_KERNEL | GFP_DMA); buffer = kmalloc(frame_sz, GFP_KERNEL);
if (!buffer) { if (!buffer) {
pr_err("Couldn't allocate USB buffer\n"); pr_err("Couldn't allocate USB buffer\n");
goto exit; goto exit;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment