Commit 5964db08 authored by Tomas Winkler's avatar Tomas Winkler Committed by Greg Kroah-Hartman

mei: fix debugfs files leak on error path

if dbgfs_dir is not set then debugfs_remove_recursive
is not called on the error path
Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a42fb351
...@@ -204,6 +204,8 @@ int mei_dbgfs_register(struct mei_device *dev, const char *name) ...@@ -204,6 +204,8 @@ int mei_dbgfs_register(struct mei_device *dev, const char *name)
if (!dir) if (!dir)
return -ENOMEM; return -ENOMEM;
dev->dbgfs_dir = dir;
f = debugfs_create_file("meclients", S_IRUSR, dir, f = debugfs_create_file("meclients", S_IRUSR, dir,
dev, &mei_dbgfs_fops_meclients); dev, &mei_dbgfs_fops_meclients);
if (!f) { if (!f) {
...@@ -228,7 +230,6 @@ int mei_dbgfs_register(struct mei_device *dev, const char *name) ...@@ -228,7 +230,6 @@ int mei_dbgfs_register(struct mei_device *dev, const char *name)
dev_err(dev->dev, "allow_fixed_address: registration failed\n"); dev_err(dev->dev, "allow_fixed_address: registration failed\n");
goto err; goto err;
} }
dev->dbgfs_dir = dir;
return 0; return 0;
err: err:
mei_dbgfs_deregister(dev); mei_dbgfs_deregister(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment