Commit 5ea0699a authored by Sonic Zhang's avatar Sonic Zhang Committed by Dmitry Torokhov

Input: bfin_rotary - move pin lists into into platform data

Newer Blackfin boards use pinctrl API to manage pins and the legacy
peripherial lists are not useful on them. Let's move pin lists into
platform data so older boards can still use them and newer boards can use
the modern API.
Signed-off-by: default avatarSonic Zhang <sonic.zhang@analog.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 1ea74014
...@@ -668,6 +668,13 @@ static struct platform_device bfin_sport1_uart_device = { ...@@ -668,6 +668,13 @@ static struct platform_device bfin_sport1_uart_device = {
#if IS_ENABLED(CONFIG_INPUT_BFIN_ROTARY) #if IS_ENABLED(CONFIG_INPUT_BFIN_ROTARY)
#include <linux/platform_data/bfin_rotary.h> #include <linux/platform_data/bfin_rotary.h>
static const u16 per_cnt[] = {
P_CNT_CUD,
P_CNT_CDG,
P_CNT_CZM,
0
};
static struct bfin_rotary_platform_data bfin_rotary_data = { static struct bfin_rotary_platform_data bfin_rotary_data = {
/*.rotary_up_key = KEY_UP,*/ /*.rotary_up_key = KEY_UP,*/
/*.rotary_down_key = KEY_DOWN,*/ /*.rotary_down_key = KEY_DOWN,*/
...@@ -676,6 +683,7 @@ static struct bfin_rotary_platform_data bfin_rotary_data = { ...@@ -676,6 +683,7 @@ static struct bfin_rotary_platform_data bfin_rotary_data = {
.debounce = 10, /* 0..17 */ .debounce = 10, /* 0..17 */
.mode = ROT_QUAD_ENC | ROT_DEBE, .mode = ROT_QUAD_ENC | ROT_DEBE,
.pm_wakeup = 1, .pm_wakeup = 1,
.pin_list = per_cnt,
}; };
static struct resource bfin_rotary_resources[] = { static struct resource bfin_rotary_resources[] = {
......
...@@ -1094,6 +1094,13 @@ static struct platform_device bfin_device_gpiokeys = { ...@@ -1094,6 +1094,13 @@ static struct platform_device bfin_device_gpiokeys = {
#if IS_ENABLED(CONFIG_INPUT_BFIN_ROTARY) #if IS_ENABLED(CONFIG_INPUT_BFIN_ROTARY)
#include <linux/platform_data/bfin_rotary.h> #include <linux/platform_data/bfin_rotary.h>
static const u16 per_cnt[] = {
P_CNT_CUD,
P_CNT_CDG,
P_CNT_CZM,
0
};
static struct bfin_rotary_platform_data bfin_rotary_data = { static struct bfin_rotary_platform_data bfin_rotary_data = {
/*.rotary_up_key = KEY_UP,*/ /*.rotary_up_key = KEY_UP,*/
/*.rotary_down_key = KEY_DOWN,*/ /*.rotary_down_key = KEY_DOWN,*/
...@@ -1102,6 +1109,7 @@ static struct bfin_rotary_platform_data bfin_rotary_data = { ...@@ -1102,6 +1109,7 @@ static struct bfin_rotary_platform_data bfin_rotary_data = {
.debounce = 10, /* 0..17 */ .debounce = 10, /* 0..17 */
.mode = ROT_QUAD_ENC | ROT_DEBE, .mode = ROT_QUAD_ENC | ROT_DEBE,
.pm_wakeup = 1, .pm_wakeup = 1,
.pin_list = per_cnt,
}; };
static struct resource bfin_rotary_resources[] = { static struct resource bfin_rotary_resources[] = {
......
...@@ -16,13 +16,6 @@ ...@@ -16,13 +16,6 @@
#include <asm/portmux.h> #include <asm/portmux.h>
static const u16 per_cnt[] = {
P_CNT_CUD,
P_CNT_CDG,
P_CNT_CZM,
0
};
struct bfin_rot { struct bfin_rot {
struct input_dev *input; struct input_dev *input;
int irq; int irq;
...@@ -90,7 +83,8 @@ static irqreturn_t bfin_rotary_isr(int irq, void *dev_id) ...@@ -90,7 +83,8 @@ static irqreturn_t bfin_rotary_isr(int irq, void *dev_id)
static int bfin_rotary_probe(struct platform_device *pdev) static int bfin_rotary_probe(struct platform_device *pdev)
{ {
struct bfin_rotary_platform_data *pdata = dev_get_platdata(&pdev->dev); const struct bfin_rotary_platform_data *pdata =
dev_get_platdata(&pdev->dev);
struct bfin_rot *rotary; struct bfin_rot *rotary;
struct input_dev *input; struct input_dev *input;
int error; int error;
...@@ -101,11 +95,14 @@ static int bfin_rotary_probe(struct platform_device *pdev) ...@@ -101,11 +95,14 @@ static int bfin_rotary_probe(struct platform_device *pdev)
return -EINVAL; return -EINVAL;
} }
error = peripheral_request_list(per_cnt, dev_name(&pdev->dev)); if (pdata->pin_list) {
error = peripheral_request_list(pdata->pin_list,
dev_name(&pdev->dev));
if (error) { if (error) {
dev_err(&pdev->dev, "requesting peripherals failed\n"); dev_err(&pdev->dev, "requesting peripherals failed\n");
return error; return error;
} }
}
rotary = kzalloc(sizeof(struct bfin_rot), GFP_KERNEL); rotary = kzalloc(sizeof(struct bfin_rot), GFP_KERNEL);
input = input_allocate_device(); input = input_allocate_device();
...@@ -189,13 +186,16 @@ static int bfin_rotary_probe(struct platform_device *pdev) ...@@ -189,13 +186,16 @@ static int bfin_rotary_probe(struct platform_device *pdev)
out1: out1:
input_free_device(input); input_free_device(input);
kfree(rotary); kfree(rotary);
peripheral_free_list(per_cnt); if (pdata->pin_list)
peripheral_free_list(pdata->pin_list);
return error; return error;
} }
static int bfin_rotary_remove(struct platform_device *pdev) static int bfin_rotary_remove(struct platform_device *pdev)
{ {
const struct bfin_rotary_platform_data *pdata =
dev_get_platdata(&pdev->dev);
struct bfin_rot *rotary = platform_get_drvdata(pdev); struct bfin_rot *rotary = platform_get_drvdata(pdev);
bfin_write_CNT_CONFIG(0); bfin_write_CNT_CONFIG(0);
...@@ -203,7 +203,9 @@ static int bfin_rotary_remove(struct platform_device *pdev) ...@@ -203,7 +203,9 @@ static int bfin_rotary_remove(struct platform_device *pdev)
free_irq(rotary->irq, rotary); free_irq(rotary->irq, rotary);
input_unregister_device(rotary->input); input_unregister_device(rotary->input);
peripheral_free_list(per_cnt);
if (pdata->pin_list)
peripheral_free_list(pdata->pin_list);
kfree(rotary); kfree(rotary);
......
...@@ -40,6 +40,7 @@ struct bfin_rotary_platform_data { ...@@ -40,6 +40,7 @@ struct bfin_rotary_platform_data {
unsigned short debounce; /* 0..17 */ unsigned short debounce; /* 0..17 */
unsigned short mode; unsigned short mode;
unsigned short pm_wakeup; unsigned short pm_wakeup;
unsigned short *pin_list;
}; };
/* CNT_CONFIG bitmasks */ /* CNT_CONFIG bitmasks */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment