Commit 5f90746d authored by Jean Delvare's avatar Jean Delvare Committed by Greg Kroah-Hartman

[PATCH] I2C: Clean up i2c-amd756 and i2c-prosavage messages

A number of messages in the i2c-amd756 and i2c-prosavage drivers have a
leading ": " (especially the former). This is a legacy from lm_sensors'
printks of the 2.4 times. This patch cleans them up. While I was there,
I dropped a couple useless white spaces and dots as well.
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
parent 57336199
...@@ -116,14 +116,14 @@ static int amd756_transaction(struct i2c_adapter *adap) ...@@ -116,14 +116,14 @@ static int amd756_transaction(struct i2c_adapter *adap)
int result = 0; int result = 0;
int timeout = 0; int timeout = 0;
dev_dbg(&adap->dev, ": Transaction (pre): GS=%04x, GE=%04x, ADD=%04x, " dev_dbg(&adap->dev, "Transaction (pre): GS=%04x, GE=%04x, ADD=%04x, "
"DAT=%04x\n", inw_p(SMB_GLOBAL_STATUS), "DAT=%04x\n", inw_p(SMB_GLOBAL_STATUS),
inw_p(SMB_GLOBAL_ENABLE), inw_p(SMB_HOST_ADDRESS), inw_p(SMB_GLOBAL_ENABLE), inw_p(SMB_HOST_ADDRESS),
inb_p(SMB_HOST_DATA)); inb_p(SMB_HOST_DATA));
/* Make sure the SMBus host is ready to start transmitting */ /* Make sure the SMBus host is ready to start transmitting */
if ((temp = inw_p(SMB_GLOBAL_STATUS)) & (GS_HST_STS | GS_SMB_STS)) { if ((temp = inw_p(SMB_GLOBAL_STATUS)) & (GS_HST_STS | GS_SMB_STS)) {
dev_dbg(&adap->dev, ": SMBus busy (%04x). Waiting... \n", temp); dev_dbg(&adap->dev, "SMBus busy (%04x). Waiting...\n", temp);
do { do {
msleep(1); msleep(1);
temp = inw_p(SMB_GLOBAL_STATUS); temp = inw_p(SMB_GLOBAL_STATUS);
...@@ -131,7 +131,7 @@ static int amd756_transaction(struct i2c_adapter *adap) ...@@ -131,7 +131,7 @@ static int amd756_transaction(struct i2c_adapter *adap)
(timeout++ < MAX_TIMEOUT)); (timeout++ < MAX_TIMEOUT));
/* If the SMBus is still busy, we give up */ /* If the SMBus is still busy, we give up */
if (timeout >= MAX_TIMEOUT) { if (timeout >= MAX_TIMEOUT) {
dev_dbg(&adap->dev, ": Busy wait timeout (%04x)\n", temp); dev_dbg(&adap->dev, "Busy wait timeout (%04x)\n", temp);
goto abort; goto abort;
} }
timeout = 0; timeout = 0;
...@@ -148,46 +148,46 @@ static int amd756_transaction(struct i2c_adapter *adap) ...@@ -148,46 +148,46 @@ static int amd756_transaction(struct i2c_adapter *adap)
/* If the SMBus is still busy, we give up */ /* If the SMBus is still busy, we give up */
if (timeout >= MAX_TIMEOUT) { if (timeout >= MAX_TIMEOUT) {
dev_dbg(&adap->dev, ": Completion timeout!\n"); dev_dbg(&adap->dev, "Completion timeout!\n");
goto abort; goto abort;
} }
if (temp & GS_PRERR_STS) { if (temp & GS_PRERR_STS) {
result = -1; result = -1;
dev_dbg(&adap->dev, ": SMBus Protocol error (no response)!\n"); dev_dbg(&adap->dev, "SMBus Protocol error (no response)!\n");
} }
if (temp & GS_COL_STS) { if (temp & GS_COL_STS) {
result = -1; result = -1;
dev_warn(&adap->dev, " SMBus collision!\n"); dev_warn(&adap->dev, "SMBus collision!\n");
} }
if (temp & GS_TO_STS) { if (temp & GS_TO_STS) {
result = -1; result = -1;
dev_dbg(&adap->dev, ": SMBus protocol timeout!\n"); dev_dbg(&adap->dev, "SMBus protocol timeout!\n");
} }
if (temp & GS_HCYC_STS) if (temp & GS_HCYC_STS)
dev_dbg(&adap->dev, " SMBus protocol success!\n"); dev_dbg(&adap->dev, "SMBus protocol success!\n");
outw_p(GS_CLEAR_STS, SMB_GLOBAL_STATUS); outw_p(GS_CLEAR_STS, SMB_GLOBAL_STATUS);
#ifdef DEBUG #ifdef DEBUG
if (((temp = inw_p(SMB_GLOBAL_STATUS)) & GS_CLEAR_STS) != 0x00) { if (((temp = inw_p(SMB_GLOBAL_STATUS)) & GS_CLEAR_STS) != 0x00) {
dev_dbg(&adap->dev, dev_dbg(&adap->dev,
": Failed reset at end of transaction (%04x)\n", temp); "Failed reset at end of transaction (%04x)\n", temp);
} }
#endif #endif
dev_dbg(&adap->dev, dev_dbg(&adap->dev,
": Transaction (post): GS=%04x, GE=%04x, ADD=%04x, DAT=%04x\n", "Transaction (post): GS=%04x, GE=%04x, ADD=%04x, DAT=%04x\n",
inw_p(SMB_GLOBAL_STATUS), inw_p(SMB_GLOBAL_ENABLE), inw_p(SMB_GLOBAL_STATUS), inw_p(SMB_GLOBAL_ENABLE),
inw_p(SMB_HOST_ADDRESS), inb_p(SMB_HOST_DATA)); inw_p(SMB_HOST_ADDRESS), inb_p(SMB_HOST_DATA));
return result; return result;
abort: abort:
dev_warn(&adap->dev, ": Sending abort.\n"); dev_warn(&adap->dev, "Sending abort\n");
outw_p(inw(SMB_GLOBAL_ENABLE) | GE_ABORT, SMB_GLOBAL_ENABLE); outw_p(inw(SMB_GLOBAL_ENABLE) | GE_ABORT, SMB_GLOBAL_ENABLE);
msleep(100); msleep(100);
outw_p(GS_CLEAR_STS, SMB_GLOBAL_STATUS); outw_p(GS_CLEAR_STS, SMB_GLOBAL_STATUS);
...@@ -204,7 +204,7 @@ static s32 amd756_access(struct i2c_adapter * adap, u16 addr, ...@@ -204,7 +204,7 @@ static s32 amd756_access(struct i2c_adapter * adap, u16 addr,
/** TODO: Should I supporte the 10-bit transfers? */ /** TODO: Should I supporte the 10-bit transfers? */
switch (size) { switch (size) {
case I2C_SMBUS_PROC_CALL: case I2C_SMBUS_PROC_CALL:
dev_dbg(&adap->dev, ": I2C_SMBUS_PROC_CALL not supported!\n"); dev_dbg(&adap->dev, "I2C_SMBUS_PROC_CALL not supported!\n");
/* TODO: Well... It is supported, I'm just not sure what to do here... */ /* TODO: Well... It is supported, I'm just not sure what to do here... */
return -1; return -1;
case I2C_SMBUS_QUICK: case I2C_SMBUS_QUICK:
...@@ -334,8 +334,8 @@ static int __devinit amd756_probe(struct pci_dev *pdev, ...@@ -334,8 +334,8 @@ static int __devinit amd756_probe(struct pci_dev *pdev,
u8 temp; u8 temp;
if (amd756_ioport) { if (amd756_ioport) {
dev_err(&pdev->dev, ": Only one device supported. " dev_err(&pdev->dev, "Only one device supported "
"(you have a strange motherboard, btw..)\n"); "(you have a strange motherboard, btw)\n");
return -ENODEV; return -ENODEV;
} }
...@@ -352,7 +352,7 @@ static int __devinit amd756_probe(struct pci_dev *pdev, ...@@ -352,7 +352,7 @@ static int __devinit amd756_probe(struct pci_dev *pdev,
pci_read_config_byte(pdev, SMBGCFG, &temp); pci_read_config_byte(pdev, SMBGCFG, &temp);
if ((temp & 128) == 0) { if ((temp & 128) == 0) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
": Error: SMBus controller I/O not enabled!\n"); "Error: SMBus controller I/O not enabled!\n");
return -ENODEV; return -ENODEV;
} }
...@@ -364,14 +364,14 @@ static int __devinit amd756_probe(struct pci_dev *pdev, ...@@ -364,14 +364,14 @@ static int __devinit amd756_probe(struct pci_dev *pdev,
} }
if (!request_region(amd756_ioport, SMB_IOSIZE, "amd756-smbus")) { if (!request_region(amd756_ioport, SMB_IOSIZE, "amd756-smbus")) {
dev_err(&pdev->dev, ": SMB region 0x%x already in use!\n", dev_err(&pdev->dev, "SMB region 0x%x already in use!\n",
amd756_ioport); amd756_ioport);
return -ENODEV; return -ENODEV;
} }
pci_read_config_byte(pdev, SMBREV, &temp); pci_read_config_byte(pdev, SMBREV, &temp);
dev_dbg(&pdev->dev, ": SMBREV = 0x%X\n", temp); dev_dbg(&pdev->dev, "SMBREV = 0x%X\n", temp);
dev_dbg(&pdev->dev, ": AMD756_smba = 0x%X\n", amd756_ioport); dev_dbg(&pdev->dev, "AMD756_smba = 0x%X\n", amd756_ioport);
/* set up the driverfs linkage to our parent device */ /* set up the driverfs linkage to our parent device */
amd756_adapter.dev.parent = &pdev->dev; amd756_adapter.dev.parent = &pdev->dev;
...@@ -382,7 +382,7 @@ static int __devinit amd756_probe(struct pci_dev *pdev, ...@@ -382,7 +382,7 @@ static int __devinit amd756_probe(struct pci_dev *pdev,
error = i2c_add_adapter(&amd756_adapter); error = i2c_add_adapter(&amd756_adapter);
if (error) { if (error) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
": Adapter registration failed, module not inserted.\n"); "Adapter registration failed, module not inserted\n");
goto out_err; goto out_err;
} }
......
...@@ -228,7 +228,7 @@ static void prosavage_remove(struct pci_dev *dev) ...@@ -228,7 +228,7 @@ static void prosavage_remove(struct pci_dev *dev)
ret = i2c_bit_del_bus(&chip->i2c_bus[i].adap); ret = i2c_bit_del_bus(&chip->i2c_bus[i].adap);
if (ret) { if (ret) {
dev_err(&dev->dev, ": %s not removed\n", dev_err(&dev->dev, "%s not removed\n",
chip->i2c_bus[i].adap.name); chip->i2c_bus[i].adap.name);
} }
} }
...@@ -298,7 +298,7 @@ static int __devinit prosavage_probe(struct pci_dev *dev, const struct pci_devic ...@@ -298,7 +298,7 @@ static int __devinit prosavage_probe(struct pci_dev *dev, const struct pci_devic
} }
return 0; return 0;
err_adap: err_adap:
dev_err(&dev->dev, ": %s failed\n", bus->adap.name); dev_err(&dev->dev, "%s failed\n", bus->adap.name);
prosavage_remove(dev); prosavage_remove(dev);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment