Commit 6010ce3f authored by Rafael J. Wysocki's avatar Rafael J. Wysocki

ACPI: debug: Clean up acpi_aml_init()

The err_exit label in acpi_aml_init() is not used any more after
commit 9ec6dbfb ("ACPI: no need to check return value of
debugfs_create functions"), but the other label in there is not
necessary too, so rearrange the code to get rid of them both.

No intentional functional impact.

Fixes: 9ec6dbfb ("ACPI: no need to check return value of debugfs_create functions")
Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 9ec6dbfb
...@@ -750,29 +750,28 @@ static const struct acpi_debugger_ops acpi_aml_debugger = { ...@@ -750,29 +750,28 @@ static const struct acpi_debugger_ops acpi_aml_debugger = {
int __init acpi_aml_init(void) int __init acpi_aml_init(void)
{ {
int ret = 0; int ret;
/* Initialize AML IO interface */ /* Initialize AML IO interface */
mutex_init(&acpi_aml_io.lock); mutex_init(&acpi_aml_io.lock);
init_waitqueue_head(&acpi_aml_io.wait); init_waitqueue_head(&acpi_aml_io.wait);
acpi_aml_io.out_crc.buf = acpi_aml_io.out_buf; acpi_aml_io.out_crc.buf = acpi_aml_io.out_buf;
acpi_aml_io.in_crc.buf = acpi_aml_io.in_buf; acpi_aml_io.in_crc.buf = acpi_aml_io.in_buf;
acpi_aml_dentry = debugfs_create_file("acpidbg", acpi_aml_dentry = debugfs_create_file("acpidbg",
S_IFREG | S_IRUGO | S_IWUSR, S_IFREG | S_IRUGO | S_IWUSR,
acpi_debugfs_dir, NULL, acpi_debugfs_dir, NULL,
&acpi_aml_operations); &acpi_aml_operations);
ret = acpi_register_debugger(THIS_MODULE, &acpi_aml_debugger);
if (ret)
goto err_fs;
acpi_aml_initialized = true;
err_fs: ret = acpi_register_debugger(THIS_MODULE, &acpi_aml_debugger);
if (ret) { if (ret) {
debugfs_remove(acpi_aml_dentry); debugfs_remove(acpi_aml_dentry);
acpi_aml_dentry = NULL; acpi_aml_dentry = NULL;
}
err_exit:
return ret; return ret;
}
acpi_aml_initialized = true;
return 0;
} }
void __exit acpi_aml_exit(void) void __exit acpi_aml_exit(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment