Commit 63b2ed4e authored by Stefan Chulski's avatar Stefan Chulski Committed by David S. Miller

net: phylink: Fix flow control resolution

Regarding to IEEE 802.3-2015 standard section 2
28B.3 Priority resolution - Table 28-3 - Pause resolution

In case of Local device Pause=1 AsymDir=0, Link partner
Pause=1 AsymDir=1, Local device resolution should be enable PAUSE
transmit, disable PAUSE receive.
And in case of Local device Pause=1 AsymDir=1, Link partner
Pause=1 AsymDir=0, Local device resolution should be enable PAUSE
receive, disable PAUSE transmit.

Fixes: 9525ae83 ("phylink: add phylink infrastructure")
Signed-off-by: default avatarStefan Chulski <stefanc@marvell.com>
Reported-by: default avatarShaul Ben-Mayor <shaulb@marvell.com>
Acked-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b82573fd
...@@ -376,8 +376,8 @@ static void phylink_get_fixed_state(struct phylink *pl, struct phylink_link_stat ...@@ -376,8 +376,8 @@ static void phylink_get_fixed_state(struct phylink *pl, struct phylink_link_stat
* Local device Link partner * Local device Link partner
* Pause AsymDir Pause AsymDir Result * Pause AsymDir Pause AsymDir Result
* 1 X 1 X TX+RX * 1 X 1 X TX+RX
* 0 1 1 1 RX * 0 1 1 1 TX
* 1 1 0 1 TX * 1 1 0 1 RX
*/ */
static void phylink_resolve_flow(struct phylink *pl, static void phylink_resolve_flow(struct phylink *pl,
struct phylink_link_state *state) struct phylink_link_state *state)
...@@ -398,7 +398,7 @@ static void phylink_resolve_flow(struct phylink *pl, ...@@ -398,7 +398,7 @@ static void phylink_resolve_flow(struct phylink *pl,
new_pause = MLO_PAUSE_TX | MLO_PAUSE_RX; new_pause = MLO_PAUSE_TX | MLO_PAUSE_RX;
else if (pause & MLO_PAUSE_ASYM) else if (pause & MLO_PAUSE_ASYM)
new_pause = state->pause & MLO_PAUSE_SYM ? new_pause = state->pause & MLO_PAUSE_SYM ?
MLO_PAUSE_RX : MLO_PAUSE_TX; MLO_PAUSE_TX : MLO_PAUSE_RX;
} else { } else {
new_pause = pl->link_config.pause & MLO_PAUSE_TXRX_MASK; new_pause = pl->link_config.pause & MLO_PAUSE_TXRX_MASK;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment