Commit 643263c1 authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Ben Hutchings

fuse: invalidate dir dentry after chmod

commit 5e2b8828 upstream.

Without "default_permissions" the userspace filesystem's lookup operation
needs to perform the check for search permission on the directory.

If directory does not allow search for everyone (this is quite rare) then
userspace filesystem has to set entry timeout to zero to make sure
permissions are always performed.

Changing the mode bits of the directory should also invalidate the
(previously cached) dentry to make sure the next lookup will have a chance
of updating the timeout, if needed.
Reported-by: default avatarJean-Pierre André <jean-pierre.andre@wanadoo.fr>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
[bwh: Backported to 3.2:
 - Adjust context
 - Open-code d_is_dir()]
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent d03cb14e
...@@ -1393,10 +1393,20 @@ static int fuse_do_setattr(struct dentry *entry, struct iattr *attr, ...@@ -1393,10 +1393,20 @@ static int fuse_do_setattr(struct dentry *entry, struct iattr *attr,
static int fuse_setattr(struct dentry *entry, struct iattr *attr) static int fuse_setattr(struct dentry *entry, struct iattr *attr)
{ {
int ret;
if (attr->ia_valid & ATTR_FILE) if (attr->ia_valid & ATTR_FILE)
return fuse_do_setattr(entry, attr, attr->ia_file); ret = fuse_do_setattr(entry, attr, attr->ia_file);
else else
return fuse_do_setattr(entry, attr, NULL); ret = fuse_do_setattr(entry, attr, NULL);
if (!ret) {
/* Directory mode changed, may need to revalidate access */
if (S_ISDIR(entry->d_inode->i_mode) &&
(attr->ia_valid & ATTR_MODE))
fuse_invalidate_entry_cache(entry);
}
return ret;
} }
static int fuse_getattr(struct vfsmount *mnt, struct dentry *entry, static int fuse_getattr(struct vfsmount *mnt, struct dentry *entry,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment