Commit 64ebe955 authored by Axel Lin's avatar Axel Lin Committed by Jonathan Cameron

iio: hid-sensor: Return proper error if kmemdup fails

Return -ENOMEM instead of 0 if kmemdup fails.
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 95273f89
...@@ -306,10 +306,10 @@ static int __devinit hid_accel_3d_probe(struct platform_device *pdev) ...@@ -306,10 +306,10 @@ static int __devinit hid_accel_3d_probe(struct platform_device *pdev)
goto error_free_dev; goto error_free_dev;
} }
channels = kmemdup(accel_3d_channels, channels = kmemdup(accel_3d_channels, sizeof(accel_3d_channels),
sizeof(accel_3d_channels),
GFP_KERNEL); GFP_KERNEL);
if (!channels) { if (!channels) {
ret = -ENOMEM;
dev_err(&pdev->dev, "failed to duplicate channels\n"); dev_err(&pdev->dev, "failed to duplicate channels\n");
goto error_free_dev; goto error_free_dev;
} }
......
...@@ -306,10 +306,10 @@ static int __devinit hid_gyro_3d_probe(struct platform_device *pdev) ...@@ -306,10 +306,10 @@ static int __devinit hid_gyro_3d_probe(struct platform_device *pdev)
goto error_free_dev; goto error_free_dev;
} }
channels = kmemdup(gyro_3d_channels, channels = kmemdup(gyro_3d_channels, sizeof(gyro_3d_channels),
sizeof(gyro_3d_channels),
GFP_KERNEL); GFP_KERNEL);
if (!channels) { if (!channels) {
ret = -ENOMEM;
dev_err(&pdev->dev, "failed to duplicate channels\n"); dev_err(&pdev->dev, "failed to duplicate channels\n");
goto error_free_dev; goto error_free_dev;
} }
......
...@@ -272,10 +272,9 @@ static int __devinit hid_als_probe(struct platform_device *pdev) ...@@ -272,10 +272,9 @@ static int __devinit hid_als_probe(struct platform_device *pdev)
goto error_free_dev; goto error_free_dev;
} }
channels = kmemdup(als_channels, channels = kmemdup(als_channels, sizeof(als_channels), GFP_KERNEL);
sizeof(als_channels),
GFP_KERNEL);
if (!channels) { if (!channels) {
ret = -ENOMEM;
dev_err(&pdev->dev, "failed to duplicate channels\n"); dev_err(&pdev->dev, "failed to duplicate channels\n");
goto error_free_dev; goto error_free_dev;
} }
......
...@@ -307,10 +307,10 @@ static int __devinit hid_magn_3d_probe(struct platform_device *pdev) ...@@ -307,10 +307,10 @@ static int __devinit hid_magn_3d_probe(struct platform_device *pdev)
goto error_free_dev; goto error_free_dev;
} }
channels = kmemdup(magn_3d_channels, channels = kmemdup(magn_3d_channels, sizeof(magn_3d_channels),
sizeof(magn_3d_channels),
GFP_KERNEL); GFP_KERNEL);
if (!channels) { if (!channels) {
ret = -ENOMEM;
dev_err(&pdev->dev, "failed to duplicate channels\n"); dev_err(&pdev->dev, "failed to duplicate channels\n");
goto error_free_dev; goto error_free_dev;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment