Commit 691d62e8 authored by Borislav Petkov's avatar Borislav Petkov Committed by Greg Kroah-Hartman

[PATCH] USB: fix up usblp usb_unlink_urb() warning

On Thursday 09 September 2004 08:38, Greg KH wrote:
> On Thu, Sep 09, 2004 at 01:07:05AM -0400, Gene Heskett wrote:
> > Greetings;
> >
> > I just had to reboot back to -mm2 after playing with some printer configs
> > in cups, although the test pages worked, so I'm not sure what this all
> > about, from var log/messages:
> >
> > Sep  8 23:13:42 coyote cups: cupsd -HUP succeeded
> > Sep  8 23:13:43 coyote kernel: usb_unlink_urb() is deprecated for
> > synchronous unlinks.  Use usb_kill_urb() Sep  8 23:13:43 coyote kernel:
> > Badness in usb_unlink_urb at drivers/usb/core/urb.c:456 Sep  8 23:13:44
> > coyote kernel:  [<c01048ce>] dump_stack+0x1e/0x20 Sep  8 23:13:44 coyote
> > kernel:  [<c0295f35>] usb_unlink_urb+0x85/0xa0 Sep  8 23:13:44 coyote
> > kernel:  [<c02a7447>] usblp_unlink_urbs+0x17/0x40 Sep  8 23:13:44 coyote
> > kernel:  [<c02a74a8>] usblp_release+0x38/0x60 Sep  8 23:13:44 coyote
> > kernel:  [<c01501ea>] __fput+0x12a/0x140
> > Sep  8 23:13:44 coyote kernel:  [<c014e8e7>] filp_close+0x57/0x80
> > Sep  8 23:13:44 coyote kernel:  [<c014e971>] sys_close+0x61/0x90
> > Sep  8 23:13:44 coyote kernel:  [<c010425d>] sysenter_past_esp+0x52/0x71
Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
parent af084fbb
......@@ -410,9 +410,9 @@ static void usblp_cleanup (struct usblp *usblp)
static void usblp_unlink_urbs(struct usblp *usblp)
{
usb_unlink_urb(usblp->writeurb);
usb_kill_urb(usblp->writeurb);
if (usblp->bidir)
usb_unlink_urb(usblp->readurb);
usb_kill_urb(usblp->readurb);
}
static int usblp_release(struct inode *inode, struct file *file)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment