Commit 6b349dfe authored by Daichou's avatar Daichou Committed by David Sterba

Btrfs: remove obsolete FIXMEs in qgroup ioctls

These FIXMEs were already addressed in 2013. All functions check for
qgroup existence:

* btrfs_add_qgroup_relation
* btrfs_ioctl_qgroup_create
* btrfs_limit_qgroup
* btrfs_del_qgroup_relation
Signed-off-by: default avatarDaichou <tommy0705c@gmail.com>
[ enhance and reformat changelog ]
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 62b163f0
...@@ -4897,7 +4897,6 @@ static long btrfs_ioctl_qgroup_assign(struct file *file, void __user *arg) ...@@ -4897,7 +4897,6 @@ static long btrfs_ioctl_qgroup_assign(struct file *file, void __user *arg)
goto out; goto out;
} }
/* FIXME: check if the IDs really exist */
if (sa->assign) { if (sa->assign) {
ret = btrfs_add_qgroup_relation(trans, fs_info, ret = btrfs_add_qgroup_relation(trans, fs_info,
sa->src, sa->dst); sa->src, sa->dst);
...@@ -4956,7 +4955,6 @@ static long btrfs_ioctl_qgroup_create(struct file *file, void __user *arg) ...@@ -4956,7 +4955,6 @@ static long btrfs_ioctl_qgroup_create(struct file *file, void __user *arg)
goto out; goto out;
} }
/* FIXME: check if the IDs really exist */
if (sa->create) { if (sa->create) {
ret = btrfs_create_qgroup(trans, fs_info, sa->qgroupid); ret = btrfs_create_qgroup(trans, fs_info, sa->qgroupid);
} else { } else {
...@@ -5010,7 +5008,6 @@ static long btrfs_ioctl_qgroup_limit(struct file *file, void __user *arg) ...@@ -5010,7 +5008,6 @@ static long btrfs_ioctl_qgroup_limit(struct file *file, void __user *arg)
qgroupid = root->root_key.objectid; qgroupid = root->root_key.objectid;
} }
/* FIXME: check if the IDs really exist */
ret = btrfs_limit_qgroup(trans, fs_info, qgroupid, &sa->lim); ret = btrfs_limit_qgroup(trans, fs_info, qgroupid, &sa->lim);
err = btrfs_end_transaction(trans); err = btrfs_end_transaction(trans);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment