Commit 73092892 authored by James Simmons's avatar James Simmons Committed by Greg Kroah-Hartman

staging:lustre: lib-socket.c code cleanup - indentation etc

Handle all the style issues reported by checkpatch.pl.
Remove general white spaces, spaces in function calls,
etc.
Signed-off-by: default avatarJames Simmons <jsimmons@infradead.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5c2414ef
...@@ -1378,14 +1378,14 @@ ksocknal_create_conn(lnet_ni_t *ni, ksock_route_t *route, ...@@ -1378,14 +1378,14 @@ ksocknal_create_conn(lnet_ni_t *ni, ksock_route_t *route,
ksocknal_txlist_done(ni, &zombies, 1); ksocknal_txlist_done(ni, &zombies, 1);
ksocknal_peer_decref(peer); ksocknal_peer_decref(peer);
failed_1: failed_1:
if (hello != NULL) if (hello != NULL)
LIBCFS_FREE(hello, offsetof(ksock_hello_msg_t, LIBCFS_FREE(hello, offsetof(ksock_hello_msg_t,
kshm_ips[LNET_MAX_INTERFACES])); kshm_ips[LNET_MAX_INTERFACES]));
LIBCFS_FREE(conn, sizeof(*conn)); LIBCFS_FREE(conn, sizeof(*conn));
failed_0: failed_0:
sock_release(sock); sock_release(sock);
return rc; return rc;
} }
......
...@@ -67,9 +67,9 @@ lnet_sock_ioctl(int cmd, unsigned long arg) ...@@ -67,9 +67,9 @@ lnet_sock_ioctl(int cmd, unsigned long arg)
struct socket *sock; struct socket *sock;
int rc; int rc;
rc = sock_create (PF_INET, SOCK_STREAM, 0, &sock); rc = sock_create(PF_INET, SOCK_STREAM, 0, &sock);
if (rc != 0) { if (rc != 0) {
CERROR ("Can't create socket: %d\n", rc); CERROR("Can't create socket: %d\n", rc);
return rc; return rc;
} }
...@@ -88,7 +88,7 @@ lnet_sock_ioctl(int cmd, unsigned long arg) ...@@ -88,7 +88,7 @@ lnet_sock_ioctl(int cmd, unsigned long arg)
} }
int int
lnet_ipif_query (char *name, int *up, __u32 *ip, __u32 *mask) lnet_ipif_query(char *name, int *up, __u32 *ip, __u32 *mask)
{ {
struct ifreq ifr; struct ifreq ifr;
int nob; int nob;
...@@ -101,7 +101,7 @@ lnet_ipif_query (char *name, int *up, __u32 *ip, __u32 *mask) ...@@ -101,7 +101,7 @@ lnet_ipif_query (char *name, int *up, __u32 *ip, __u32 *mask)
return -EINVAL; return -EINVAL;
} }
CLASSERT (sizeof(ifr.ifr_name) >= IFNAMSIZ); CLASSERT(sizeof(ifr.ifr_name) >= IFNAMSIZ);
strcpy(ifr.ifr_name, name); strcpy(ifr.ifr_name, name);
rc = lnet_sock_ioctl(SIOCGIFFLAGS, (unsigned long)&ifr); rc = lnet_sock_ioctl(SIOCGIFFLAGS, (unsigned long)&ifr);
...@@ -116,7 +116,6 @@ lnet_ipif_query (char *name, int *up, __u32 *ip, __u32 *mask) ...@@ -116,7 +116,6 @@ lnet_ipif_query (char *name, int *up, __u32 *ip, __u32 *mask)
*ip = *mask = 0; *ip = *mask = 0;
return 0; return 0;
} }
*up = 1; *up = 1;
strcpy(ifr.ifr_name, name); strcpy(ifr.ifr_name, name);
...@@ -143,11 +142,10 @@ lnet_ipif_query (char *name, int *up, __u32 *ip, __u32 *mask) ...@@ -143,11 +142,10 @@ lnet_ipif_query (char *name, int *up, __u32 *ip, __u32 *mask)
return 0; return 0;
} }
EXPORT_SYMBOL(lnet_ipif_query); EXPORT_SYMBOL(lnet_ipif_query);
int int
lnet_ipif_enumerate (char ***namesp) lnet_ipif_enumerate(char ***namesp)
{ {
/* Allocate and fill in 'names', returning # interfaces/error */ /* Allocate and fill in 'names', returning # interfaces/error */
char **names; char **names;
...@@ -160,7 +158,6 @@ lnet_ipif_enumerate (char ***namesp) ...@@ -160,7 +158,6 @@ lnet_ipif_enumerate (char ***namesp)
int nob; int nob;
int i; int i;
nalloc = 16; /* first guess at max interfaces */ nalloc = 16; /* first guess at max interfaces */
toobig = 0; toobig = 0;
for (;;) { for (;;) {
...@@ -173,7 +170,8 @@ lnet_ipif_enumerate (char ***namesp) ...@@ -173,7 +170,8 @@ lnet_ipif_enumerate (char ***namesp)
LIBCFS_ALLOC(ifr, nalloc * sizeof(*ifr)); LIBCFS_ALLOC(ifr, nalloc * sizeof(*ifr));
if (ifr == NULL) { if (ifr == NULL) {
CERROR ("ENOMEM enumerating up to %d interfaces\n", nalloc); CERROR("ENOMEM enumerating up to %d interfaces\n",
nalloc);
rc = -ENOMEM; rc = -ENOMEM;
goto out0; goto out0;
} }
...@@ -183,14 +181,14 @@ lnet_ipif_enumerate (char ***namesp) ...@@ -183,14 +181,14 @@ lnet_ipif_enumerate (char ***namesp)
rc = lnet_sock_ioctl(SIOCGIFCONF, (unsigned long)&ifc); rc = lnet_sock_ioctl(SIOCGIFCONF, (unsigned long)&ifc);
if (rc < 0) { if (rc < 0) {
CERROR ("Error %d enumerating interfaces\n", rc); CERROR("Error %d enumerating interfaces\n", rc);
goto out1; goto out1;
} }
LASSERT (rc == 0); LASSERT(rc == 0);
nfound = ifc.ifc_len/sizeof(*ifr); nfound = ifc.ifc_len/sizeof(*ifr);
LASSERT (nfound <= nalloc); LASSERT(nfound <= nalloc);
if (nfound < nalloc || toobig) if (nfound < nalloc || toobig)
break; break;
...@@ -209,8 +207,7 @@ lnet_ipif_enumerate (char ***namesp) ...@@ -209,8 +207,7 @@ lnet_ipif_enumerate (char ***namesp)
} }
for (i = 0; i < nfound; i++) { for (i = 0; i < nfound; i++) {
nob = strnlen(ifr[i].ifr_name, IFNAMSIZ);
nob = strnlen (ifr[i].ifr_name, IFNAMSIZ);
if (nob == IFNAMSIZ) { if (nob == IFNAMSIZ) {
/* no space for terminating NULL */ /* no space for terminating NULL */
CERROR("interface name %.*s too long (%d max)\n", CERROR("interface name %.*s too long (%d max)\n",
...@@ -232,41 +229,39 @@ lnet_ipif_enumerate (char ***namesp) ...@@ -232,41 +229,39 @@ lnet_ipif_enumerate (char ***namesp)
*namesp = names; *namesp = names;
rc = nfound; rc = nfound;
out2: out2:
if (rc < 0) if (rc < 0)
lnet_ipif_free_enumeration(names, nfound); lnet_ipif_free_enumeration(names, nfound);
out1: out1:
LIBCFS_FREE(ifr, nalloc * sizeof(*ifr)); LIBCFS_FREE(ifr, nalloc * sizeof(*ifr));
out0: out0:
return rc; return rc;
} }
EXPORT_SYMBOL(lnet_ipif_enumerate); EXPORT_SYMBOL(lnet_ipif_enumerate);
void void
lnet_ipif_free_enumeration (char **names, int n) lnet_ipif_free_enumeration(char **names, int n)
{ {
int i; int i;
LASSERT (n > 0); LASSERT(n > 0);
for (i = 0; i < n && names[i] != NULL; i++) for (i = 0; i < n && names[i] != NULL; i++)
LIBCFS_FREE(names[i], IFNAMSIZ); LIBCFS_FREE(names[i], IFNAMSIZ);
LIBCFS_FREE(names, n * sizeof(*names)); LIBCFS_FREE(names, n * sizeof(*names));
} }
EXPORT_SYMBOL(lnet_ipif_free_enumeration); EXPORT_SYMBOL(lnet_ipif_free_enumeration);
int int
lnet_sock_write (struct socket *sock, void *buffer, int nob, int timeout) lnet_sock_write(struct socket *sock, void *buffer, int nob, int timeout)
{ {
int rc; int rc;
long ticks = timeout * HZ; long ticks = timeout * HZ;
unsigned long then; unsigned long then;
struct timeval tv; struct timeval tv;
LASSERT (nob > 0); LASSERT(nob > 0);
/* Caller may pass a zero timeout if she thinks the socket buffer is /* Caller may pass a zero timeout if she thinks the socket buffer is
* empty enough to take the whole message immediately */ * empty enough to take the whole message immediately */
...@@ -305,7 +300,7 @@ lnet_sock_write (struct socket *sock, void *buffer, int nob, int timeout) ...@@ -305,7 +300,7 @@ lnet_sock_write (struct socket *sock, void *buffer, int nob, int timeout)
return rc; return rc;
if (rc == 0) { if (rc == 0) {
CERROR ("Unexpected zero rc\n"); CERROR("Unexpected zero rc\n");
return -ECONNABORTED; return -ECONNABORTED;
} }
...@@ -315,21 +310,20 @@ lnet_sock_write (struct socket *sock, void *buffer, int nob, int timeout) ...@@ -315,21 +310,20 @@ lnet_sock_write (struct socket *sock, void *buffer, int nob, int timeout)
buffer = ((char *)buffer) + rc; buffer = ((char *)buffer) + rc;
nob -= rc; nob -= rc;
} }
return 0; return 0;
} }
EXPORT_SYMBOL(lnet_sock_write); EXPORT_SYMBOL(lnet_sock_write);
int int
lnet_sock_read (struct socket *sock, void *buffer, int nob, int timeout) lnet_sock_read(struct socket *sock, void *buffer, int nob, int timeout)
{ {
int rc; int rc;
long ticks = timeout * HZ; long ticks = timeout * HZ;
unsigned long then; unsigned long then;
struct timeval tv; struct timeval tv;
LASSERT (nob > 0); LASSERT(nob > 0);
LASSERT (ticks > 0); LASSERT(ticks > 0);
for (;;) { for (;;) {
struct kvec iov = { struct kvec iov = {
...@@ -373,12 +367,11 @@ lnet_sock_read (struct socket *sock, void *buffer, int nob, int timeout) ...@@ -373,12 +367,11 @@ lnet_sock_read (struct socket *sock, void *buffer, int nob, int timeout)
return -ETIMEDOUT; return -ETIMEDOUT;
} }
} }
EXPORT_SYMBOL(lnet_sock_read); EXPORT_SYMBOL(lnet_sock_read);
static int static int
lnet_sock_create (struct socket **sockp, int *fatal, lnet_sock_create(struct socket **sockp, int *fatal, __u32 local_ip,
__u32 local_ip, int local_port) int local_port)
{ {
struct sockaddr_in locaddr; struct sockaddr_in locaddr;
struct socket *sock; struct socket *sock;
...@@ -388,16 +381,16 @@ lnet_sock_create (struct socket **sockp, int *fatal, ...@@ -388,16 +381,16 @@ lnet_sock_create (struct socket **sockp, int *fatal,
/* All errors are fatal except bind failure if the port is in use */ /* All errors are fatal except bind failure if the port is in use */
*fatal = 1; *fatal = 1;
rc = sock_create (PF_INET, SOCK_STREAM, 0, &sock); rc = sock_create(PF_INET, SOCK_STREAM, 0, &sock);
*sockp = sock; *sockp = sock;
if (rc != 0) { if (rc != 0) {
CERROR ("Can't create socket: %d\n", rc); CERROR("Can't create socket: %d\n", rc);
return rc; return rc;
} }
option = 1; option = 1;
rc = kernel_setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, rc = kernel_setsockopt(sock, SOL_SOCKET, SO_REUSEADDR,
(char *)&option, sizeof (option)); (char *)&option, sizeof(option));
if (rc != 0) { if (rc != 0) {
CERROR("Can't set SO_REUSEADDR for socket: %d\n", rc); CERROR("Can't set SO_REUSEADDR for socket: %d\n", rc);
goto failed; goto failed;
...@@ -423,16 +416,15 @@ lnet_sock_create (struct socket **sockp, int *fatal, ...@@ -423,16 +416,15 @@ lnet_sock_create (struct socket **sockp, int *fatal,
goto failed; goto failed;
} }
} }
return 0; return 0;
failed: failed:
sock_release(sock); sock_release(sock);
return rc; return rc;
} }
int int
lnet_sock_setbuf (struct socket *sock, int txbufsize, int rxbufsize) lnet_sock_setbuf(struct socket *sock, int txbufsize, int rxbufsize)
{ {
int option; int option;
int rc; int rc;
...@@ -440,9 +432,9 @@ lnet_sock_setbuf (struct socket *sock, int txbufsize, int rxbufsize) ...@@ -440,9 +432,9 @@ lnet_sock_setbuf (struct socket *sock, int txbufsize, int rxbufsize)
if (txbufsize != 0) { if (txbufsize != 0) {
option = txbufsize; option = txbufsize;
rc = kernel_setsockopt(sock, SOL_SOCKET, SO_SNDBUF, rc = kernel_setsockopt(sock, SOL_SOCKET, SO_SNDBUF,
(char *)&option, sizeof (option)); (char *)&option, sizeof(option));
if (rc != 0) { if (rc != 0) {
CERROR ("Can't set send buffer %d: %d\n", CERROR("Can't set send buffer %d: %d\n",
option, rc); option, rc);
return rc; return rc;
} }
...@@ -451,24 +443,22 @@ lnet_sock_setbuf (struct socket *sock, int txbufsize, int rxbufsize) ...@@ -451,24 +443,22 @@ lnet_sock_setbuf (struct socket *sock, int txbufsize, int rxbufsize)
if (rxbufsize != 0) { if (rxbufsize != 0) {
option = rxbufsize; option = rxbufsize;
rc = kernel_setsockopt(sock, SOL_SOCKET, SO_RCVBUF, rc = kernel_setsockopt(sock, SOL_SOCKET, SO_RCVBUF,
(char *)&option, sizeof (option)); (char *)&option, sizeof(option));
if (rc != 0) { if (rc != 0) {
CERROR ("Can't set receive buffer %d: %d\n", CERROR("Can't set receive buffer %d: %d\n",
option, rc); option, rc);
return rc; return rc;
} }
} }
return 0; return 0;
} }
EXPORT_SYMBOL(lnet_sock_setbuf); EXPORT_SYMBOL(lnet_sock_setbuf);
int int
lnet_sock_getaddr (struct socket *sock, bool remote, __u32 *ip, int *port) lnet_sock_getaddr(struct socket *sock, bool remote, __u32 *ip, int *port)
{ {
struct sockaddr_in sin; struct sockaddr_in sin;
int len = sizeof (sin); int len = sizeof(sin);
int rc; int rc;
if (remote) if (remote)
...@@ -476,42 +466,37 @@ lnet_sock_getaddr (struct socket *sock, bool remote, __u32 *ip, int *port) ...@@ -476,42 +466,37 @@ lnet_sock_getaddr (struct socket *sock, bool remote, __u32 *ip, int *port)
else else
rc = kernel_getsockname(sock, (struct sockaddr *)&sin, &len); rc = kernel_getsockname(sock, (struct sockaddr *)&sin, &len);
if (rc != 0) { if (rc != 0) {
CERROR ("Error %d getting sock %s IP/port\n", CERROR("Error %d getting sock %s IP/port\n",
rc, remote ? "peer" : "local"); rc, remote ? "peer" : "local");
return rc; return rc;
} }
if (ip != NULL) if (ip != NULL)
*ip = ntohl (sin.sin_addr.s_addr); *ip = ntohl(sin.sin_addr.s_addr);
if (port != NULL) if (port != NULL)
*port = ntohs (sin.sin_port); *port = ntohs(sin.sin_port);
return 0; return 0;
} }
EXPORT_SYMBOL(lnet_sock_getaddr); EXPORT_SYMBOL(lnet_sock_getaddr);
int int
lnet_sock_getbuf (struct socket *sock, int *txbufsize, int *rxbufsize) lnet_sock_getbuf(struct socket *sock, int *txbufsize, int *rxbufsize)
{ {
if (txbufsize != NULL)
if (txbufsize != NULL) {
*txbufsize = sock->sk->sk_sndbuf; *txbufsize = sock->sk->sk_sndbuf;
}
if (rxbufsize != NULL) { if (rxbufsize != NULL)
*rxbufsize = sock->sk->sk_rcvbuf; *rxbufsize = sock->sk->sk_rcvbuf;
}
return 0; return 0;
} }
EXPORT_SYMBOL(lnet_sock_getbuf); EXPORT_SYMBOL(lnet_sock_getbuf);
int int
lnet_sock_listen (struct socket **sockp, lnet_sock_listen(struct socket **sockp, __u32 local_ip, int local_port,
__u32 local_ip, int local_port, int backlog) int backlog)
{ {
int fatal; int fatal;
int rc; int rc;
...@@ -532,11 +517,10 @@ lnet_sock_listen (struct socket **sockp, ...@@ -532,11 +517,10 @@ lnet_sock_listen (struct socket **sockp,
sock_release(*sockp); sock_release(*sockp);
return rc; return rc;
} }
EXPORT_SYMBOL(lnet_sock_listen); EXPORT_SYMBOL(lnet_sock_listen);
int int
lnet_sock_accept (struct socket **newsockp, struct socket *sock) lnet_sock_accept(struct socket **newsockp, struct socket *sock)
{ {
wait_queue_t wait; wait_queue_t wait;
struct socket *newsock; struct socket *newsock;
...@@ -571,17 +555,15 @@ lnet_sock_accept (struct socket **newsockp, struct socket *sock) ...@@ -571,17 +555,15 @@ lnet_sock_accept (struct socket **newsockp, struct socket *sock)
*newsockp = newsock; *newsockp = newsock;
return 0; return 0;
failed: failed:
sock_release(newsock); sock_release(newsock);
return rc; return rc;
} }
EXPORT_SYMBOL(lnet_sock_accept); EXPORT_SYMBOL(lnet_sock_accept);
int int
lnet_sock_connect (struct socket **sockp, int *fatal, lnet_sock_connect(struct socket **sockp, int *fatal, __u32 local_ip,
__u32 local_ip, int local_port, int local_port, __u32 peer_ip, int peer_port)
__u32 peer_ip, int peer_port)
{ {
struct sockaddr_in srvaddr; struct sockaddr_in srvaddr;
int rc; int rc;
...@@ -590,7 +572,7 @@ lnet_sock_connect (struct socket **sockp, int *fatal, ...@@ -590,7 +572,7 @@ lnet_sock_connect (struct socket **sockp, int *fatal,
if (rc != 0) if (rc != 0)
return rc; return rc;
memset (&srvaddr, 0, sizeof (srvaddr)); memset(&srvaddr, 0, sizeof(srvaddr));
srvaddr.sin_family = AF_INET; srvaddr.sin_family = AF_INET;
srvaddr.sin_port = htons(peer_port); srvaddr.sin_port = htons(peer_port);
srvaddr.sin_addr.s_addr = htonl(peer_ip); srvaddr.sin_addr.s_addr = htonl(peer_ip);
...@@ -613,5 +595,4 @@ lnet_sock_connect (struct socket **sockp, int *fatal, ...@@ -613,5 +595,4 @@ lnet_sock_connect (struct socket **sockp, int *fatal,
sock_release(*sockp); sock_release(*sockp);
return rc; return rc;
} }
EXPORT_SYMBOL(lnet_sock_connect); EXPORT_SYMBOL(lnet_sock_connect);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment