Commit 73aea4ec authored by Neil Brown's avatar Neil Brown Committed by Linus Torvalds

[PATCH] nfsd4: fix setclientid unlock of unlocked state lock

We could try to unlock the state lock here without having first locked it.
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: default avatarNeil Brown <neilb@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent b59e3c0e
...@@ -678,13 +678,12 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_setclientid *setclid) ...@@ -678,13 +678,12 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_setclientid *setclid)
int status; int status;
char dname[HEXDIR_LEN]; char dname[HEXDIR_LEN];
status = nfserr_inval;
if (!check_name(clname)) if (!check_name(clname))
goto out; return nfserr_inval;
status = nfs4_make_rec_clidname(dname, &clname); status = nfs4_make_rec_clidname(dname, &clname);
if (status) if (status)
goto out; return status;
/* /*
* XXX The Duplicate Request Cache (DRC) has been checked (??) * XXX The Duplicate Request Cache (DRC) has been checked (??)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment