Commit 73f03c2b authored by Seth Forshee's avatar Seth Forshee Committed by Miklos Szeredi

fuse: Restrict allow_other to the superblock's namespace or a descendant

Unprivileged users are normally restricted from mounting with the
allow_other option by system policy, but this could be bypassed for a mount
done with user namespace root permissions. In such cases allow_other should
not allow users outside the userns to access the mount as doing so would
give the unprivileged user the ability to manipulate processes it would
otherwise be unable to manipulate. Restrict allow_other to apply to users
in the same userns used at mount or a descendant of that namespace. Also
export current_in_userns() for use by fuse when built as a module.
Reviewed-by: default avatarSerge Hallyn <serge@hallyn.com>
Signed-off-by: default avatarSeth Forshee <seth.forshee@canonical.com>
Signed-off-by: default avatarDongsu Park <dongsu@kinvolk.io>
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 8cb08329
...@@ -1030,7 +1030,7 @@ int fuse_allow_current_process(struct fuse_conn *fc) ...@@ -1030,7 +1030,7 @@ int fuse_allow_current_process(struct fuse_conn *fc)
const struct cred *cred; const struct cred *cred;
if (fc->allow_other) if (fc->allow_other)
return 1; return current_in_userns(fc->user_ns);
cred = current_cred(); cred = current_cred();
if (uid_eq(cred->euid, fc->user_id) && if (uid_eq(cred->euid, fc->user_id) &&
......
...@@ -1235,6 +1235,7 @@ bool current_in_userns(const struct user_namespace *target_ns) ...@@ -1235,6 +1235,7 @@ bool current_in_userns(const struct user_namespace *target_ns)
{ {
return in_userns(target_ns, current_user_ns()); return in_userns(target_ns, current_user_ns());
} }
EXPORT_SYMBOL(current_in_userns);
static inline struct user_namespace *to_user_ns(struct ns_common *ns) static inline struct user_namespace *to_user_ns(struct ns_common *ns)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment