Commit 754b404d authored by Dengcheng Zhu's avatar Dengcheng Zhu Committed by Greg Kroah-Hartman

MIPS: kexec: Mark CPU offline before disabling local IRQ

[ Upstream commit dc57aaf9 ]

After changing CPU online status, it will not be sent any IPIs such as in
__flush_cache_all() on software coherency systems. Do this before disabling
local IRQ.
Signed-off-by: default avatarDengcheng Zhu <dzhu@wavecomp.com>
Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
Patchwork: https://patchwork.linux-mips.org/patch/20571/
Cc: pburton@wavecomp.com
Cc: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org
Cc: rachel.mozes@intel.com
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e066306b
...@@ -36,6 +36,9 @@ static void crash_shutdown_secondary(void *passed_regs) ...@@ -36,6 +36,9 @@ static void crash_shutdown_secondary(void *passed_regs)
if (!cpu_online(cpu)) if (!cpu_online(cpu))
return; return;
/* We won't be sent IPIs any more. */
set_cpu_online(cpu, false);
local_irq_disable(); local_irq_disable();
if (!cpumask_test_cpu(cpu, &cpus_in_crash)) if (!cpumask_test_cpu(cpu, &cpus_in_crash))
crash_save_cpu(regs, cpu); crash_save_cpu(regs, cpu);
......
...@@ -118,6 +118,9 @@ machine_kexec(struct kimage *image) ...@@ -118,6 +118,9 @@ machine_kexec(struct kimage *image)
*ptr = (unsigned long) phys_to_virt(*ptr); *ptr = (unsigned long) phys_to_virt(*ptr);
} }
/* Mark offline BEFORE disabling local irq. */
set_cpu_online(smp_processor_id(), false);
/* /*
* we do not want to be bothered. * we do not want to be bothered.
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment