Commit 754c3cd7 authored by Johan Hovold's avatar Johan Hovold Committed by Ben Hutchings

uwb: fix device reference leaks

commit d6124b40 upstream.

This subsystem consistently fails to drop the device reference taken by
class_find_device().

Note that some of these lookup functions already take a reference to the
returned data, while others claim no reference is needed (or does not
seem need one).

Fixes: 183b9b59 ("uwb: add the UWB stack (core files)")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 60811cdb
...@@ -56,8 +56,11 @@ static struct uwb_rc *uwb_rc_find_by_index(int index) ...@@ -56,8 +56,11 @@ static struct uwb_rc *uwb_rc_find_by_index(int index)
struct uwb_rc *rc = NULL; struct uwb_rc *rc = NULL;
dev = class_find_device(&uwb_rc_class, NULL, &index, uwb_rc_index_match); dev = class_find_device(&uwb_rc_class, NULL, &index, uwb_rc_index_match);
if (dev) if (dev) {
rc = dev_get_drvdata(dev); rc = dev_get_drvdata(dev);
put_device(dev);
}
return rc; return rc;
} }
...@@ -368,7 +371,9 @@ struct uwb_rc *__uwb_rc_try_get(struct uwb_rc *target_rc) ...@@ -368,7 +371,9 @@ struct uwb_rc *__uwb_rc_try_get(struct uwb_rc *target_rc)
if (dev) { if (dev) {
rc = dev_get_drvdata(dev); rc = dev_get_drvdata(dev);
__uwb_rc_get(rc); __uwb_rc_get(rc);
put_device(dev);
} }
return rc; return rc;
} }
EXPORT_SYMBOL_GPL(__uwb_rc_try_get); EXPORT_SYMBOL_GPL(__uwb_rc_try_get);
...@@ -421,8 +426,11 @@ struct uwb_rc *uwb_rc_get_by_grandpa(const struct device *grandpa_dev) ...@@ -421,8 +426,11 @@ struct uwb_rc *uwb_rc_get_by_grandpa(const struct device *grandpa_dev)
dev = class_find_device(&uwb_rc_class, NULL, grandpa_dev, dev = class_find_device(&uwb_rc_class, NULL, grandpa_dev,
find_rc_grandpa); find_rc_grandpa);
if (dev) if (dev) {
rc = dev_get_drvdata(dev); rc = dev_get_drvdata(dev);
put_device(dev);
}
return rc; return rc;
} }
EXPORT_SYMBOL_GPL(uwb_rc_get_by_grandpa); EXPORT_SYMBOL_GPL(uwb_rc_get_by_grandpa);
...@@ -454,8 +462,10 @@ struct uwb_rc *uwb_rc_get_by_dev(const struct uwb_dev_addr *addr) ...@@ -454,8 +462,10 @@ struct uwb_rc *uwb_rc_get_by_dev(const struct uwb_dev_addr *addr)
struct uwb_rc *rc = NULL; struct uwb_rc *rc = NULL;
dev = class_find_device(&uwb_rc_class, NULL, addr, find_rc_dev); dev = class_find_device(&uwb_rc_class, NULL, addr, find_rc_dev);
if (dev) if (dev) {
rc = dev_get_drvdata(dev); rc = dev_get_drvdata(dev);
put_device(dev);
}
return rc; return rc;
} }
......
...@@ -97,6 +97,8 @@ static bool uwb_rc_class_device_exists(struct uwb_rc *target_rc) ...@@ -97,6 +97,8 @@ static bool uwb_rc_class_device_exists(struct uwb_rc *target_rc)
dev = class_find_device(&uwb_rc_class, NULL, target_rc, find_rc); dev = class_find_device(&uwb_rc_class, NULL, target_rc, find_rc);
put_device(dev);
return (dev != NULL); return (dev != NULL);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment