Commit 778037e1 authored by James Hogan's avatar James Hogan Committed by Mike Turquette

clk: clk-divider: fix divisor > 255 bug

Commit 6d9252bd (clk: Add support for power of two type dividers)
merged in v3.6 added the _get_val function to convert a divisor value to
a register field value depending on the flags. However it used the type
u8 for the div field, causing divisors larger than 255 to be masked
and the resultant clock rate to be too high.

E.g. in my case an 11bit divider was supposed to divide 24.576 MHz down
to 32.768KHz. The divisor was correctly calculated as 750 (0x2ee). This
was masked to 238 (0xee) resulting in a frequency of 103.26KHz.
Signed-off-by: default avatarJames Hogan <james.hogan@imgtec.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMike Turquette <mturquette@linaro.org>
parent 497d2214
...@@ -87,7 +87,7 @@ static unsigned int _get_table_val(const struct clk_div_table *table, ...@@ -87,7 +87,7 @@ static unsigned int _get_table_val(const struct clk_div_table *table,
return 0; return 0;
} }
static unsigned int _get_val(struct clk_divider *divider, u8 div) static unsigned int _get_val(struct clk_divider *divider, unsigned int div)
{ {
if (divider->flags & CLK_DIVIDER_ONE_BASED) if (divider->flags & CLK_DIVIDER_ONE_BASED)
return div; return div;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment