Commit 789602e9 authored by Fabian Frederick's avatar Fabian Frederick Committed by Dave Kleikamp

fs/jfs/super.c: remove 0 assignment to static + code clean-up

-Static values are automatically initialized to NULL
-Coalesce format fragments
-Remove unnecessary {}
-Small typo fixes
-Fix lines > 80 characters
Signed-off-by: default avatarFabian Frederick <fabf@skynet.be>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarDave Kleikamp <dave.kleikamp@oracle.com>
parent bc4e6b28
...@@ -50,14 +50,14 @@ MODULE_DESCRIPTION("The Journaled Filesystem (JFS)"); ...@@ -50,14 +50,14 @@ MODULE_DESCRIPTION("The Journaled Filesystem (JFS)");
MODULE_AUTHOR("Steve Best/Dave Kleikamp/Barry Arndt, IBM"); MODULE_AUTHOR("Steve Best/Dave Kleikamp/Barry Arndt, IBM");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");
static struct kmem_cache * jfs_inode_cachep; static struct kmem_cache *jfs_inode_cachep;
static const struct super_operations jfs_super_operations; static const struct super_operations jfs_super_operations;
static const struct export_operations jfs_export_operations; static const struct export_operations jfs_export_operations;
static struct file_system_type jfs_fs_type; static struct file_system_type jfs_fs_type;
#define MAX_COMMIT_THREADS 64 #define MAX_COMMIT_THREADS 64
static int commit_threads = 0; static int commit_threads;
module_param(commit_threads, int, 0); module_param(commit_threads, int, 0);
MODULE_PARM_DESC(commit_threads, "Number of commit threads"); MODULE_PARM_DESC(commit_threads, "Number of commit threads");
...@@ -84,8 +84,7 @@ static void jfs_handle_error(struct super_block *sb) ...@@ -84,8 +84,7 @@ static void jfs_handle_error(struct super_block *sb)
panic("JFS (device %s): panic forced after error\n", panic("JFS (device %s): panic forced after error\n",
sb->s_id); sb->s_id);
else if (sbi->flag & JFS_ERR_REMOUNT_RO) { else if (sbi->flag & JFS_ERR_REMOUNT_RO) {
jfs_err("ERROR: (device %s): remounting filesystem " jfs_err("ERROR: (device %s): remounting filesystem as read-only\n",
"as read-only\n",
sb->s_id); sb->s_id);
sb->s_flags |= MS_RDONLY; sb->s_flags |= MS_RDONLY;
} }
...@@ -363,12 +362,10 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize, ...@@ -363,12 +362,10 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
* -> user has more control over the online trimming * -> user has more control over the online trimming
*/ */
sbi->minblks_trim = 64; sbi->minblks_trim = 64;
if (blk_queue_discard(q)) { if (blk_queue_discard(q))
*flag |= JFS_DISCARD; *flag |= JFS_DISCARD;
} else { else
pr_err("JFS: discard option " \ pr_err("JFS: discard option not supported on device\n");
"not supported on device\n");
}
break; break;
} }
...@@ -385,15 +382,14 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize, ...@@ -385,15 +382,14 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
sbi->minblks_trim = simple_strtoull( sbi->minblks_trim = simple_strtoull(
minblks_trim, &minblks_trim, 0); minblks_trim, &minblks_trim, 0);
} else { } else {
pr_err("JFS: discard option " \ pr_err("JFS: discard option not supported on device\n");
"not supported on device\n");
} }
break; break;
} }
default: default:
printk("jfs: Unrecognized mount option \"%s\" " printk("jfs: Unrecognized mount option \"%s\" or missing value\n",
" or missing value\n", p); p);
goto cleanup; goto cleanup;
} }
} }
...@@ -419,14 +415,12 @@ static int jfs_remount(struct super_block *sb, int *flags, char *data) ...@@ -419,14 +415,12 @@ static int jfs_remount(struct super_block *sb, int *flags, char *data)
int ret; int ret;
sync_filesystem(sb); sync_filesystem(sb);
if (!parse_options(data, sb, &newLVSize, &flag)) { if (!parse_options(data, sb, &newLVSize, &flag))
return -EINVAL; return -EINVAL;
}
if (newLVSize) { if (newLVSize) {
if (sb->s_flags & MS_RDONLY) { if (sb->s_flags & MS_RDONLY) {
pr_err("JFS: resize requires volume" \ pr_err("JFS: resize requires volume to be mounted read-write\n");
" to be mounted read-write\n");
return -EROFS; return -EROFS;
} }
rc = jfs_extendfs(sb, newLVSize, 0); rc = jfs_extendfs(sb, newLVSize, 0);
...@@ -452,9 +446,8 @@ static int jfs_remount(struct super_block *sb, int *flags, char *data) ...@@ -452,9 +446,8 @@ static int jfs_remount(struct super_block *sb, int *flags, char *data)
} }
if ((!(sb->s_flags & MS_RDONLY)) && (*flags & MS_RDONLY)) { if ((!(sb->s_flags & MS_RDONLY)) && (*flags & MS_RDONLY)) {
rc = dquot_suspend(sb, -1); rc = dquot_suspend(sb, -1);
if (rc < 0) { if (rc < 0)
return rc; return rc;
}
rc = jfs_umount_rw(sb); rc = jfs_umount_rw(sb);
JFS_SBI(sb)->flag = flag; JFS_SBI(sb)->flag = flag;
return rc; return rc;
...@@ -487,7 +480,7 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent) ...@@ -487,7 +480,7 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
if (!new_valid_dev(sb->s_bdev->bd_dev)) if (!new_valid_dev(sb->s_bdev->bd_dev))
return -EOVERFLOW; return -EOVERFLOW;
sbi = kzalloc(sizeof (struct jfs_sb_info), GFP_KERNEL); sbi = kzalloc(sizeof(struct jfs_sb_info), GFP_KERNEL);
if (!sbi) if (!sbi)
return -ENOMEM; return -ENOMEM;
...@@ -548,9 +541,8 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent) ...@@ -548,9 +541,8 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
rc = jfs_mount(sb); rc = jfs_mount(sb);
if (rc) { if (rc) {
if (!silent) { if (!silent)
jfs_err("jfs_mount failed w/return code = %d", rc); jfs_err("jfs_mount failed w/return code = %d", rc);
}
goto out_mount_failed; goto out_mount_failed;
} }
if (sb->s_flags & MS_RDONLY) if (sb->s_flags & MS_RDONLY)
...@@ -587,7 +579,8 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent) ...@@ -587,7 +579,8 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
* Page cache is indexed by long. * Page cache is indexed by long.
* I would use MAX_LFS_FILESIZE, but it's only half as big * I would use MAX_LFS_FILESIZE, but it's only half as big
*/ */
sb->s_maxbytes = min(((u64) PAGE_CACHE_SIZE << 32) - 1, (u64)sb->s_maxbytes); sb->s_maxbytes = min(((u64) PAGE_CACHE_SIZE << 32) - 1,
(u64)sb->s_maxbytes);
#endif #endif
sb->s_time_gran = 1; sb->s_time_gran = 1;
return 0; return 0;
...@@ -597,9 +590,8 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent) ...@@ -597,9 +590,8 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
out_no_rw: out_no_rw:
rc = jfs_umount(sb); rc = jfs_umount(sb);
if (rc) { if (rc)
jfs_err("jfs_umount failed with return code %d", rc); jfs_err("jfs_umount failed with return code %d", rc);
}
out_mount_failed: out_mount_failed:
filemap_write_and_wait(sbi->direct_inode->i_mapping); filemap_write_and_wait(sbi->direct_inode->i_mapping);
truncate_inode_pages(sbi->direct_inode->i_mapping, 0); truncate_inode_pages(sbi->direct_inode->i_mapping, 0);
...@@ -924,7 +916,8 @@ static int __init init_jfs_fs(void) ...@@ -924,7 +916,8 @@ static int __init init_jfs_fs(void)
commit_threads = MAX_COMMIT_THREADS; commit_threads = MAX_COMMIT_THREADS;
for (i = 0; i < commit_threads; i++) { for (i = 0; i < commit_threads; i++) {
jfsCommitThread[i] = kthread_run(jfs_lazycommit, NULL, "jfsCommit"); jfsCommitThread[i] = kthread_run(jfs_lazycommit, NULL,
"jfsCommit");
if (IS_ERR(jfsCommitThread[i])) { if (IS_ERR(jfsCommitThread[i])) {
rc = PTR_ERR(jfsCommitThread[i]); rc = PTR_ERR(jfsCommitThread[i]);
jfs_err("init_jfs_fs: fork failed w/rc = %d", rc); jfs_err("init_jfs_fs: fork failed w/rc = %d", rc);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment