Commit 7c40b22f authored by Dan Carpenter's avatar Dan Carpenter Committed by Ilya Dryomov

libceph: potential NULL dereference in ceph_msg_data_create()

If kmem_cache_zalloc() returns NULL then the INIT_LIST_HEAD(&data->links);
will Oops.  The callers aren't really prepared for NULL returns so it
doesn't make a lot of difference in real life.

Fixes: 5240d9f9 ("libceph: replace message data pointer with list")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent 84583cfb
...@@ -3203,7 +3203,9 @@ static struct ceph_msg_data *ceph_msg_data_create(enum ceph_msg_data_type type) ...@@ -3203,7 +3203,9 @@ static struct ceph_msg_data *ceph_msg_data_create(enum ceph_msg_data_type type)
return NULL; return NULL;
data = kmem_cache_zalloc(ceph_msg_data_cache, GFP_NOFS); data = kmem_cache_zalloc(ceph_msg_data_cache, GFP_NOFS);
if (data) if (!data)
return NULL;
data->type = type; data->type = type;
INIT_LIST_HEAD(&data->links); INIT_LIST_HEAD(&data->links);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment