Commit 7ef2e813 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo

tools lib traceevent: Get rid of die() in pevent_filter_clear_trivial()

Change the function signature to return error code and not call die()
anymore.
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Reviewed-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1386567251-22751-13-git-send-email-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 28942c87
...@@ -860,7 +860,7 @@ int pevent_event_filtered(struct event_filter *filter, ...@@ -860,7 +860,7 @@ int pevent_event_filtered(struct event_filter *filter,
void pevent_filter_reset(struct event_filter *filter); void pevent_filter_reset(struct event_filter *filter);
void pevent_filter_clear_trivial(struct event_filter *filter, int pevent_filter_clear_trivial(struct event_filter *filter,
enum filter_trivial_type type); enum filter_trivial_type type);
void pevent_filter_free(struct event_filter *filter); void pevent_filter_free(struct event_filter *filter);
......
...@@ -1504,8 +1504,10 @@ int pevent_update_trivial(struct event_filter *dest, struct event_filter *source ...@@ -1504,8 +1504,10 @@ int pevent_update_trivial(struct event_filter *dest, struct event_filter *source
* @type: remove only true, false, or both * @type: remove only true, false, or both
* *
* Removes filters that only contain a TRUE or FALES boolean arg. * Removes filters that only contain a TRUE or FALES boolean arg.
*
* Returns 0 on success and -1 if there was a problem.
*/ */
void pevent_filter_clear_trivial(struct event_filter *filter, int pevent_filter_clear_trivial(struct event_filter *filter,
enum filter_trivial_type type) enum filter_trivial_type type)
{ {
struct filter_type *filter_type; struct filter_type *filter_type;
...@@ -1514,13 +1516,15 @@ void pevent_filter_clear_trivial(struct event_filter *filter, ...@@ -1514,13 +1516,15 @@ void pevent_filter_clear_trivial(struct event_filter *filter,
int i; int i;
if (!filter->filters) if (!filter->filters)
return; return 0;
/* /*
* Two steps, first get all ids with trivial filters. * Two steps, first get all ids with trivial filters.
* then remove those ids. * then remove those ids.
*/ */
for (i = 0; i < filter->filters; i++) { for (i = 0; i < filter->filters; i++) {
int *new_ids;
filter_type = &filter->event_filters[i]; filter_type = &filter->event_filters[i];
if (filter_type->filter->type != FILTER_ARG_BOOLEAN) if (filter_type->filter->type != FILTER_ARG_BOOLEAN)
continue; continue;
...@@ -1535,19 +1539,24 @@ void pevent_filter_clear_trivial(struct event_filter *filter, ...@@ -1535,19 +1539,24 @@ void pevent_filter_clear_trivial(struct event_filter *filter,
break; break;
} }
ids = realloc(ids, sizeof(*ids) * (count + 1)); new_ids = realloc(ids, sizeof(*ids) * (count + 1));
if (!ids) if (!new_ids) {
die("Can't allocate ids"); free(ids);
return -1;
}
ids = new_ids;
ids[count++] = filter_type->event_id; ids[count++] = filter_type->event_id;
} }
if (!count) if (!count)
return; return 0;
for (i = 0; i < count; i++) for (i = 0; i < count; i++)
pevent_filter_remove_event(filter, ids[i]); pevent_filter_remove_event(filter, ids[i]);
free(ids); free(ids);
return 0;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment