Commit 806efaed authored by Taeung Song's avatar Taeung Song Committed by Arnaldo Carvalho de Melo

tools lib traceevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

Currently the FILTER_TRIVIAL_FALSE case has a missing break statement,
if the trivial type is FALSE, it will also run into the TRUE case, and
always be skipped as the TRUE statement will continue the loop on the
inverse condition of the FALSE statement.
Reported-by: default avatarNamhyung Kim <namhyung@kernel.org>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Signed-off-by: default avatarTaeung Song <treeze.taeung@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20180112004823.012918807@goodmis.org
Link: http://lkml.kernel.org/r/1493218540-12296-1-git-send-email-treeze.taeung@gmail.comSigned-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 6d36ce26
...@@ -1631,6 +1631,7 @@ int pevent_filter_clear_trivial(struct event_filter *filter, ...@@ -1631,6 +1631,7 @@ int pevent_filter_clear_trivial(struct event_filter *filter,
case FILTER_TRIVIAL_FALSE: case FILTER_TRIVIAL_FALSE:
if (filter_type->filter->boolean.value) if (filter_type->filter->boolean.value)
continue; continue;
break;
case FILTER_TRIVIAL_TRUE: case FILTER_TRIVIAL_TRUE:
if (!filter_type->filter->boolean.value) if (!filter_type->filter->boolean.value)
continue; continue;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment