Commit 80d7d771 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: Drop unused name argument in snd_register_oss_device()

The last argument, name, of snd_oss_register_device() is nowhere
referred in the function in the current code.  Let's drop it.
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c4d14893
...@@ -249,8 +249,7 @@ int snd_add_device_sysfs_file(int type, struct snd_card *card, int dev, ...@@ -249,8 +249,7 @@ int snd_add_device_sysfs_file(int type, struct snd_card *card, int dev,
#ifdef CONFIG_SND_OSSEMUL #ifdef CONFIG_SND_OSSEMUL
int snd_register_oss_device(int type, struct snd_card *card, int dev, int snd_register_oss_device(int type, struct snd_card *card, int dev,
const struct file_operations *f_ops, void *private_data, const struct file_operations *f_ops, void *private_data);
const char *name);
int snd_unregister_oss_device(int type, struct snd_card *card, int dev); int snd_unregister_oss_device(int type, struct snd_card *card, int dev);
void *snd_lookup_oss_minor_data(unsigned int minor, int type); void *snd_lookup_oss_minor_data(unsigned int minor, int type);
#endif #endif
......
...@@ -60,7 +60,6 @@ struct snd_hwdep { ...@@ -60,7 +60,6 @@ struct snd_hwdep {
int iface; int iface;
#ifdef CONFIG_SND_OSSEMUL #ifdef CONFIG_SND_OSSEMUL
char oss_dev[32];
int oss_type; int oss_type;
int ossreg; int ossreg;
#endif #endif
......
...@@ -442,8 +442,7 @@ static int snd_hwdep_dev_register(struct snd_device *device) ...@@ -442,8 +442,7 @@ static int snd_hwdep_dev_register(struct snd_device *device)
} else { } else {
if (snd_register_oss_device(hwdep->oss_type, if (snd_register_oss_device(hwdep->oss_type,
hwdep->card, hwdep->device, hwdep->card, hwdep->device,
&snd_hwdep_f_ops, hwdep, &snd_hwdep_f_ops, hwdep) < 0) {
hwdep->oss_dev) < 0) {
snd_printk(KERN_ERR "unable to register OSS compatibility device %i:%i\n", snd_printk(KERN_ERR "unable to register OSS compatibility device %i:%i\n",
hwdep->card->number, hwdep->device); hwdep->card->number, hwdep->device);
} else } else
......
...@@ -1343,18 +1343,15 @@ static int snd_mixer_oss_notify_handler(struct snd_card *card, int cmd) ...@@ -1343,18 +1343,15 @@ static int snd_mixer_oss_notify_handler(struct snd_card *card, int cmd)
struct snd_mixer_oss *mixer; struct snd_mixer_oss *mixer;
if (cmd == SND_MIXER_OSS_NOTIFY_REGISTER) { if (cmd == SND_MIXER_OSS_NOTIFY_REGISTER) {
char name[128];
int idx, err; int idx, err;
mixer = kcalloc(2, sizeof(*mixer), GFP_KERNEL); mixer = kcalloc(2, sizeof(*mixer), GFP_KERNEL);
if (mixer == NULL) if (mixer == NULL)
return -ENOMEM; return -ENOMEM;
mutex_init(&mixer->reg_mutex); mutex_init(&mixer->reg_mutex);
sprintf(name, "mixer%i%i", card->number, 0);
if ((err = snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_MIXER, if ((err = snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_MIXER,
card, 0, card, 0,
&snd_mixer_oss_f_ops, card, &snd_mixer_oss_f_ops, card)) < 0) {
name)) < 0) {
snd_printk(KERN_ERR "unable to register OSS mixer device %i:%i\n", snd_printk(KERN_ERR "unable to register OSS mixer device %i:%i\n",
card->number, 0); card->number, 0);
kfree(mixer); kfree(mixer);
...@@ -1365,7 +1362,8 @@ static int snd_mixer_oss_notify_handler(struct snd_card *card, int cmd) ...@@ -1365,7 +1362,8 @@ static int snd_mixer_oss_notify_handler(struct snd_card *card, int cmd)
if (*card->mixername) if (*card->mixername)
strlcpy(mixer->name, card->mixername, sizeof(mixer->name)); strlcpy(mixer->name, card->mixername, sizeof(mixer->name));
else else
strlcpy(mixer->name, name, sizeof(mixer->name)); snprintf(mixer->name, sizeof(mixer->name),
"mixer%i", card->number);
#ifdef SNDRV_OSS_INFO_DEV_MIXERS #ifdef SNDRV_OSS_INFO_DEV_MIXERS
snd_oss_info_register(SNDRV_OSS_INFO_DEV_MIXERS, snd_oss_info_register(SNDRV_OSS_INFO_DEV_MIXERS,
card->number, card->number,
......
...@@ -3007,11 +3007,9 @@ static const struct file_operations snd_pcm_oss_f_reg = ...@@ -3007,11 +3007,9 @@ static const struct file_operations snd_pcm_oss_f_reg =
static void register_oss_dsp(struct snd_pcm *pcm, int index) static void register_oss_dsp(struct snd_pcm *pcm, int index)
{ {
char name[128];
sprintf(name, "dsp%i%i", pcm->card->number, pcm->device);
if (snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_PCM, if (snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_PCM,
pcm->card, index, &snd_pcm_oss_f_reg, pcm->card, index, &snd_pcm_oss_f_reg,
pcm, name) < 0) { pcm) < 0) {
snd_printk(KERN_ERR "unable to register OSS PCM device %i:%i\n", snd_printk(KERN_ERR "unable to register OSS PCM device %i:%i\n",
pcm->card->number, pcm->device); pcm->card->number, pcm->device);
} }
......
...@@ -1574,7 +1574,7 @@ static int snd_rawmidi_dev_register(struct snd_device *device) ...@@ -1574,7 +1574,7 @@ static int snd_rawmidi_dev_register(struct snd_device *device)
if ((int)rmidi->device == midi_map[rmidi->card->number]) { if ((int)rmidi->device == midi_map[rmidi->card->number]) {
if (snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_MIDI, if (snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_MIDI,
rmidi->card, 0, &snd_rawmidi_f_ops, rmidi->card, 0, &snd_rawmidi_f_ops,
rmidi, name) < 0) { rmidi) < 0) {
snd_printk(KERN_ERR "unable to register OSS rawmidi device %i:%i\n", rmidi->card->number, 0); snd_printk(KERN_ERR "unable to register OSS rawmidi device %i:%i\n", rmidi->card->number, 0);
} else { } else {
rmidi->ossreg++; rmidi->ossreg++;
...@@ -1586,7 +1586,7 @@ static int snd_rawmidi_dev_register(struct snd_device *device) ...@@ -1586,7 +1586,7 @@ static int snd_rawmidi_dev_register(struct snd_device *device)
if ((int)rmidi->device == amidi_map[rmidi->card->number]) { if ((int)rmidi->device == amidi_map[rmidi->card->number]) {
if (snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_MIDI, if (snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_MIDI,
rmidi->card, 1, &snd_rawmidi_f_ops, rmidi->card, 1, &snd_rawmidi_f_ops,
rmidi, name) < 0) { rmidi) < 0) {
snd_printk(KERN_ERR "unable to register OSS rawmidi device %i:%i\n", rmidi->card->number, 1); snd_printk(KERN_ERR "unable to register OSS rawmidi device %i:%i\n", rmidi->card->number, 1);
} else { } else {
rmidi->ossreg++; rmidi->ossreg++;
......
...@@ -231,16 +231,14 @@ register_device(void) ...@@ -231,16 +231,14 @@ register_device(void)
mutex_lock(&register_mutex); mutex_lock(&register_mutex);
if ((rc = snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_SEQUENCER, if ((rc = snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_SEQUENCER,
NULL, 0, NULL, 0,
&seq_oss_f_ops, NULL, &seq_oss_f_ops, NULL)) < 0) {
SNDRV_SEQ_OSS_DEVNAME)) < 0) {
snd_printk(KERN_ERR "can't register device seq\n"); snd_printk(KERN_ERR "can't register device seq\n");
mutex_unlock(&register_mutex); mutex_unlock(&register_mutex);
return rc; return rc;
} }
if ((rc = snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_MUSIC, if ((rc = snd_register_oss_device(SNDRV_OSS_DEVICE_TYPE_MUSIC,
NULL, 0, NULL, 0,
&seq_oss_f_ops, NULL, &seq_oss_f_ops, NULL)) < 0) {
SNDRV_SEQ_OSS_DEVNAME)) < 0) {
snd_printk(KERN_ERR "can't register device music\n"); snd_printk(KERN_ERR "can't register device music\n");
snd_unregister_oss_device(SNDRV_OSS_DEVICE_TYPE_SEQUENCER, NULL, 0); snd_unregister_oss_device(SNDRV_OSS_DEVICE_TYPE_SEQUENCER, NULL, 0);
mutex_unlock(&register_mutex); mutex_unlock(&register_mutex);
......
...@@ -46,7 +46,6 @@ ...@@ -46,7 +46,6 @@
#define SNDRV_SEQ_OSS_VERSION_STR "0.1.8" #define SNDRV_SEQ_OSS_VERSION_STR "0.1.8"
/* device and proc interface name */ /* device and proc interface name */
#define SNDRV_SEQ_OSS_DEVNAME "seq_oss"
#define SNDRV_SEQ_OSS_PROCNAME "oss" #define SNDRV_SEQ_OSS_PROCNAME "oss"
......
...@@ -105,8 +105,7 @@ static int snd_oss_kernel_minor(int type, struct snd_card *card, int dev) ...@@ -105,8 +105,7 @@ static int snd_oss_kernel_minor(int type, struct snd_card *card, int dev)
} }
int snd_register_oss_device(int type, struct snd_card *card, int dev, int snd_register_oss_device(int type, struct snd_card *card, int dev,
const struct file_operations *f_ops, void *private_data, const struct file_operations *f_ops, void *private_data)
const char *name)
{ {
int minor = snd_oss_kernel_minor(type, card, dev); int minor = snd_oss_kernel_minor(type, card, dev);
int minor_unit; int minor_unit;
......
...@@ -501,10 +501,8 @@ int snd_opl3_hwdep_new(struct snd_opl3 * opl3, ...@@ -501,10 +501,8 @@ int snd_opl3_hwdep_new(struct snd_opl3 * opl3,
hw->private_data = opl3; hw->private_data = opl3;
hw->exclusive = 1; hw->exclusive = 1;
#ifdef CONFIG_SND_OSSEMUL #ifdef CONFIG_SND_OSSEMUL
if (device == 0) { if (device == 0)
hw->oss_type = SNDRV_OSS_DEVICE_TYPE_DMFM; hw->oss_type = SNDRV_OSS_DEVICE_TYPE_DMFM;
sprintf(hw->oss_dev, "dmfm%i", card->number);
}
#endif #endif
strcpy(hw->name, hw->id); strcpy(hw->name, hw->id);
switch (opl3->hardware & OPL3_HW_MASK) { switch (opl3->hardware & OPL3_HW_MASK) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment