Commit 823c5c94 authored by Vitaly Kuznetsov's avatar Vitaly Kuznetsov Committed by Greg Kroah-Hartman

hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels()

commit abd1026d upstream.

"kernel BUG at drivers/hv/channel_mgmt.c:350!" is observed when hv_vmbus
module is unloaded. BUG_ON() was introduced in commit 85d9aa70
("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()") as
vmbus_free_channels() codepath was apparently forgotten.

Fixes: 85d9aa70 ("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()")
Signed-off-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 235394e1
...@@ -348,6 +348,7 @@ void vmbus_free_channels(void) ...@@ -348,6 +348,7 @@ void vmbus_free_channels(void)
{ {
struct vmbus_channel *channel, *tmp; struct vmbus_channel *channel, *tmp;
mutex_lock(&vmbus_connection.channel_mutex);
list_for_each_entry_safe(channel, tmp, &vmbus_connection.chn_list, list_for_each_entry_safe(channel, tmp, &vmbus_connection.chn_list,
listentry) { listentry) {
/* hv_process_channel_removal() needs this */ /* hv_process_channel_removal() needs this */
...@@ -355,6 +356,7 @@ void vmbus_free_channels(void) ...@@ -355,6 +356,7 @@ void vmbus_free_channels(void)
vmbus_device_unregister(channel->device_obj); vmbus_device_unregister(channel->device_obj);
} }
mutex_unlock(&vmbus_connection.channel_mutex);
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment