Commit 86e9466a authored by Rafael J. Wysocki's avatar Rafael J. Wysocki

intel_idle: Clean up irtl_2_usec()

Move the irtl_ns_units[] definition into irtl_2_usec() which is the
only user of it, use div_u64() for the division in there (as the
divisor is small enough) and use the NSEC_PER_USEC symbol for the
divisor.  Also convert the irtl_2_usec() comment to a proper
kerneldo one.

No intentional functional impact.
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 1aefbd7a
...@@ -1292,16 +1292,17 @@ static void __init ivt_idle_state_table_update(void) ...@@ -1292,16 +1292,17 @@ static void __init ivt_idle_state_table_update(void)
/* else, 1 and 2 socket systems use default ivt_cstates */ /* else, 1 and 2 socket systems use default ivt_cstates */
} }
/* /**
* Translate IRTL (Interrupt Response Time Limit) MSR to usec * irtl_2_usec - IRTL to microseconds conversion.
* @irtl: IRTL MSR value.
*
* Translate the IRTL (Interrupt Response Time Limit) MSR value to microseconds.
*/ */
static const unsigned int irtl_ns_units[] __initconst = {
1, 32, 1024, 32768, 1048576, 33554432, 0, 0
};
static unsigned long long __init irtl_2_usec(unsigned long long irtl) static unsigned long long __init irtl_2_usec(unsigned long long irtl)
{ {
static const unsigned int irtl_ns_units[] __initconst = {
1, 32, 1024, 32768, 1048576, 33554432, 0, 0
};
unsigned long long ns; unsigned long long ns;
if (!irtl) if (!irtl)
...@@ -1309,8 +1310,9 @@ static unsigned long long __init irtl_2_usec(unsigned long long irtl) ...@@ -1309,8 +1310,9 @@ static unsigned long long __init irtl_2_usec(unsigned long long irtl)
ns = irtl_ns_units[(irtl >> 10) & 0x7]; ns = irtl_ns_units[(irtl >> 10) & 0x7];
return div64_u64((irtl & 0x3FF) * ns, 1000); return div_u64((irtl & 0x3FF) * ns, NSEC_PER_USEC);
} }
/* /*
* bxt_idle_state_table_update(void) * bxt_idle_state_table_update(void)
* *
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment