Commit 88113957 authored by Kunihiko Hayashi's avatar Kunihiko Hayashi Committed by David S. Miller

net: ethernet: ave: Replace NET_IP_ALIGN with AVE_FRAME_HEADROOM

In commit 26a4676f ("arm64: mm: define NET_IP_ALIGN to 0"),
AVE controller affects this modification because the controller forces
to ignore lower 2bits of buffer start address, and make 2-byte headroom,
that is, data reception starts from (buffer + 2).

This patch defines AVE_FRAME_HEADROOM macro as hardware-specific value,
and replaces NET_IP_ALIGN with it.
Signed-off-by: default avatarKunihiko Hayashi <hayashi.kunihiko@socionext.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 09ee3b4a
...@@ -194,6 +194,7 @@ ...@@ -194,6 +194,7 @@
/* Parameter for ethernet frame */ /* Parameter for ethernet frame */
#define AVE_MAX_ETHFRAME 1518 #define AVE_MAX_ETHFRAME 1518
#define AVE_FRAME_HEADROOM 2
/* Parameter for interrupt */ /* Parameter for interrupt */
#define AVE_INTM_COUNT 20 #define AVE_INTM_COUNT 20
...@@ -576,12 +577,13 @@ static int ave_rxdesc_prepare(struct net_device *ndev, int entry) ...@@ -576,12 +577,13 @@ static int ave_rxdesc_prepare(struct net_device *ndev, int entry)
skb = priv->rx.desc[entry].skbs; skb = priv->rx.desc[entry].skbs;
if (!skb) { if (!skb) {
skb = netdev_alloc_skb_ip_align(ndev, skb = netdev_alloc_skb(ndev, AVE_MAX_ETHFRAME);
AVE_MAX_ETHFRAME);
if (!skb) { if (!skb) {
netdev_err(ndev, "can't allocate skb for Rx\n"); netdev_err(ndev, "can't allocate skb for Rx\n");
return -ENOMEM; return -ENOMEM;
} }
skb->data += AVE_FRAME_HEADROOM;
skb->tail += AVE_FRAME_HEADROOM;
} }
/* set disable to cmdsts */ /* set disable to cmdsts */
...@@ -594,12 +596,12 @@ static int ave_rxdesc_prepare(struct net_device *ndev, int entry) ...@@ -594,12 +596,12 @@ static int ave_rxdesc_prepare(struct net_device *ndev, int entry)
* - Rx buffer begins with 2 byte headroom, and data will be put from * - Rx buffer begins with 2 byte headroom, and data will be put from
* (buffer + 2). * (buffer + 2).
* To satisfy this, specify the address to put back the buffer * To satisfy this, specify the address to put back the buffer
* pointer advanced by NET_IP_ALIGN by netdev_alloc_skb_ip_align(), * pointer advanced by AVE_FRAME_HEADROOM, and expand the map size
* and expand the map size by NET_IP_ALIGN. * by AVE_FRAME_HEADROOM.
*/ */
ret = ave_dma_map(ndev, &priv->rx.desc[entry], ret = ave_dma_map(ndev, &priv->rx.desc[entry],
skb->data - NET_IP_ALIGN, skb->data - AVE_FRAME_HEADROOM,
AVE_MAX_ETHFRAME + NET_IP_ALIGN, AVE_MAX_ETHFRAME + AVE_FRAME_HEADROOM,
DMA_FROM_DEVICE, &paddr); DMA_FROM_DEVICE, &paddr);
if (ret) { if (ret) {
netdev_err(ndev, "can't map skb for Rx\n"); netdev_err(ndev, "can't map skb for Rx\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment