Commit 88ef4e3f authored by Dave Airlie's avatar Dave Airlie

Merge branch 'drm-intel-next' of git://people.freedesktop.org/~keithp/linux into drm-next

* 'drm-intel-next' of git://people.freedesktop.org/~keithp/linux:
  Drivers: i915: Fix all space related issues.
parents b2d108ba 0206e353
...@@ -227,7 +227,7 @@ static bool ch7017_init(struct intel_dvo_device *dvo, ...@@ -227,7 +227,7 @@ static bool ch7017_init(struct intel_dvo_device *dvo,
default: default:
DRM_DEBUG_KMS("ch701x not detected, got %d: from %s " DRM_DEBUG_KMS("ch701x not detected, got %d: from %s "
"slave %d.\n", "slave %d.\n",
val, adapter->name,dvo->slave_addr); val, adapter->name, dvo->slave_addr);
goto fail; goto fail;
} }
......
...@@ -111,7 +111,7 @@ static char *ch7xxx_get_id(uint8_t vid) ...@@ -111,7 +111,7 @@ static char *ch7xxx_get_id(uint8_t vid)
/** Reads an 8 bit register */ /** Reads an 8 bit register */
static bool ch7xxx_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch) static bool ch7xxx_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
{ {
struct ch7xxx_priv *ch7xxx= dvo->dev_priv; struct ch7xxx_priv *ch7xxx = dvo->dev_priv;
struct i2c_adapter *adapter = dvo->i2c_bus; struct i2c_adapter *adapter = dvo->i2c_bus;
u8 out_buf[2]; u8 out_buf[2];
u8 in_buf[2]; u8 in_buf[2];
...@@ -303,7 +303,7 @@ static void ch7xxx_dump_regs(struct intel_dvo_device *dvo) ...@@ -303,7 +303,7 @@ static void ch7xxx_dump_regs(struct intel_dvo_device *dvo)
for (i = 0; i < CH7xxx_NUM_REGS; i++) { for (i = 0; i < CH7xxx_NUM_REGS; i++) {
uint8_t val; uint8_t val;
if ((i % 8) == 0 ) if ((i % 8) == 0)
DRM_LOG_KMS("\n %02X: ", i); DRM_LOG_KMS("\n %02X: ", i);
ch7xxx_readb(dvo, i, &val); ch7xxx_readb(dvo, i, &val);
DRM_LOG_KMS("%02X ", val); DRM_LOG_KMS("%02X ", val);
......
...@@ -344,8 +344,8 @@ static void ivch_mode_set(struct intel_dvo_device *dvo, ...@@ -344,8 +344,8 @@ static void ivch_mode_set(struct intel_dvo_device *dvo,
(adjusted_mode->hdisplay - 1)) >> 2; (adjusted_mode->hdisplay - 1)) >> 2;
y_ratio = (((mode->vdisplay - 1) << 16) / y_ratio = (((mode->vdisplay - 1) << 16) /
(adjusted_mode->vdisplay - 1)) >> 2; (adjusted_mode->vdisplay - 1)) >> 2;
ivch_write (dvo, VR42, x_ratio); ivch_write(dvo, VR42, x_ratio);
ivch_write (dvo, VR41, y_ratio); ivch_write(dvo, VR41, y_ratio);
} else { } else {
vr01 &= ~VR01_PANEL_FIT_ENABLE; vr01 &= ~VR01_PANEL_FIT_ENABLE;
vr40 &= ~VR40_CLOCK_GATING_ENABLE; vr40 &= ~VR40_CLOCK_GATING_ENABLE;
...@@ -410,7 +410,7 @@ static void ivch_destroy(struct intel_dvo_device *dvo) ...@@ -410,7 +410,7 @@ static void ivch_destroy(struct intel_dvo_device *dvo)
} }
} }
struct intel_dvo_dev_ops ivch_ops= { struct intel_dvo_dev_ops ivch_ops = {
.init = ivch_init, .init = ivch_init,
.dpms = ivch_dpms, .dpms = ivch_dpms,
.mode_valid = ivch_mode_valid, .mode_valid = ivch_mode_valid,
......
...@@ -104,7 +104,7 @@ static bool sil164_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch) ...@@ -104,7 +104,7 @@ static bool sil164_readb(struct intel_dvo_device *dvo, int addr, uint8_t *ch)
static bool sil164_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch) static bool sil164_writeb(struct intel_dvo_device *dvo, int addr, uint8_t ch)
{ {
struct sil164_priv *sil= dvo->dev_priv; struct sil164_priv *sil = dvo->dev_priv;
struct i2c_adapter *adapter = dvo->i2c_bus; struct i2c_adapter *adapter = dvo->i2c_bus;
uint8_t out_buf[2]; uint8_t out_buf[2];
struct i2c_msg msg = { struct i2c_msg msg = {
......
...@@ -217,7 +217,7 @@ static int i915_gem_object_list_info(struct seq_file *m, void *data) ...@@ -217,7 +217,7 @@ static int i915_gem_object_list_info(struct seq_file *m, void *data)
++mappable_count; \ ++mappable_count; \
} \ } \
} \ } \
} while(0) } while (0)
static int i915_gem_object_info(struct seq_file *m, void* data) static int i915_gem_object_info(struct seq_file *m, void* data)
{ {
...@@ -1293,12 +1293,12 @@ i915_wedged_read(struct file *filp, ...@@ -1293,12 +1293,12 @@ i915_wedged_read(struct file *filp,
char buf[80]; char buf[80];
int len; int len;
len = snprintf(buf, sizeof (buf), len = snprintf(buf, sizeof(buf),
"wedged : %d\n", "wedged : %d\n",
atomic_read(&dev_priv->mm.wedged)); atomic_read(&dev_priv->mm.wedged));
if (len > sizeof (buf)) if (len > sizeof(buf))
len = sizeof (buf); len = sizeof(buf);
return simple_read_from_buffer(ubuf, max, ppos, buf, len); return simple_read_from_buffer(ubuf, max, ppos, buf, len);
} }
...@@ -1314,7 +1314,7 @@ i915_wedged_write(struct file *filp, ...@@ -1314,7 +1314,7 @@ i915_wedged_write(struct file *filp,
int val = 1; int val = 1;
if (cnt > 0) { if (cnt > 0) {
if (cnt > sizeof (buf) - 1) if (cnt > sizeof(buf) - 1)
return -EINVAL; return -EINVAL;
if (copy_from_user(buf, ubuf, cnt)) if (copy_from_user(buf, ubuf, cnt))
...@@ -1357,11 +1357,11 @@ i915_max_freq_read(struct file *filp, ...@@ -1357,11 +1357,11 @@ i915_max_freq_read(struct file *filp,
char buf[80]; char buf[80];
int len; int len;
len = snprintf(buf, sizeof (buf), len = snprintf(buf, sizeof(buf),
"max freq: %d\n", dev_priv->max_delay * 50); "max freq: %d\n", dev_priv->max_delay * 50);
if (len > sizeof (buf)) if (len > sizeof(buf))
len = sizeof (buf); len = sizeof(buf);
return simple_read_from_buffer(ubuf, max, ppos, buf, len); return simple_read_from_buffer(ubuf, max, ppos, buf, len);
} }
...@@ -1378,7 +1378,7 @@ i915_max_freq_write(struct file *filp, ...@@ -1378,7 +1378,7 @@ i915_max_freq_write(struct file *filp,
int val = 1; int val = 1;
if (cnt > 0) { if (cnt > 0) {
if (cnt > sizeof (buf) - 1) if (cnt > sizeof(buf) - 1)
return -EINVAL; return -EINVAL;
if (copy_from_user(buf, ubuf, cnt)) if (copy_from_user(buf, ubuf, cnt))
...@@ -1432,12 +1432,12 @@ i915_cache_sharing_read(struct file *filp, ...@@ -1432,12 +1432,12 @@ i915_cache_sharing_read(struct file *filp,
snpcr = I915_READ(GEN6_MBCUNIT_SNPCR); snpcr = I915_READ(GEN6_MBCUNIT_SNPCR);
mutex_unlock(&dev_priv->dev->struct_mutex); mutex_unlock(&dev_priv->dev->struct_mutex);
len = snprintf(buf, sizeof (buf), len = snprintf(buf, sizeof(buf),
"%d\n", (snpcr & GEN6_MBC_SNPCR_MASK) >> "%d\n", (snpcr & GEN6_MBC_SNPCR_MASK) >>
GEN6_MBC_SNPCR_SHIFT); GEN6_MBC_SNPCR_SHIFT);
if (len > sizeof (buf)) if (len > sizeof(buf))
len = sizeof (buf); len = sizeof(buf);
return simple_read_from_buffer(ubuf, max, ppos, buf, len); return simple_read_from_buffer(ubuf, max, ppos, buf, len);
} }
...@@ -1455,7 +1455,7 @@ i915_cache_sharing_write(struct file *filp, ...@@ -1455,7 +1455,7 @@ i915_cache_sharing_write(struct file *filp,
int val = 1; int val = 1;
if (cnt > 0) { if (cnt > 0) {
if (cnt > sizeof (buf) - 1) if (cnt > sizeof(buf) - 1)
return -EINVAL; return -EINVAL;
if (copy_from_user(buf, ubuf, cnt)) if (copy_from_user(buf, ubuf, cnt))
......
...@@ -884,7 +884,7 @@ static int i915_get_bridge_dev(struct drm_device *dev) ...@@ -884,7 +884,7 @@ static int i915_get_bridge_dev(struct drm_device *dev)
{ {
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
dev_priv->bridge_dev = pci_get_bus_and_slot(0, PCI_DEVFN(0,0)); dev_priv->bridge_dev = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
if (!dev_priv->bridge_dev) { if (!dev_priv->bridge_dev) {
DRM_ERROR("bridge device not found\n"); DRM_ERROR("bridge device not found\n");
return -1; return -1;
......
...@@ -294,7 +294,7 @@ MODULE_DEVICE_TABLE(pci, pciidlist); ...@@ -294,7 +294,7 @@ MODULE_DEVICE_TABLE(pci, pciidlist);
#define INTEL_PCH_CPT_DEVICE_ID_TYPE 0x1c00 #define INTEL_PCH_CPT_DEVICE_ID_TYPE 0x1c00
#define INTEL_PCH_PPT_DEVICE_ID_TYPE 0x1e00 #define INTEL_PCH_PPT_DEVICE_ID_TYPE 0x1e00
void intel_detect_pch (struct drm_device *dev) void intel_detect_pch(struct drm_device *dev)
{ {
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
struct pci_dev *pch; struct pci_dev *pch;
...@@ -377,7 +377,7 @@ void gen6_gt_force_wake_put(struct drm_i915_private *dev_priv) ...@@ -377,7 +377,7 @@ void gen6_gt_force_wake_put(struct drm_i915_private *dev_priv)
void __gen6_gt_wait_for_fifo(struct drm_i915_private *dev_priv) void __gen6_gt_wait_for_fifo(struct drm_i915_private *dev_priv)
{ {
if (dev_priv->gt_fifo_count < GT_FIFO_NUM_RESERVED_ENTRIES ) { if (dev_priv->gt_fifo_count < GT_FIFO_NUM_RESERVED_ENTRIES) {
int loop = 500; int loop = 500;
u32 fifo = I915_READ_NOTRACE(GT_FIFO_FREE_ENTRIES); u32 fifo = I915_READ_NOTRACE(GT_FIFO_FREE_ENTRIES);
while (fifo <= GT_FIFO_NUM_RESERVED_ENTRIES && loop--) { while (fifo <= GT_FIFO_NUM_RESERVED_ENTRIES && loop--) {
......
...@@ -226,26 +226,26 @@ struct drm_i915_display_funcs { ...@@ -226,26 +226,26 @@ struct drm_i915_display_funcs {
struct intel_device_info { struct intel_device_info {
u8 gen; u8 gen;
u8 is_mobile : 1; u8 is_mobile:1;
u8 is_i85x : 1; u8 is_i85x:1;
u8 is_i915g : 1; u8 is_i915g:1;
u8 is_i945gm : 1; u8 is_i945gm:1;
u8 is_g33 : 1; u8 is_g33:1;
u8 need_gfx_hws : 1; u8 need_gfx_hws:1;
u8 is_g4x : 1; u8 is_g4x:1;
u8 is_pineview : 1; u8 is_pineview:1;
u8 is_broadwater : 1; u8 is_broadwater:1;
u8 is_crestline : 1; u8 is_crestline:1;
u8 is_ivybridge : 1; u8 is_ivybridge:1;
u8 has_fbc : 1; u8 has_fbc:1;
u8 has_pipe_cxsr : 1; u8 has_pipe_cxsr:1;
u8 has_hotplug : 1; u8 has_hotplug:1;
u8 cursor_needs_physical : 1; u8 cursor_needs_physical:1;
u8 has_overlay : 1; u8 has_overlay:1;
u8 overlay_needs_physical : 1; u8 overlay_needs_physical:1;
u8 supports_tv : 1; u8 supports_tv:1;
u8 has_bsd_ring : 1; u8 has_bsd_ring:1;
u8 has_blt_ring : 1; u8 has_blt_ring:1;
}; };
enum no_fbc_reason { enum no_fbc_reason {
...@@ -759,19 +759,19 @@ struct drm_i915_gem_object { ...@@ -759,19 +759,19 @@ struct drm_i915_gem_object {
* (has pending rendering), and is not set if it's on inactive (ready * (has pending rendering), and is not set if it's on inactive (ready
* to be unbound). * to be unbound).
*/ */
unsigned int active : 1; unsigned int active:1;
/** /**
* This is set if the object has been written to since last bound * This is set if the object has been written to since last bound
* to the GTT * to the GTT
*/ */
unsigned int dirty : 1; unsigned int dirty:1;
/** /**
* This is set if the object has been written to since the last * This is set if the object has been written to since the last
* GPU flush. * GPU flush.
*/ */
unsigned int pending_gpu_write : 1; unsigned int pending_gpu_write:1;
/** /**
* Fence register bits (if any) for this object. Will be set * Fence register bits (if any) for this object. Will be set
...@@ -780,18 +780,18 @@ struct drm_i915_gem_object { ...@@ -780,18 +780,18 @@ struct drm_i915_gem_object {
* *
* Size: 4 bits for 16 fences + sign (for FENCE_REG_NONE) * Size: 4 bits for 16 fences + sign (for FENCE_REG_NONE)
*/ */
signed int fence_reg : 5; signed int fence_reg:5;
/** /**
* Advice: are the backing pages purgeable? * Advice: are the backing pages purgeable?
*/ */
unsigned int madv : 2; unsigned int madv:2;
/** /**
* Current tiling mode for the object. * Current tiling mode for the object.
*/ */
unsigned int tiling_mode : 2; unsigned int tiling_mode:2;
unsigned int tiling_changed : 1; unsigned int tiling_changed:1;
/** How many users have pinned this object in GTT space. The following /** How many users have pinned this object in GTT space. The following
* users can each hold at most one reference: pwrite/pread, pin_ioctl * users can each hold at most one reference: pwrite/pread, pin_ioctl
...@@ -802,22 +802,22 @@ struct drm_i915_gem_object { ...@@ -802,22 +802,22 @@ struct drm_i915_gem_object {
* *
* In the worst case this is 1 + 1 + 1 + 2*2 = 7. That would fit into 3 * In the worst case this is 1 + 1 + 1 + 2*2 = 7. That would fit into 3
* bits with absolutely no headroom. So use 4 bits. */ * bits with absolutely no headroom. So use 4 bits. */
unsigned int pin_count : 4; unsigned int pin_count:4;
#define DRM_I915_GEM_OBJECT_MAX_PIN_COUNT 0xf #define DRM_I915_GEM_OBJECT_MAX_PIN_COUNT 0xf
/** /**
* Is the object at the current location in the gtt mappable and * Is the object at the current location in the gtt mappable and
* fenceable? Used to avoid costly recalculations. * fenceable? Used to avoid costly recalculations.
*/ */
unsigned int map_and_fenceable : 1; unsigned int map_and_fenceable:1;
/** /**
* Whether the current gtt mapping needs to be mappable (and isn't just * Whether the current gtt mapping needs to be mappable (and isn't just
* mappable by accident). Track pin and fault separate for a more * mappable by accident). Track pin and fault separate for a more
* accurate mappable working set. * accurate mappable working set.
*/ */
unsigned int fault_mappable : 1; unsigned int fault_mappable:1;
unsigned int pin_mappable : 1; unsigned int pin_mappable:1;
/* /*
* Is the GPU currently using a fence to access this buffer, * Is the GPU currently using a fence to access this buffer,
...@@ -1056,7 +1056,7 @@ i915_enable_pipestat(drm_i915_private_t *dev_priv, int pipe, u32 mask); ...@@ -1056,7 +1056,7 @@ i915_enable_pipestat(drm_i915_private_t *dev_priv, int pipe, u32 mask);
void void
i915_disable_pipestat(drm_i915_private_t *dev_priv, int pipe, u32 mask); i915_disable_pipestat(drm_i915_private_t *dev_priv, int pipe, u32 mask);
void intel_enable_asle (struct drm_device *dev); void intel_enable_asle(struct drm_device *dev);
#ifdef CONFIG_DEBUG_FS #ifdef CONFIG_DEBUG_FS
extern void i915_destroy_error_state(struct drm_device *dev); extern void i915_destroy_error_state(struct drm_device *dev);
...@@ -1303,8 +1303,8 @@ extern void intel_disable_fbc(struct drm_device *dev); ...@@ -1303,8 +1303,8 @@ extern void intel_disable_fbc(struct drm_device *dev);
extern bool ironlake_set_drps(struct drm_device *dev, u8 val); extern bool ironlake_set_drps(struct drm_device *dev, u8 val);
extern void ironlake_enable_rc6(struct drm_device *dev); extern void ironlake_enable_rc6(struct drm_device *dev);
extern void gen6_set_rps(struct drm_device *dev, u8 val); extern void gen6_set_rps(struct drm_device *dev, u8 val);
extern void intel_detect_pch (struct drm_device *dev); extern void intel_detect_pch(struct drm_device *dev);
extern int intel_trans_dp_port_sel (struct drm_crtc *crtc); extern int intel_trans_dp_port_sel(struct drm_crtc *crtc);
/* overlay */ /* overlay */
#ifdef CONFIG_DEBUG_FS #ifdef CONFIG_DEBUG_FS
......
...@@ -179,7 +179,7 @@ i915_gem_get_aperture_ioctl(struct drm_device *dev, void *data, ...@@ -179,7 +179,7 @@ i915_gem_get_aperture_ioctl(struct drm_device *dev, void *data,
mutex_unlock(&dev->struct_mutex); mutex_unlock(&dev->struct_mutex);
args->aper_size = dev_priv->mm.gtt_total; args->aper_size = dev_priv->mm.gtt_total;
args->aper_available_size = args->aper_size -pinned; args->aper_available_size = args->aper_size - pinned;
return 0; return 0;
} }
...@@ -1775,7 +1775,7 @@ void i915_gem_reset(struct drm_device *dev) ...@@ -1775,7 +1775,7 @@ void i915_gem_reset(struct drm_device *dev)
* lost bo to the inactive list. * lost bo to the inactive list.
*/ */
while (!list_empty(&dev_priv->mm.flushing_list)) { while (!list_empty(&dev_priv->mm.flushing_list)) {
obj= list_first_entry(&dev_priv->mm.flushing_list, obj = list_first_entry(&dev_priv->mm.flushing_list,
struct drm_i915_gem_object, struct drm_i915_gem_object,
mm_list); mm_list);
...@@ -1841,7 +1841,7 @@ i915_gem_retire_requests_ring(struct intel_ring_buffer *ring) ...@@ -1841,7 +1841,7 @@ i915_gem_retire_requests_ring(struct intel_ring_buffer *ring)
while (!list_empty(&ring->active_list)) { while (!list_empty(&ring->active_list)) {
struct drm_i915_gem_object *obj; struct drm_i915_gem_object *obj;
obj= list_first_entry(&ring->active_list, obj = list_first_entry(&ring->active_list,
struct drm_i915_gem_object, struct drm_i915_gem_object,
ring_list); ring_list);
...@@ -2801,7 +2801,7 @@ i915_gem_object_bind_to_gtt(struct drm_i915_gem_object *obj, ...@@ -2801,7 +2801,7 @@ i915_gem_object_bind_to_gtt(struct drm_i915_gem_object *obj,
fenceable = fenceable =
obj->gtt_space->size == fence_size && obj->gtt_space->size == fence_size &&
(obj->gtt_space->start & (fence_alignment -1)) == 0; (obj->gtt_space->start & (fence_alignment - 1)) == 0;
mappable = mappable =
obj->gtt_offset + obj->base.size <= dev_priv->mm.gtt_mappable_end; obj->gtt_offset + obj->base.size <= dev_priv->mm.gtt_mappable_end;
...@@ -3517,7 +3517,7 @@ i915_gem_busy_ioctl(struct drm_device *dev, void *data, ...@@ -3517,7 +3517,7 @@ i915_gem_busy_ioctl(struct drm_device *dev, void *data,
*/ */
request = kzalloc(sizeof(*request), GFP_KERNEL); request = kzalloc(sizeof(*request), GFP_KERNEL);
if (request) if (request)
ret = i915_add_request(obj->ring, NULL,request); ret = i915_add_request(obj->ring, NULL, request);
else else
ret = -ENOMEM; ret = -ENOMEM;
} }
......
...@@ -72,7 +72,7 @@ i915_verify_lists(struct drm_device *dev) ...@@ -72,7 +72,7 @@ i915_verify_lists(struct drm_device *dev)
break; break;
} else if (!obj->active || } else if (!obj->active ||
(obj->base.write_domain & I915_GEM_GPU_DOMAINS) == 0 || (obj->base.write_domain & I915_GEM_GPU_DOMAINS) == 0 ||
list_empty(&obj->gpu_write_list)){ list_empty(&obj->gpu_write_list)) {
DRM_ERROR("invalid flushing %p (a %d w %x gwl %d)\n", DRM_ERROR("invalid flushing %p (a %d w %x gwl %d)\n",
obj, obj,
obj->active, obj->active,
......
...@@ -122,7 +122,7 @@ i915_gem_evict_something(struct drm_device *dev, int min_size, ...@@ -122,7 +122,7 @@ i915_gem_evict_something(struct drm_device *dev, int min_size,
goto found; goto found;
} }
list_for_each_entry(obj, &dev_priv->mm.active_list, mm_list) { list_for_each_entry(obj, &dev_priv->mm.active_list, mm_list) {
if (! obj->base.write_domain || obj->pin_count) if (!obj->base.write_domain || obj->pin_count)
continue; continue;
if (mark_free(obj, &unwind_list)) if (mark_free(obj, &unwind_list))
......
...@@ -711,7 +711,7 @@ i915_error_object_create(struct drm_i915_private *dev_priv, ...@@ -711,7 +711,7 @@ i915_error_object_create(struct drm_i915_private *dev_priv,
page_count = src->base.size / PAGE_SIZE; page_count = src->base.size / PAGE_SIZE;
dst = kmalloc(sizeof(*dst) + page_count * sizeof (u32 *), GFP_ATOMIC); dst = kmalloc(sizeof(*dst) + page_count * sizeof(u32 *), GFP_ATOMIC);
if (dst == NULL) if (dst == NULL)
return NULL; return NULL;
...@@ -1493,7 +1493,7 @@ static int ironlake_enable_vblank(struct drm_device *dev, int pipe) ...@@ -1493,7 +1493,7 @@ static int ironlake_enable_vblank(struct drm_device *dev, int pipe)
spin_lock_irqsave(&dev_priv->irq_lock, irqflags); spin_lock_irqsave(&dev_priv->irq_lock, irqflags);
ironlake_enable_display_irq(dev_priv, (pipe == 0) ? ironlake_enable_display_irq(dev_priv, (pipe == 0) ?
DE_PIPEA_VBLANK: DE_PIPEB_VBLANK); DE_PIPEA_VBLANK : DE_PIPEB_VBLANK);
spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags); spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags);
return 0; return 0;
...@@ -1541,7 +1541,7 @@ static void ironlake_disable_vblank(struct drm_device *dev, int pipe) ...@@ -1541,7 +1541,7 @@ static void ironlake_disable_vblank(struct drm_device *dev, int pipe)
spin_lock_irqsave(&dev_priv->irq_lock, irqflags); spin_lock_irqsave(&dev_priv->irq_lock, irqflags);
ironlake_disable_display_irq(dev_priv, (pipe == 0) ? ironlake_disable_display_irq(dev_priv, (pipe == 0) ?
DE_PIPEA_VBLANK: DE_PIPEB_VBLANK); DE_PIPEA_VBLANK : DE_PIPEB_VBLANK);
spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags); spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags);
} }
......
...@@ -202,7 +202,7 @@ static int init_heap(struct mem_block **heap, int start, int size) ...@@ -202,7 +202,7 @@ static int init_heap(struct mem_block **heap, int start, int size)
blocks->next = blocks->prev = *heap; blocks->next = blocks->prev = *heap;
memset(*heap, 0, sizeof(**heap)); memset(*heap, 0, sizeof(**heap));
(*heap)->file_priv = (struct drm_file *) - 1; (*heap)->file_priv = (struct drm_file *) -1;
(*heap)->next = (*heap)->prev = blocks; (*heap)->next = (*heap)->prev = blocks;
return 0; return 0;
} }
...@@ -359,19 +359,19 @@ int i915_mem_init_heap(struct drm_device *dev, void *data, ...@@ -359,19 +359,19 @@ int i915_mem_init_heap(struct drm_device *dev, void *data,
return init_heap(heap, initheap->start, initheap->size); return init_heap(heap, initheap->start, initheap->size);
} }
int i915_mem_destroy_heap( struct drm_device *dev, void *data, int i915_mem_destroy_heap(struct drm_device *dev, void *data,
struct drm_file *file_priv ) struct drm_file *file_priv)
{ {
drm_i915_private_t *dev_priv = dev->dev_private; drm_i915_private_t *dev_priv = dev->dev_private;
drm_i915_mem_destroy_heap_t *destroyheap = data; drm_i915_mem_destroy_heap_t *destroyheap = data;
struct mem_block **heap; struct mem_block **heap;
if ( !dev_priv ) { if (!dev_priv) {
DRM_ERROR( "called with no initialization\n" ); DRM_ERROR("called with no initialization\n");
return -EINVAL; return -EINVAL;
} }
heap = get_heap( dev_priv, destroyheap->region ); heap = get_heap(dev_priv, destroyheap->region);
if (!heap) { if (!heap) {
DRM_ERROR("get_heap failed"); DRM_ERROR("get_heap failed");
return -EFAULT; return -EFAULT;
...@@ -382,6 +382,6 @@ int i915_mem_destroy_heap( struct drm_device *dev, void *data, ...@@ -382,6 +382,6 @@ int i915_mem_destroy_heap( struct drm_device *dev, void *data,
return -EFAULT; return -EFAULT;
} }
i915_mem_takedown( heap ); i915_mem_takedown(heap);
return 0; return 0;
} }
...@@ -156,7 +156,7 @@ ...@@ -156,7 +156,7 @@
#define MI_SUSPEND_FLUSH MI_INSTR(0x0b, 0) #define MI_SUSPEND_FLUSH MI_INSTR(0x0b, 0)
#define MI_SUSPEND_FLUSH_EN (1<<0) #define MI_SUSPEND_FLUSH_EN (1<<0)
#define MI_REPORT_HEAD MI_INSTR(0x07, 0) #define MI_REPORT_HEAD MI_INSTR(0x07, 0)
#define MI_OVERLAY_FLIP MI_INSTR(0x11,0) #define MI_OVERLAY_FLIP MI_INSTR(0x11, 0)
#define MI_OVERLAY_CONTINUE (0x0<<21) #define MI_OVERLAY_CONTINUE (0x0<<21)
#define MI_OVERLAY_ON (0x1<<21) #define MI_OVERLAY_ON (0x1<<21)
#define MI_OVERLAY_OFF (0x2<<21) #define MI_OVERLAY_OFF (0x2<<21)
......
...@@ -60,7 +60,7 @@ static void i915_save_palette(struct drm_device *dev, enum pipe pipe) ...@@ -60,7 +60,7 @@ static void i915_save_palette(struct drm_device *dev, enum pipe pipe)
else else
array = dev_priv->save_palette_b; array = dev_priv->save_palette_b;
for(i = 0; i < 256; i++) for (i = 0; i < 256; i++)
array[i] = I915_READ(reg + (i << 2)); array[i] = I915_READ(reg + (i << 2));
} }
...@@ -82,7 +82,7 @@ static void i915_restore_palette(struct drm_device *dev, enum pipe pipe) ...@@ -82,7 +82,7 @@ static void i915_restore_palette(struct drm_device *dev, enum pipe pipe)
else else
array = dev_priv->save_palette_b; array = dev_priv->save_palette_b;
for(i = 0; i < 256; i++) for (i = 0; i < 256; i++)
I915_WRITE(reg + (i << 2), array[i]); I915_WRITE(reg + (i << 2), array[i]);
} }
...@@ -887,10 +887,10 @@ int i915_restore_state(struct drm_device *dev) ...@@ -887,10 +887,10 @@ int i915_restore_state(struct drm_device *dev)
mutex_lock(&dev->struct_mutex); mutex_lock(&dev->struct_mutex);
/* Cache mode state */ /* Cache mode state */
I915_WRITE (CACHE_MODE_0, dev_priv->saveCACHE_MODE_0 | 0xffff0000); I915_WRITE(CACHE_MODE_0, dev_priv->saveCACHE_MODE_0 | 0xffff0000);
/* Memory arbitration state */ /* Memory arbitration state */
I915_WRITE (MI_ARB_STATE, dev_priv->saveMI_ARB_STATE | 0xffff0000); I915_WRITE(MI_ARB_STATE, dev_priv->saveMI_ARB_STATE | 0xffff0000);
for (i = 0; i < 16; i++) { for (i = 0; i < 16; i++) {
I915_WRITE(SWF00 + (i << 2), dev_priv->saveSWF0[i]); I915_WRITE(SWF00 + (i << 2), dev_priv->saveSWF0[i]);
......
...@@ -64,7 +64,7 @@ static int intel_dsm(acpi_handle handle, int func, int arg) ...@@ -64,7 +64,7 @@ static int intel_dsm(acpi_handle handle, int func, int arg)
case ACPI_TYPE_BUFFER: case ACPI_TYPE_BUFFER:
if (obj->buffer.length == 4) { if (obj->buffer.length == 4) {
result =(obj->buffer.pointer[0] | result = (obj->buffer.pointer[0] |
(obj->buffer.pointer[1] << 8) | (obj->buffer.pointer[1] << 8) |
(obj->buffer.pointer[2] << 16) | (obj->buffer.pointer[2] << 16) |
(obj->buffer.pointer[3] << 24)); (obj->buffer.pointer[3] << 24));
......
...@@ -381,7 +381,7 @@ parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, ...@@ -381,7 +381,7 @@ parse_sdvo_device_mapping(struct drm_i915_private *dev_priv,
if (p_child->dvo_port != DEVICE_PORT_DVOB && if (p_child->dvo_port != DEVICE_PORT_DVOB &&
p_child->dvo_port != DEVICE_PORT_DVOC) { p_child->dvo_port != DEVICE_PORT_DVOC) {
/* skip the incorrect SDVO port */ /* skip the incorrect SDVO port */
DRM_DEBUG_KMS("Incorrect SDVO port. Skip it \n"); DRM_DEBUG_KMS("Incorrect SDVO port. Skip it\n");
continue; continue;
} }
DRM_DEBUG_KMS("the SDVO device with slave addr %2x is found on" DRM_DEBUG_KMS("the SDVO device with slave addr %2x is found on"
...@@ -564,7 +564,7 @@ parse_device_mapping(struct drm_i915_private *dev_priv, ...@@ -564,7 +564,7 @@ parse_device_mapping(struct drm_i915_private *dev_priv,
count++; count++;
} }
if (!count) { if (!count) {
DRM_DEBUG_KMS("no child dev is parsed from VBT \n"); DRM_DEBUG_KMS("no child dev is parsed from VBT\n");
return; return;
} }
dev_priv->child_dev = kzalloc(sizeof(*p_child) * count, GFP_KERNEL); dev_priv->child_dev = kzalloc(sizeof(*p_child) * count, GFP_KERNEL);
......
...@@ -69,7 +69,7 @@ static void intel_crt_dpms(struct drm_encoder *encoder, int mode) ...@@ -69,7 +69,7 @@ static void intel_crt_dpms(struct drm_encoder *encoder, int mode)
temp &= ~(ADPA_HSYNC_CNTL_DISABLE | ADPA_VSYNC_CNTL_DISABLE); temp &= ~(ADPA_HSYNC_CNTL_DISABLE | ADPA_VSYNC_CNTL_DISABLE);
temp &= ~ADPA_DAC_ENABLE; temp &= ~ADPA_DAC_ENABLE;
switch(mode) { switch (mode) {
case DRM_MODE_DPMS_ON: case DRM_MODE_DPMS_ON:
temp |= ADPA_DAC_ENABLE; temp |= ADPA_DAC_ENABLE;
break; break;
......
...@@ -42,7 +42,7 @@ ...@@ -42,7 +42,7 @@
#define HAS_eDP (intel_pipe_has_type(crtc, INTEL_OUTPUT_EDP)) #define HAS_eDP (intel_pipe_has_type(crtc, INTEL_OUTPUT_EDP))
bool intel_pipe_has_type (struct drm_crtc *crtc, int type); bool intel_pipe_has_type(struct drm_crtc *crtc, int type);
static void intel_update_watermarks(struct drm_device *dev); static void intel_update_watermarks(struct drm_device *dev);
static void intel_increase_pllclock(struct drm_crtc *crtc); static void intel_increase_pllclock(struct drm_crtc *crtc);
static void intel_crtc_update_cursor(struct drm_crtc *crtc, bool on); static void intel_crtc_update_cursor(struct drm_crtc *crtc, bool on);
...@@ -321,7 +321,7 @@ static const intel_limit_t intel_limits_ironlake_single_lvds_100m = { ...@@ -321,7 +321,7 @@ static const intel_limit_t intel_limits_ironlake_single_lvds_100m = {
.m1 = { .min = 12, .max = 22 }, .m1 = { .min = 12, .max = 22 },
.m2 = { .min = 5, .max = 9 }, .m2 = { .min = 5, .max = 9 },
.p = { .min = 28, .max = 112 }, .p = { .min = 28, .max = 112 },
.p1 = { .min = 2,.max = 8 }, .p1 = { .min = 2, .max = 8 },
.p2 = { .dot_limit = 225000, .p2 = { .dot_limit = 225000,
.p2_slow = 14, .p2_fast = 14 }, .p2_slow = 14, .p2_fast = 14 },
.find_pll = intel_g4x_find_best_PLL, .find_pll = intel_g4x_find_best_PLL,
...@@ -335,7 +335,7 @@ static const intel_limit_t intel_limits_ironlake_dual_lvds_100m = { ...@@ -335,7 +335,7 @@ static const intel_limit_t intel_limits_ironlake_dual_lvds_100m = {
.m1 = { .min = 12, .max = 22 }, .m1 = { .min = 12, .max = 22 },
.m2 = { .min = 5, .max = 9 }, .m2 = { .min = 5, .max = 9 },
.p = { .min = 14, .max = 42 }, .p = { .min = 14, .max = 42 },
.p1 = { .min = 2,.max = 6 }, .p1 = { .min = 2, .max = 6 },
.p2 = { .dot_limit = 225000, .p2 = { .dot_limit = 225000,
.p2_slow = 7, .p2_fast = 7 }, .p2_slow = 7, .p2_fast = 7 },
.find_pll = intel_g4x_find_best_PLL, .find_pll = intel_g4x_find_best_PLL,
...@@ -404,7 +404,7 @@ static const intel_limit_t *intel_g4x_limit(struct drm_crtc *crtc) ...@@ -404,7 +404,7 @@ static const intel_limit_t *intel_g4x_limit(struct drm_crtc *crtc)
limit = &intel_limits_g4x_hdmi; limit = &intel_limits_g4x_hdmi;
} else if (intel_pipe_has_type(crtc, INTEL_OUTPUT_SDVO)) { } else if (intel_pipe_has_type(crtc, INTEL_OUTPUT_SDVO)) {
limit = &intel_limits_g4x_sdvo; limit = &intel_limits_g4x_sdvo;
} else if (intel_pipe_has_type (crtc, INTEL_OUTPUT_DISPLAYPORT)) { } else if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) {
limit = &intel_limits_g4x_display_port; limit = &intel_limits_g4x_display_port;
} else /* The option is for other outputs */ } else /* The option is for other outputs */
limit = &intel_limits_i9xx_sdvo; limit = &intel_limits_i9xx_sdvo;
...@@ -488,26 +488,26 @@ static bool intel_PLL_is_valid(struct drm_device *dev, ...@@ -488,26 +488,26 @@ static bool intel_PLL_is_valid(struct drm_device *dev,
const intel_clock_t *clock) const intel_clock_t *clock)
{ {
if (clock->p1 < limit->p1.min || limit->p1.max < clock->p1) if (clock->p1 < limit->p1.min || limit->p1.max < clock->p1)
INTELPllInvalid ("p1 out of range\n"); INTELPllInvalid("p1 out of range\n");
if (clock->p < limit->p.min || limit->p.max < clock->p) if (clock->p < limit->p.min || limit->p.max < clock->p)
INTELPllInvalid ("p out of range\n"); INTELPllInvalid("p out of range\n");
if (clock->m2 < limit->m2.min || limit->m2.max < clock->m2) if (clock->m2 < limit->m2.min || limit->m2.max < clock->m2)
INTELPllInvalid ("m2 out of range\n"); INTELPllInvalid("m2 out of range\n");
if (clock->m1 < limit->m1.min || limit->m1.max < clock->m1) if (clock->m1 < limit->m1.min || limit->m1.max < clock->m1)
INTELPllInvalid ("m1 out of range\n"); INTELPllInvalid("m1 out of range\n");
if (clock->m1 <= clock->m2 && !IS_PINEVIEW(dev)) if (clock->m1 <= clock->m2 && !IS_PINEVIEW(dev))
INTELPllInvalid ("m1 <= m2\n"); INTELPllInvalid("m1 <= m2\n");
if (clock->m < limit->m.min || limit->m.max < clock->m) if (clock->m < limit->m.min || limit->m.max < clock->m)
INTELPllInvalid ("m out of range\n"); INTELPllInvalid("m out of range\n");
if (clock->n < limit->n.min || limit->n.max < clock->n) if (clock->n < limit->n.min || limit->n.max < clock->n)
INTELPllInvalid ("n out of range\n"); INTELPllInvalid("n out of range\n");
if (clock->vco < limit->vco.min || limit->vco.max < clock->vco) if (clock->vco < limit->vco.min || limit->vco.max < clock->vco)
INTELPllInvalid ("vco out of range\n"); INTELPllInvalid("vco out of range\n");
/* XXX: We may need to be checking "Dot clock" depending on the multiplier, /* XXX: We may need to be checking "Dot clock" depending on the multiplier,
* connector, etc., rather than just a single range. * connector, etc., rather than just a single range.
*/ */
if (clock->dot < limit->dot.min || limit->dot.max < clock->dot) if (clock->dot < limit->dot.min || limit->dot.max < clock->dot)
INTELPllInvalid ("dot out of range\n"); INTELPllInvalid("dot out of range\n");
return true; return true;
} }
...@@ -542,7 +542,7 @@ intel_find_best_PLL(const intel_limit_t *limit, struct drm_crtc *crtc, ...@@ -542,7 +542,7 @@ intel_find_best_PLL(const intel_limit_t *limit, struct drm_crtc *crtc,
clock.p2 = limit->p2.p2_fast; clock.p2 = limit->p2.p2_fast;
} }
memset (best_clock, 0, sizeof (*best_clock)); memset(best_clock, 0, sizeof(*best_clock));
for (clock.m1 = limit->m1.min; clock.m1 <= limit->m1.max; for (clock.m1 = limit->m1.min; clock.m1 <= limit->m1.max;
clock.m1++) { clock.m1++) {
...@@ -2432,7 +2432,7 @@ static void ironlake_fdi_link_train(struct drm_crtc *crtc) ...@@ -2432,7 +2432,7 @@ static void ironlake_fdi_link_train(struct drm_crtc *crtc)
} }
static const int snb_b_fdi_train_param [] = { static const int snb_b_fdi_train_param[] = {
FDI_LINK_TRAIN_400MV_0DB_SNB_B, FDI_LINK_TRAIN_400MV_0DB_SNB_B,
FDI_LINK_TRAIN_400MV_6DB_SNB_B, FDI_LINK_TRAIN_400MV_6DB_SNB_B,
FDI_LINK_TRAIN_600MV_3_5DB_SNB_B, FDI_LINK_TRAIN_600MV_3_5DB_SNB_B,
...@@ -2488,7 +2488,7 @@ static void gen6_fdi_link_train(struct drm_crtc *crtc) ...@@ -2488,7 +2488,7 @@ static void gen6_fdi_link_train(struct drm_crtc *crtc)
if (HAS_PCH_CPT(dev)) if (HAS_PCH_CPT(dev))
cpt_phase_pointer_enable(dev, pipe); cpt_phase_pointer_enable(dev, pipe);
for (i = 0; i < 4; i++ ) { for (i = 0; i < 4; i++) {
reg = FDI_TX_CTL(pipe); reg = FDI_TX_CTL(pipe);
temp = I915_READ(reg); temp = I915_READ(reg);
temp &= ~FDI_LINK_TRAIN_VOL_EMP_MASK; temp &= ~FDI_LINK_TRAIN_VOL_EMP_MASK;
...@@ -2537,7 +2537,7 @@ static void gen6_fdi_link_train(struct drm_crtc *crtc) ...@@ -2537,7 +2537,7 @@ static void gen6_fdi_link_train(struct drm_crtc *crtc)
POSTING_READ(reg); POSTING_READ(reg);
udelay(150); udelay(150);
for (i = 0; i < 4; i++ ) { for (i = 0; i < 4; i++) {
reg = FDI_TX_CTL(pipe); reg = FDI_TX_CTL(pipe);
temp = I915_READ(reg); temp = I915_READ(reg);
temp &= ~FDI_LINK_TRAIN_VOL_EMP_MASK; temp &= ~FDI_LINK_TRAIN_VOL_EMP_MASK;
...@@ -2607,7 +2607,7 @@ static void ivb_manual_fdi_link_train(struct drm_crtc *crtc) ...@@ -2607,7 +2607,7 @@ static void ivb_manual_fdi_link_train(struct drm_crtc *crtc)
if (HAS_PCH_CPT(dev)) if (HAS_PCH_CPT(dev))
cpt_phase_pointer_enable(dev, pipe); cpt_phase_pointer_enable(dev, pipe);
for (i = 0; i < 4; i++ ) { for (i = 0; i < 4; i++) {
reg = FDI_TX_CTL(pipe); reg = FDI_TX_CTL(pipe);
temp = I915_READ(reg); temp = I915_READ(reg);
temp &= ~FDI_LINK_TRAIN_VOL_EMP_MASK; temp &= ~FDI_LINK_TRAIN_VOL_EMP_MASK;
...@@ -2649,7 +2649,7 @@ static void ivb_manual_fdi_link_train(struct drm_crtc *crtc) ...@@ -2649,7 +2649,7 @@ static void ivb_manual_fdi_link_train(struct drm_crtc *crtc)
POSTING_READ(reg); POSTING_READ(reg);
udelay(150); udelay(150);
for (i = 0; i < 4; i++ ) { for (i = 0; i < 4; i++) {
reg = FDI_TX_CTL(pipe); reg = FDI_TX_CTL(pipe);
temp = I915_READ(reg); temp = I915_READ(reg);
temp &= ~FDI_LINK_TRAIN_VOL_EMP_MASK; temp &= ~FDI_LINK_TRAIN_VOL_EMP_MASK;
...@@ -3285,14 +3285,14 @@ static void ironlake_crtc_commit(struct drm_crtc *crtc) ...@@ -3285,14 +3285,14 @@ static void ironlake_crtc_commit(struct drm_crtc *crtc)
ironlake_crtc_enable(crtc); ironlake_crtc_enable(crtc);
} }
void intel_encoder_prepare (struct drm_encoder *encoder) void intel_encoder_prepare(struct drm_encoder *encoder)
{ {
struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private; struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private;
/* lvds has its own version of prepare see intel_lvds_prepare */ /* lvds has its own version of prepare see intel_lvds_prepare */
encoder_funcs->dpms(encoder, DRM_MODE_DPMS_OFF); encoder_funcs->dpms(encoder, DRM_MODE_DPMS_OFF);
} }
void intel_encoder_commit (struct drm_encoder *encoder) void intel_encoder_commit(struct drm_encoder *encoder)
{ {
struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private; struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private;
/* lvds has its own version of commit see intel_lvds_commit */ /* lvds has its own version of commit see intel_lvds_commit */
...@@ -8144,7 +8144,7 @@ static void intel_init_display(struct drm_device *dev) ...@@ -8144,7 +8144,7 @@ static void intel_init_display(struct drm_device *dev)
} }
/* Returns the core display clock speed */ /* Returns the core display clock speed */
if (IS_I945G(dev) || (IS_G33(dev) && ! IS_PINEVIEW_M(dev))) if (IS_I945G(dev) || (IS_G33(dev) && !IS_PINEVIEW_M(dev)))
dev_priv->display.get_display_clock_speed = dev_priv->display.get_display_clock_speed =
i945_get_display_clock_speed; i945_get_display_clock_speed;
else if (IS_I915G(dev)) else if (IS_I915G(dev))
...@@ -8215,7 +8215,7 @@ static void intel_init_display(struct drm_device *dev) ...@@ -8215,7 +8215,7 @@ static void intel_init_display(struct drm_device *dev)
DRM_INFO("failed to find known CxSR latency " DRM_INFO("failed to find known CxSR latency "
"(found ddr%s fsb freq %d, mem freq %d), " "(found ddr%s fsb freq %d, mem freq %d), "
"disabling CxSR\n", "disabling CxSR\n",
(dev_priv->is_ddr3 == 1) ? "3": "2", (dev_priv->is_ddr3 == 1) ? "3" : "2",
dev_priv->fsb_freq, dev_priv->mem_freq); dev_priv->fsb_freq, dev_priv->mem_freq);
/* Disable CxSR and never update its watermark again */ /* Disable CxSR and never update its watermark again */
pineview_disable_cxsr(dev); pineview_disable_cxsr(dev);
...@@ -8284,7 +8284,7 @@ static void intel_init_display(struct drm_device *dev) ...@@ -8284,7 +8284,7 @@ static void intel_init_display(struct drm_device *dev)
* resume, or other times. This quirk makes sure that's the case for * resume, or other times. This quirk makes sure that's the case for
* affected systems. * affected systems.
*/ */
static void quirk_pipea_force (struct drm_device *dev) static void quirk_pipea_force(struct drm_device *dev)
{ {
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
...@@ -8312,7 +8312,7 @@ struct intel_quirk intel_quirks[] = { ...@@ -8312,7 +8312,7 @@ struct intel_quirk intel_quirks[] = {
/* HP Compaq 2730p needs pipe A force quirk (LP: #291555) */ /* HP Compaq 2730p needs pipe A force quirk (LP: #291555) */
{ 0x2a42, 0x103c, 0x30eb, quirk_pipea_force }, { 0x2a42, 0x103c, 0x30eb, quirk_pipea_force },
/* HP Mini needs pipe A force quirk (LP: #322104) */ /* HP Mini needs pipe A force quirk (LP: #322104) */
{ 0x27ae,0x103c, 0x361a, quirk_pipea_force }, { 0x27ae, 0x103c, 0x361a, quirk_pipea_force },
/* Thinkpad R31 needs pipe A force quirk */ /* Thinkpad R31 needs pipe A force quirk */
{ 0x3577, 0x1014, 0x0505, quirk_pipea_force }, { 0x3577, 0x1014, 0x0505, quirk_pipea_force },
...@@ -8579,7 +8579,7 @@ intel_display_capture_error_state(struct drm_device *dev) ...@@ -8579,7 +8579,7 @@ intel_display_capture_error_state(struct drm_device *dev)
error->plane[i].control = I915_READ(DSPCNTR(i)); error->plane[i].control = I915_READ(DSPCNTR(i));
error->plane[i].stride = I915_READ(DSPSTRIDE(i)); error->plane[i].stride = I915_READ(DSPSTRIDE(i));
error->plane[i].size = I915_READ(DSPSIZE(i)); error->plane[i].size = I915_READ(DSPSIZE(i));
error->plane[i].pos= I915_READ(DSPPOS(i)); error->plane[i].pos = I915_READ(DSPPOS(i));
error->plane[i].addr = I915_READ(DSPADDR(i)); error->plane[i].addr = I915_READ(DSPADDR(i));
if (INTEL_INFO(dev)->gen >= 4) { if (INTEL_INFO(dev)->gen >= 4) {
error->plane[i].surface = I915_READ(DSPSURF(i)); error->plane[i].surface = I915_READ(DSPSURF(i));
......
...@@ -121,7 +121,7 @@ static void intel_dp_complete_link_train(struct intel_dp *intel_dp); ...@@ -121,7 +121,7 @@ static void intel_dp_complete_link_train(struct intel_dp *intel_dp);
static void intel_dp_link_down(struct intel_dp *intel_dp); static void intel_dp_link_down(struct intel_dp *intel_dp);
void void
intel_edp_link_config (struct intel_encoder *intel_encoder, intel_edp_link_config(struct intel_encoder *intel_encoder,
int *lane_num, int *link_bw) int *lane_num, int *link_bw)
{ {
struct intel_dp *intel_dp = container_of(intel_encoder, struct intel_dp, base); struct intel_dp *intel_dp = container_of(intel_encoder, struct intel_dp, base);
...@@ -582,10 +582,10 @@ intel_dp_i2c_init(struct intel_dp *intel_dp, ...@@ -582,10 +582,10 @@ intel_dp_i2c_init(struct intel_dp *intel_dp,
intel_dp->algo.address = 0; intel_dp->algo.address = 0;
intel_dp->algo.aux_ch = intel_dp_i2c_aux_ch; intel_dp->algo.aux_ch = intel_dp_i2c_aux_ch;
memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); memset(&intel_dp->adapter, '\0', sizeof(intel_dp->adapter));
intel_dp->adapter.owner = THIS_MODULE; intel_dp->adapter.owner = THIS_MODULE;
intel_dp->adapter.class = I2C_CLASS_DDC; intel_dp->adapter.class = I2C_CLASS_DDC;
strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); strncpy(intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1);
intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0';
intel_dp->adapter.algo_data = &intel_dp->algo; intel_dp->adapter.algo_data = &intel_dp->algo;
intel_dp->adapter.dev.parent = &intel_connector->base.kdev; intel_dp->adapter.dev.parent = &intel_connector->base.kdev;
...@@ -839,7 +839,7 @@ static void ironlake_edp_panel_vdd_off(struct intel_dp *intel_dp) ...@@ -839,7 +839,7 @@ static void ironlake_edp_panel_vdd_off(struct intel_dp *intel_dp)
} }
/* Returns true if the panel was already on when called */ /* Returns true if the panel was already on when called */
static bool ironlake_edp_panel_on (struct intel_dp *intel_dp) static bool ironlake_edp_panel_on(struct intel_dp *intel_dp)
{ {
struct drm_device *dev = intel_dp->base.base.dev; struct drm_device *dev = intel_dp->base.base.dev;
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
...@@ -871,7 +871,7 @@ static bool ironlake_edp_panel_on (struct intel_dp *intel_dp) ...@@ -871,7 +871,7 @@ static bool ironlake_edp_panel_on (struct intel_dp *intel_dp)
return false; return false;
} }
static void ironlake_edp_panel_off (struct drm_device *dev) static void ironlake_edp_panel_off(struct drm_device *dev)
{ {
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
u32 pp, idle_off_mask = PP_ON | PP_SEQUENCE_MASK | u32 pp, idle_off_mask = PP_ON | PP_SEQUENCE_MASK |
...@@ -897,7 +897,7 @@ static void ironlake_edp_panel_off (struct drm_device *dev) ...@@ -897,7 +897,7 @@ static void ironlake_edp_panel_off (struct drm_device *dev)
POSTING_READ(PCH_PP_CONTROL); POSTING_READ(PCH_PP_CONTROL);
} }
static void ironlake_edp_backlight_on (struct drm_device *dev) static void ironlake_edp_backlight_on(struct drm_device *dev)
{ {
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
u32 pp; u32 pp;
...@@ -915,7 +915,7 @@ static void ironlake_edp_backlight_on (struct drm_device *dev) ...@@ -915,7 +915,7 @@ static void ironlake_edp_backlight_on (struct drm_device *dev)
I915_WRITE(PCH_PP_CONTROL, pp); I915_WRITE(PCH_PP_CONTROL, pp);
} }
static void ironlake_edp_backlight_off (struct drm_device *dev) static void ironlake_edp_backlight_off(struct drm_device *dev)
{ {
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
u32 pp; u32 pp;
...@@ -1584,7 +1584,7 @@ static bool ...@@ -1584,7 +1584,7 @@ static bool
intel_dp_get_dpcd(struct intel_dp *intel_dp) intel_dp_get_dpcd(struct intel_dp *intel_dp)
{ {
if (intel_dp_aux_native_read_retry(intel_dp, 0x000, intel_dp->dpcd, if (intel_dp_aux_native_read_retry(intel_dp, 0x000, intel_dp->dpcd,
sizeof (intel_dp->dpcd)) && sizeof(intel_dp->dpcd)) &&
(intel_dp->dpcd[DP_DPCD_REV] != 0)) { (intel_dp->dpcd[DP_DPCD_REV] != 0)) {
return true; return true;
} }
...@@ -1839,7 +1839,7 @@ intel_dp_set_property(struct drm_connector *connector, ...@@ -1839,7 +1839,7 @@ intel_dp_set_property(struct drm_connector *connector,
} }
static void static void
intel_dp_destroy (struct drm_connector *connector) intel_dp_destroy(struct drm_connector *connector)
{ {
struct drm_device *dev = connector->dev; struct drm_device *dev = connector->dev;
...@@ -1896,7 +1896,7 @@ intel_dp_hot_plug(struct intel_encoder *intel_encoder) ...@@ -1896,7 +1896,7 @@ intel_dp_hot_plug(struct intel_encoder *intel_encoder)
/* Return which DP Port should be selected for Transcoder DP control */ /* Return which DP Port should be selected for Transcoder DP control */
int int
intel_trans_dp_port_sel (struct drm_crtc *crtc) intel_trans_dp_port_sel(struct drm_crtc *crtc)
{ {
struct drm_device *dev = crtc->dev; struct drm_device *dev = crtc->dev;
struct drm_mode_config *mode_config = &dev->mode_config; struct drm_mode_config *mode_config = &dev->mode_config;
......
...@@ -34,7 +34,7 @@ ...@@ -34,7 +34,7 @@
#define _wait_for(COND, MS, W) ({ \ #define _wait_for(COND, MS, W) ({ \
unsigned long timeout__ = jiffies + msecs_to_jiffies(MS); \ unsigned long timeout__ = jiffies + msecs_to_jiffies(MS); \
int ret__ = 0; \ int ret__ = 0; \
while (! (COND)) { \ while (!(COND)) { \
if (time_after(jiffies, timeout__)) { \ if (time_after(jiffies, timeout__)) { \
ret__ = -ETIMEDOUT; \ ret__ = -ETIMEDOUT; \
break; \ break; \
...@@ -52,7 +52,7 @@ ...@@ -52,7 +52,7 @@
mdelay(x); \ mdelay(x); \
else \ else \
msleep(x); \ msleep(x); \
} while(0) } while (0)
#define KHz(x) (1000*x) #define KHz(x) (1000*x)
#define MHz(x) KHz(1000*x) #define MHz(x) KHz(1000*x)
...@@ -284,7 +284,7 @@ void ...@@ -284,7 +284,7 @@ void
intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode, intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode); struct drm_display_mode *adjusted_mode);
extern bool intel_dpd_is_edp(struct drm_device *dev); extern bool intel_dpd_is_edp(struct drm_device *dev);
extern void intel_edp_link_config (struct intel_encoder *, int *, int *); extern void intel_edp_link_config(struct intel_encoder *, int *, int *);
extern bool intel_encoder_is_pch_edp(struct drm_encoder *encoder); extern bool intel_encoder_is_pch_edp(struct drm_encoder *encoder);
/* intel_panel.c */ /* intel_panel.c */
...@@ -304,8 +304,8 @@ extern void intel_panel_destroy_backlight(struct drm_device *dev); ...@@ -304,8 +304,8 @@ extern void intel_panel_destroy_backlight(struct drm_device *dev);
extern enum drm_connector_status intel_panel_detect(struct drm_device *dev); extern enum drm_connector_status intel_panel_detect(struct drm_device *dev);
extern void intel_crtc_load_lut(struct drm_crtc *crtc); extern void intel_crtc_load_lut(struct drm_crtc *crtc);
extern void intel_encoder_prepare (struct drm_encoder *encoder); extern void intel_encoder_prepare(struct drm_encoder *encoder);
extern void intel_encoder_commit (struct drm_encoder *encoder); extern void intel_encoder_commit(struct drm_encoder *encoder);
extern void intel_encoder_destroy(struct drm_encoder *encoder); extern void intel_encoder_destroy(struct drm_encoder *encoder);
static inline struct intel_encoder *intel_attached_encoder(struct drm_connector *connector) static inline struct intel_encoder *intel_attached_encoder(struct drm_connector *connector)
......
...@@ -361,7 +361,7 @@ static void intel_didl_outputs(struct drm_device *dev) ...@@ -361,7 +361,7 @@ static void intel_didl_outputs(struct drm_device *dev)
list_for_each_entry(acpi_cdev, &acpi_video_bus->children, node) { list_for_each_entry(acpi_cdev, &acpi_video_bus->children, node) {
if (i >= 8) { if (i >= 8) {
dev_printk (KERN_ERR, &dev->pdev->dev, dev_printk(KERN_ERR, &dev->pdev->dev,
"More than 8 outputs detected\n"); "More than 8 outputs detected\n");
return; return;
} }
...@@ -387,7 +387,7 @@ static void intel_didl_outputs(struct drm_device *dev) ...@@ -387,7 +387,7 @@ static void intel_didl_outputs(struct drm_device *dev)
list_for_each_entry(connector, &dev->mode_config.connector_list, head) { list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
int output_type = ACPI_OTHER_OUTPUT; int output_type = ACPI_OTHER_OUTPUT;
if (i >= 8) { if (i >= 8) {
dev_printk (KERN_ERR, &dev->pdev->dev, dev_printk(KERN_ERR, &dev->pdev->dev,
"More than 8 outputs detected\n"); "More than 8 outputs detected\n");
return; return;
} }
......
...@@ -264,7 +264,7 @@ i830_activate_pipe_a(struct drm_device *dev) ...@@ -264,7 +264,7 @@ i830_activate_pipe_a(struct drm_device *dev)
mode = drm_mode_duplicate(dev, &vesa_640x480); mode = drm_mode_duplicate(dev, &vesa_640x480);
drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V); drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V);
if(!drm_crtc_helper_set_mode(&crtc->base, mode, if (!drm_crtc_helper_set_mode(&crtc->base, mode,
crtc->base.x, crtc->base.y, crtc->base.x, crtc->base.y,
crtc->base.fb)) crtc->base.fb))
return 0; return 0;
...@@ -583,7 +583,7 @@ static u32 calc_swidthsw(struct drm_device *dev, u32 offset, u32 width) ...@@ -583,7 +583,7 @@ static u32 calc_swidthsw(struct drm_device *dev, u32 offset, u32 width)
ret = ((offset + width + mask) >> shift) - (offset >> shift); ret = ((offset + width + mask) >> shift) - (offset >> shift);
if (!IS_GEN2(dev)) if (!IS_GEN2(dev))
ret <<= 1; ret <<= 1;
ret -=1; ret -= 1;
return ret << 2; return ret << 2;
} }
...@@ -817,7 +817,7 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay, ...@@ -817,7 +817,7 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
regs->SWIDTHSW = calc_swidthsw(overlay->dev, regs->SWIDTHSW = calc_swidthsw(overlay->dev,
params->offset_Y, tmp_width); params->offset_Y, tmp_width);
regs->SHEIGHT = params->src_h; regs->SHEIGHT = params->src_h;
regs->OBUF_0Y = new_bo->gtt_offset + params-> offset_Y; regs->OBUF_0Y = new_bo->gtt_offset + params->offset_Y;
regs->OSTRIDE = params->stride_Y; regs->OSTRIDE = params->stride_Y;
if (params->format & I915_OVERLAY_YUV_PLANAR) { if (params->format & I915_OVERLAY_YUV_PLANAR) {
......
...@@ -206,7 +206,7 @@ u32 intel_panel_get_backlight(struct drm_device *dev) ...@@ -206,7 +206,7 @@ u32 intel_panel_get_backlight(struct drm_device *dev)
if (IS_PINEVIEW(dev)) if (IS_PINEVIEW(dev))
val >>= 1; val >>= 1;
if (is_backlight_combination_mode(dev)){ if (is_backlight_combination_mode(dev)) {
u8 lbpc; u8 lbpc;
val &= ~1; val &= ~1;
...@@ -236,7 +236,7 @@ void intel_panel_set_backlight(struct drm_device *dev, u32 level) ...@@ -236,7 +236,7 @@ void intel_panel_set_backlight(struct drm_device *dev, u32 level)
if (HAS_PCH_SPLIT(dev)) if (HAS_PCH_SPLIT(dev))
return intel_pch_panel_set_backlight(dev, level); return intel_pch_panel_set_backlight(dev, level);
if (is_backlight_combination_mode(dev)){ if (is_backlight_combination_mode(dev)) {
u32 max = intel_panel_get_max_backlight(dev); u32 max = intel_panel_get_max_backlight(dev);
u8 lbpc; u8 lbpc;
......
...@@ -2313,7 +2313,7 @@ static bool intel_sdvo_tv_create_property(struct intel_sdvo *intel_sdvo, ...@@ -2313,7 +2313,7 @@ static bool intel_sdvo_tv_create_property(struct intel_sdvo *intel_sdvo,
DRM_DEBUG_KMS(#name ": max %d, default %d, current %d\n", \ DRM_DEBUG_KMS(#name ": max %d, default %d, current %d\n", \
data_value[0], data_value[1], response); \ data_value[0], data_value[1], response); \
} \ } \
} while(0) } while (0)
static bool static bool
intel_sdvo_create_enhance_property_tv(struct intel_sdvo *intel_sdvo, intel_sdvo_create_enhance_property_tv(struct intel_sdvo *intel_sdvo,
...@@ -2480,7 +2480,7 @@ static bool intel_sdvo_create_enhance_property(struct intel_sdvo *intel_sdvo, ...@@ -2480,7 +2480,7 @@ static bool intel_sdvo_create_enhance_property(struct intel_sdvo *intel_sdvo,
if (IS_TV(intel_sdvo_connector)) if (IS_TV(intel_sdvo_connector))
return intel_sdvo_create_enhance_property_tv(intel_sdvo, intel_sdvo_connector, enhancements.reply); return intel_sdvo_create_enhance_property_tv(intel_sdvo, intel_sdvo_connector, enhancements.reply);
else if(IS_LVDS(intel_sdvo_connector)) else if (IS_LVDS(intel_sdvo_connector))
return intel_sdvo_create_enhance_property_lvds(intel_sdvo, intel_sdvo_connector, enhancements.reply); return intel_sdvo_create_enhance_property_lvds(intel_sdvo, intel_sdvo_connector, enhancements.reply);
else else
return true; return true;
......
...@@ -666,7 +666,7 @@ struct intel_sdvo_enhancement_limits_reply { ...@@ -666,7 +666,7 @@ struct intel_sdvo_enhancement_limits_reply {
#define SDVO_CMD_SET_TV_LUMA_FILTER 0x79 #define SDVO_CMD_SET_TV_LUMA_FILTER 0x79
struct intel_sdvo_enhancements_arg { struct intel_sdvo_enhancements_arg {
u16 value; u16 value;
}__attribute__((packed)); } __attribute__((packed));
#define SDVO_CMD_GET_DOT_CRAWL 0x70 #define SDVO_CMD_GET_DOT_CRAWL 0x70
#define SDVO_CMD_SET_DOT_CRAWL 0x71 #define SDVO_CMD_SET_DOT_CRAWL 0x71
...@@ -717,7 +717,7 @@ struct intel_sdvo_enhancements_arg { ...@@ -717,7 +717,7 @@ struct intel_sdvo_enhancements_arg {
#define SDVO_CMD_GET_AUDIO_TX_INFO 0x9c #define SDVO_CMD_GET_AUDIO_TX_INFO 0x9c
#define SDVO_NEED_TO_STALL (1 << 7) #define SDVO_NEED_TO_STALL (1 << 7)
struct intel_sdvo_encode{ struct intel_sdvo_encode {
u8 dvi_rev; u8 dvi_rev;
u8 hdmi_rev; u8 hdmi_rev;
} __attribute__ ((packed)); } __attribute__ ((packed));
...@@ -683,7 +683,7 @@ static const struct tv_mode tv_modes[] = { ...@@ -683,7 +683,7 @@ static const struct tv_mode tv_modes[] = {
.hsync_end = 64, .hblank_end = 122, .hsync_end = 64, .hblank_end = 122,
.hblank_start = 842, .htotal = 857, .hblank_start = 842, .htotal = 857,
.progressive = true,.trilevel_sync = false, .progressive = true, .trilevel_sync = false,
.vsync_start_f1 = 12, .vsync_start_f2 = 12, .vsync_start_f1 = 12, .vsync_start_f2 = 12,
.vsync_len = 12, .vsync_len = 12,
...@@ -707,7 +707,7 @@ static const struct tv_mode tv_modes[] = { ...@@ -707,7 +707,7 @@ static const struct tv_mode tv_modes[] = {
.hsync_end = 64, .hblank_end = 122, .hsync_end = 64, .hblank_end = 122,
.hblank_start = 842, .htotal = 856, .hblank_start = 842, .htotal = 856,
.progressive = true,.trilevel_sync = false, .progressive = true, .trilevel_sync = false,
.vsync_start_f1 = 12, .vsync_start_f2 = 12, .vsync_start_f1 = 12, .vsync_start_f2 = 12,
.vsync_len = 12, .vsync_len = 12,
...@@ -916,7 +916,7 @@ intel_tv_dpms(struct drm_encoder *encoder, int mode) ...@@ -916,7 +916,7 @@ intel_tv_dpms(struct drm_encoder *encoder, int mode)
struct drm_device *dev = encoder->dev; struct drm_device *dev = encoder->dev;
struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_private *dev_priv = dev->dev_private;
switch(mode) { switch (mode) {
case DRM_MODE_DPMS_ON: case DRM_MODE_DPMS_ON:
I915_WRITE(TV_CTL, I915_READ(TV_CTL) | TV_ENC_ENABLE); I915_WRITE(TV_CTL, I915_READ(TV_CTL) | TV_ENC_ENABLE);
break; break;
...@@ -933,7 +933,7 @@ intel_tv_mode_lookup(const char *tv_format) ...@@ -933,7 +933,7 @@ intel_tv_mode_lookup(const char *tv_format)
{ {
int i; int i;
for (i = 0; i < sizeof(tv_modes) / sizeof (tv_modes[0]); i++) { for (i = 0; i < sizeof(tv_modes) / sizeof(tv_modes[0]); i++) {
const struct tv_mode *tv_mode = &tv_modes[i]; const struct tv_mode *tv_mode = &tv_modes[i];
if (!strcmp(tv_format, tv_mode->name)) if (!strcmp(tv_format, tv_mode->name))
...@@ -1128,7 +1128,7 @@ intel_tv_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode, ...@@ -1128,7 +1128,7 @@ intel_tv_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
if (color_conversion) { if (color_conversion) {
I915_WRITE(TV_CSC_Y, (color_conversion->ry << 16) | I915_WRITE(TV_CSC_Y, (color_conversion->ry << 16) |
color_conversion->gy); color_conversion->gy);
I915_WRITE(TV_CSC_Y2,(color_conversion->by << 16) | I915_WRITE(TV_CSC_Y2, (color_conversion->by << 16) |
color_conversion->ay); color_conversion->ay);
I915_WRITE(TV_CSC_U, (color_conversion->ru << 16) | I915_WRITE(TV_CSC_U, (color_conversion->ru << 16) |
color_conversion->gu); color_conversion->gu);
...@@ -1232,7 +1232,7 @@ static const struct drm_display_mode reported_modes[] = { ...@@ -1232,7 +1232,7 @@ static const struct drm_display_mode reported_modes[] = {
* \return false if TV is disconnected. * \return false if TV is disconnected.
*/ */
static int static int
intel_tv_detect_type (struct intel_tv *intel_tv, intel_tv_detect_type(struct intel_tv *intel_tv,
struct drm_connector *connector) struct drm_connector *connector)
{ {
struct drm_encoder *encoder = &intel_tv->base.base; struct drm_encoder *encoder = &intel_tv->base.base;
...@@ -1486,7 +1486,7 @@ intel_tv_get_modes(struct drm_connector *connector) ...@@ -1486,7 +1486,7 @@ intel_tv_get_modes(struct drm_connector *connector)
} }
static void static void
intel_tv_destroy (struct drm_connector *connector) intel_tv_destroy(struct drm_connector *connector)
{ {
drm_sysfs_connector_remove(connector); drm_sysfs_connector_remove(connector);
drm_connector_cleanup(connector); drm_connector_cleanup(connector);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment