Commit 89fdb468 authored by Franky Lin's avatar Franky Lin Committed by John W. Linville

brcm80211: fmac: make sure cancel_work_sync only called after INIT_WORK

INIT_WORK only gets called after brcmf_proto_attach returns
success. This dependency should be annotated in brcmf_detach to
avoid any error.
Reviewed-by: default avatarPieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: default avatarFranky Lin <frankyl@broadcom.com>
Signed-off-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 2315992c
...@@ -1109,13 +1109,13 @@ void brcmf_detach(struct device *dev) ...@@ -1109,13 +1109,13 @@ void brcmf_detach(struct device *dev)
if (drvr->iflist[i]) if (drvr->iflist[i])
brcmf_del_if(drvr, i); brcmf_del_if(drvr, i);
cancel_work_sync(&drvr->setmacaddr_work);
cancel_work_sync(&drvr->multicast_work);
brcmf_bus_detach(drvr); brcmf_bus_detach(drvr);
if (drvr->prot) if (drvr->prot) {
cancel_work_sync(&drvr->setmacaddr_work);
cancel_work_sync(&drvr->multicast_work);
brcmf_proto_detach(drvr); brcmf_proto_detach(drvr);
}
bus_if->drvr = NULL; bus_if->drvr = NULL;
kfree(drvr); kfree(drvr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment