Commit 8b9733c1 authored by Vaishali Thakkar's avatar Vaishali Thakkar Committed by Greg Kroah-Hartman

Staging: rtl8192e: Eliminate use of MSECS macro

Use msecs_to_jiffies instead of driver specific macro
MSECS. This is done using Coccinelle and semantic
patch used for this is as follows:

@@expression t;@@

- MSECS(t)
+ msecs_to_jiffies(t)
Signed-off-by: default avatarVaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 453ce99c
...@@ -108,7 +108,7 @@ static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev) ...@@ -108,7 +108,7 @@ static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev)
u32 CPU_status = 0; u32 CPU_status = 0;
unsigned long timeout; unsigned long timeout;
timeout = jiffies + MSECS(200); timeout = jiffies + msecs_to_jiffies(200);
while (time_before(jiffies, timeout)) { while (time_before(jiffies, timeout)) {
CPU_status = read_nic_dword(dev, CPU_GEN); CPU_status = read_nic_dword(dev, CPU_GEN);
if (CPU_status & CPU_GEN_PUT_CODE_OK) if (CPU_status & CPU_GEN_PUT_CODE_OK)
...@@ -128,7 +128,7 @@ static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev) ...@@ -128,7 +128,7 @@ static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev)
(u8)((CPU_status|CPU_GEN_PWR_STB_CPU)&0xff)); (u8)((CPU_status|CPU_GEN_PWR_STB_CPU)&0xff));
mdelay(1); mdelay(1);
timeout = jiffies + MSECS(200); timeout = jiffies + msecs_to_jiffies(200);
while (time_before(jiffies, timeout)) { while (time_before(jiffies, timeout)) {
CPU_status = read_nic_dword(dev, CPU_GEN); CPU_status = read_nic_dword(dev, CPU_GEN);
if (CPU_status&CPU_GEN_BOOT_RDY) if (CPU_status&CPU_GEN_BOOT_RDY)
...@@ -156,7 +156,7 @@ static bool CPUcheck_firmware_ready(struct net_device *dev) ...@@ -156,7 +156,7 @@ static bool CPUcheck_firmware_ready(struct net_device *dev)
u32 CPU_status = 0; u32 CPU_status = 0;
unsigned long timeout; unsigned long timeout;
timeout = jiffies + MSECS(20); timeout = jiffies + msecs_to_jiffies(20);
while (time_before(jiffies, timeout)) { while (time_before(jiffies, timeout)) {
CPU_status = read_nic_dword(dev, CPU_GEN); CPU_status = read_nic_dword(dev, CPU_GEN);
if (CPU_status&CPU_GEN_FIRM_RDY) if (CPU_status&CPU_GEN_FIRM_RDY)
......
...@@ -1793,7 +1793,7 @@ void watch_dog_timer_callback(unsigned long data) ...@@ -1793,7 +1793,7 @@ void watch_dog_timer_callback(unsigned long data)
queue_delayed_work_rsl(priv->priv_wq, &priv->watch_dog_wq, 0); queue_delayed_work_rsl(priv->priv_wq, &priv->watch_dog_wq, 0);
mod_timer(&priv->watch_dog_timer, jiffies + mod_timer(&priv->watch_dog_timer, jiffies +
MSECS(RTLLIB_WATCH_DOG_TIME)); msecs_to_jiffies(RTLLIB_WATCH_DOG_TIME));
} }
/**************************************************************************** /****************************************************************************
...@@ -3106,7 +3106,7 @@ void check_rfctrl_gpio_timer(unsigned long data) ...@@ -3106,7 +3106,7 @@ void check_rfctrl_gpio_timer(unsigned long data)
queue_delayed_work_rsl(priv->priv_wq, &priv->gpio_change_rf_wq, 0); queue_delayed_work_rsl(priv->priv_wq, &priv->gpio_change_rf_wq, 0);
mod_timer(&priv->gpio_polling_timer, jiffies + mod_timer(&priv->gpio_polling_timer, jiffies +
MSECS(RTLLIB_WATCH_DOG_TIME)); msecs_to_jiffies(RTLLIB_WATCH_DOG_TIME));
} }
/*************************************************************************** /***************************************************************************
......
...@@ -2665,14 +2665,14 @@ void dm_fsync_timer_callback(unsigned long data) ...@@ -2665,14 +2665,14 @@ void dm_fsync_timer_callback(unsigned long data)
if (timer_pending(&priv->fsync_timer)) if (timer_pending(&priv->fsync_timer))
del_timer_sync(&priv->fsync_timer); del_timer_sync(&priv->fsync_timer);
priv->fsync_timer.expires = jiffies + priv->fsync_timer.expires = jiffies +
MSECS(priv->rtllib->fsync_time_interval * msecs_to_jiffies(priv->rtllib->fsync_time_interval *
priv->rtllib->fsync_multiple_timeinterval); priv->rtllib->fsync_multiple_timeinterval);
add_timer(&priv->fsync_timer); add_timer(&priv->fsync_timer);
} else { } else {
if (timer_pending(&priv->fsync_timer)) if (timer_pending(&priv->fsync_timer))
del_timer_sync(&priv->fsync_timer); del_timer_sync(&priv->fsync_timer);
priv->fsync_timer.expires = jiffies + priv->fsync_timer.expires = jiffies +
MSECS(priv->rtllib->fsync_time_interval); msecs_to_jiffies(priv->rtllib->fsync_time_interval);
add_timer(&priv->fsync_timer); add_timer(&priv->fsync_timer);
} }
} else { } else {
...@@ -2762,7 +2762,7 @@ static void dm_StartSWFsync(struct net_device *dev) ...@@ -2762,7 +2762,7 @@ static void dm_StartSWFsync(struct net_device *dev)
if (timer_pending(&priv->fsync_timer)) if (timer_pending(&priv->fsync_timer))
del_timer_sync(&priv->fsync_timer); del_timer_sync(&priv->fsync_timer);
priv->fsync_timer.expires = jiffies + priv->fsync_timer.expires = jiffies +
MSECS(priv->rtllib->fsync_time_interval); msecs_to_jiffies(priv->rtllib->fsync_time_interval);
add_timer(&priv->fsync_timer); add_timer(&priv->fsync_timer);
write_nic_dword(dev, rOFDM0_RxDetector2, 0x465c12cd); write_nic_dword(dev, rOFDM0_RxDetector2, 0x465c12cd);
......
...@@ -67,7 +67,8 @@ void rtl8192_hw_wakeup(struct net_device *dev) ...@@ -67,7 +67,8 @@ void rtl8192_hw_wakeup(struct net_device *dev)
RT_TRACE(COMP_DBG, "rtl8192_hw_wakeup(): RF Change in " RT_TRACE(COMP_DBG, "rtl8192_hw_wakeup(): RF Change in "
"progress!\n"); "progress!\n");
queue_delayed_work_rsl(priv->rtllib->wq, queue_delayed_work_rsl(priv->rtllib->wq,
&priv->rtllib->hw_wakeup_wq, MSECS(10)); &priv->rtllib->hw_wakeup_wq,
msecs_to_jiffies(10));
return; return;
} }
spin_unlock_irqrestore(&priv->rf_ps_lock, flags); spin_unlock_irqrestore(&priv->rf_ps_lock, flags);
...@@ -95,18 +96,18 @@ void rtl8192_hw_to_sleep(struct net_device *dev, u64 time) ...@@ -95,18 +96,18 @@ void rtl8192_hw_to_sleep(struct net_device *dev, u64 time)
spin_lock_irqsave(&priv->ps_lock, flags); spin_lock_irqsave(&priv->ps_lock, flags);
time -= MSECS(8+16+7); time -= msecs_to_jiffies(8 + 16 + 7);
if ((time - jiffies) <= MSECS(MIN_SLEEP_TIME)) { if ((time - jiffies) <= msecs_to_jiffies(MIN_SLEEP_TIME)) {
spin_unlock_irqrestore(&priv->ps_lock, flags); spin_unlock_irqrestore(&priv->ps_lock, flags);
printk(KERN_INFO "too short to sleep::%lld < %ld\n", printk(KERN_INFO "too short to sleep::%lld < %ld\n",
time - jiffies, MSECS(MIN_SLEEP_TIME)); time - jiffies, msecs_to_jiffies(MIN_SLEEP_TIME));
return; return;
} }
if ((time - jiffies) > MSECS(MAX_SLEEP_TIME)) { if ((time - jiffies) > msecs_to_jiffies(MAX_SLEEP_TIME)) {
printk(KERN_INFO "========>too long to sleep:%lld > %ld\n", printk(KERN_INFO "========>too long to sleep:%lld > %ld\n",
time - jiffies, MSECS(MAX_SLEEP_TIME)); time - jiffies, msecs_to_jiffies(MAX_SLEEP_TIME));
spin_unlock_irqrestore(&priv->ps_lock, flags); spin_unlock_irqrestore(&priv->ps_lock, flags);
return; return;
} }
......
...@@ -26,7 +26,7 @@ static void ActivateBAEntry(struct rtllib_device *ieee, struct ba_record *pBA, ...@@ -26,7 +26,7 @@ static void ActivateBAEntry(struct rtllib_device *ieee, struct ba_record *pBA,
{ {
pBA->bValid = true; pBA->bValid = true;
if (Time != 0) if (Time != 0)
mod_timer(&pBA->Timer, jiffies + MSECS(Time)); mod_timer(&pBA->Timer, jiffies + msecs_to_jiffies(Time));
} }
static void DeActivateBAEntry(struct rtllib_device *ieee, struct ba_record *pBA) static void DeActivateBAEntry(struct rtllib_device *ieee, struct ba_record *pBA)
......
...@@ -91,7 +91,7 @@ static void RxPktPendingTimeout(unsigned long data) ...@@ -91,7 +91,7 @@ static void RxPktPendingTimeout(unsigned long data)
if (bPktInBuf && (pRxTs->RxTimeoutIndicateSeq == 0xffff)) { if (bPktInBuf && (pRxTs->RxTimeoutIndicateSeq == 0xffff)) {
pRxTs->RxTimeoutIndicateSeq = pRxTs->RxIndicateSeq; pRxTs->RxTimeoutIndicateSeq = pRxTs->RxIndicateSeq;
mod_timer(&pRxTs->RxPktPendingTimer, jiffies + mod_timer(&pRxTs->RxPktPendingTimer, jiffies +
MSECS(ieee->pHTInfo->RxReorderPendingTime)); msecs_to_jiffies(ieee->pHTInfo->RxReorderPendingTime));
} }
spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags); spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags);
} }
...@@ -223,7 +223,7 @@ static void AdmitTS(struct rtllib_device *ieee, ...@@ -223,7 +223,7 @@ static void AdmitTS(struct rtllib_device *ieee,
if (InactTime != 0) if (InactTime != 0)
mod_timer(&pTsCommonInfo->InactTimer, jiffies + mod_timer(&pTsCommonInfo->InactTimer, jiffies +
MSECS(InactTime)); msecs_to_jiffies(InactTime));
} }
static struct ts_common_info *SearchAdmitTRStream(struct rtllib_device *ieee, static struct ts_common_info *SearchAdmitTRStream(struct rtllib_device *ieee,
...@@ -542,7 +542,7 @@ void TsStartAddBaProcess(struct rtllib_device *ieee, struct tx_ts_record *pTxTS) ...@@ -542,7 +542,7 @@ void TsStartAddBaProcess(struct rtllib_device *ieee, struct tx_ts_record *pTxTS)
RTLLIB_DEBUG(RTLLIB_DL_BA, "TsStartAddBaProcess(): " RTLLIB_DEBUG(RTLLIB_DL_BA, "TsStartAddBaProcess(): "
"Delayed Start ADDBA after 60 sec!!\n"); "Delayed Start ADDBA after 60 sec!!\n");
mod_timer(&pTxTS->TsAddBaTimer, jiffies + mod_timer(&pTxTS->TsAddBaTimer, jiffies +
MSECS(TS_ADDBA_DELAY)); msecs_to_jiffies(TS_ADDBA_DELAY));
} else { } else {
RTLLIB_DEBUG(RTLLIB_DL_BA, "TsStartAddBaProcess(): " RTLLIB_DEBUG(RTLLIB_DL_BA, "TsStartAddBaProcess(): "
"Immediately Start ADDBA now!!\n"); "Immediately Start ADDBA now!!\n");
......
...@@ -525,7 +525,6 @@ struct ieee_param { ...@@ -525,7 +525,6 @@ struct ieee_param {
#define IW_QUAL_NOISE_UPDATED 0x4 #define IW_QUAL_NOISE_UPDATED 0x4
#endif #endif
#define MSECS(t) msecs_to_jiffies(t)
#define msleep_interruptible_rsl msleep_interruptible #define msleep_interruptible_rsl msleep_interruptible
#define RTLLIB_DATA_LEN 2304 #define RTLLIB_DATA_LEN 2304
......
...@@ -717,7 +717,7 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee, ...@@ -717,7 +717,7 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee,
__func__); __func__);
pTS->RxTimeoutIndicateSeq = pTS->RxIndicateSeq; pTS->RxTimeoutIndicateSeq = pTS->RxIndicateSeq;
mod_timer(&pTS->RxPktPendingTimer, jiffies + mod_timer(&pTS->RxPktPendingTimer, jiffies +
MSECS(pHTInfo->RxReorderPendingTime)); msecs_to_jiffies(pHTInfo->RxReorderPendingTime));
} }
spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags); spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags);
} }
......
...@@ -401,7 +401,7 @@ static void rtllib_send_beacon(struct rtllib_device *ieee) ...@@ -401,7 +401,7 @@ static void rtllib_send_beacon(struct rtllib_device *ieee)
if (ieee->beacon_txing && ieee->ieee_up) if (ieee->beacon_txing && ieee->ieee_up)
mod_timer(&ieee->beacon_timer, jiffies + mod_timer(&ieee->beacon_timer, jiffies +
(MSECS(ieee->current_network.beacon_interval - 5))); (msecs_to_jiffies(ieee->current_network.beacon_interval - 5)));
} }
...@@ -639,7 +639,7 @@ static void rtllib_softmac_scan_wq(void *data) ...@@ -639,7 +639,7 @@ static void rtllib_softmac_scan_wq(void *data)
rtllib_send_probe_requests(ieee, 0); rtllib_send_probe_requests(ieee, 0);
queue_delayed_work_rsl(ieee->wq, &ieee->softmac_scan_wq, queue_delayed_work_rsl(ieee->wq, &ieee->softmac_scan_wq,
MSECS(RTLLIB_SOFTMAC_SCAN_TIME)); msecs_to_jiffies(RTLLIB_SOFTMAC_SCAN_TIME));
up(&ieee->scan_sem); up(&ieee->scan_sem);
return; return;
...@@ -2008,9 +2008,11 @@ static short rtllib_sta_ps_sleep(struct rtllib_device *ieee, u64 *time) ...@@ -2008,9 +2008,11 @@ static short rtllib_sta_ps_sleep(struct rtllib_device *ieee, u64 *time)
if (dtim & (RTLLIB_DTIM_UCAST & ieee->ps)) if (dtim & (RTLLIB_DTIM_UCAST & ieee->ps))
return 2; return 2;
if (!time_after(jiffies, ieee->dev->trans_start + MSECS(timeout))) if (!time_after(jiffies,
ieee->dev->trans_start + msecs_to_jiffies(timeout)))
return 0; return 0;
if (!time_after(jiffies, ieee->last_rx_ps_time + MSECS(timeout))) if (!time_after(jiffies,
ieee->last_rx_ps_time + msecs_to_jiffies(timeout)))
return 0; return 0;
if ((ieee->softmac_features & IEEE_SOFTMAC_SINGLE_QUEUE) && if ((ieee->softmac_features & IEEE_SOFTMAC_SINGLE_QUEUE) &&
(ieee->mgmt_queue_tail != ieee->mgmt_queue_head)) (ieee->mgmt_queue_tail != ieee->mgmt_queue_head))
...@@ -2060,7 +2062,7 @@ static short rtllib_sta_ps_sleep(struct rtllib_device *ieee, u64 *time) ...@@ -2060,7 +2062,7 @@ static short rtllib_sta_ps_sleep(struct rtllib_device *ieee, u64 *time)
} }
*time = ieee->current_network.last_dtim_sta_time *time = ieee->current_network.last_dtim_sta_time
+ MSECS(ieee->current_network.beacon_interval * + msecs_to_jiffies(ieee->current_network.beacon_interval *
LPSAwakeIntvl_tmp); LPSAwakeIntvl_tmp);
} }
} }
...@@ -2808,7 +2810,8 @@ static void rtllib_start_ibss_wq(void *data) ...@@ -2808,7 +2810,8 @@ static void rtllib_start_ibss_wq(void *data)
inline void rtllib_start_ibss(struct rtllib_device *ieee) inline void rtllib_start_ibss(struct rtllib_device *ieee)
{ {
queue_delayed_work_rsl(ieee->wq, &ieee->start_ibss_wq, MSECS(150)); queue_delayed_work_rsl(ieee->wq, &ieee->start_ibss_wq,
msecs_to_jiffies(150));
} }
/* this is called only in user context, with wx_sem held */ /* this is called only in user context, with wx_sem held */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment