Skip to content

L
linux
Commit 8bc4a9ed authored by Antti Palosaari's avatar Antti Palosaari Committed by Mauro Carvalho Chehab
Browse files
Options

[media] hackrf: add support for transmitter 

HackRF SDR device has both receiver and transmitter. There is limitation
that receiver and transmitter cannot be used at the same time
(half-duplex operation). That patch implements transmitter support to
existing receiver only driver.
Signed-off-by: default avatarAntti Palosaari <crope@iki.fi>
[hans.verkuil@cisco.com: fix krobot unused variable warning]
[hans.verkuil@cisco.com: add back s_modulator from PATCHv4]
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent eec20f06
Show whitespace changes
Inline Side-by-side
Showing with 638 additions and 276 deletions
drivers/media/usb/hackrf/hackrf.c
View file @ 8bc4a9ed
...@@ -35,6 +35,7 @@ enum { ...@@ -35,6 +35,7 @@ enum {
CMD_AMP_ENABLE = 0x11, CMD_AMP_ENABLE = 0x11,
CMD_SET_LNA_GAIN = 0x13, CMD_SET_LNA_GAIN = 0x13,
CMD_SET_VGA_GAIN = 0x14, CMD_SET_VGA_GAIN = 0x14,
CMD_SET_TXVGA_GAIN = 0x15,
}; };
/* /*
...@@ -45,10 +46,10 @@ enum { ...@@ -45,10 +46,10 @@ enum {
#define MAX_BULK_BUFS (6) #define MAX_BULK_BUFS (6)
#define BULK_BUFFER_SIZE (128 * 512) #define BULK_BUFFER_SIZE (128 * 512)
static const struct v4l2_frequency_band bands_adc[] = { static const struct v4l2_frequency_band bands_adc_dac[] = {
{ {
.tuner = 0, .tuner = 0,
.type = V4L2_TUNER_ADC, .type = V4L2_TUNER_SDR,
.index = 0, .index = 0,
.capability = V4L2_TUNER_CAP_1HZ | V4L2_TUNER_CAP_FREQ_BANDS, .capability = V4L2_TUNER_CAP_1HZ | V4L2_TUNER_CAP_FREQ_BANDS,
.rangelow = 200000, .rangelow = 200000,
...@@ -56,7 +57,7 @@ static const struct v4l2_frequency_band bands_adc[] = { ...@@ -56,7 +57,7 @@ static const struct v4l2_frequency_band bands_adc[] = {
}, },
}; };
static const struct v4l2_frequency_band bands_rf[] = { static const struct v4l2_frequency_band bands_rx_tx[] = {
{ {
.tuner = 1, .tuner = 1,
.type = V4L2_TUNER_RF, .type = V4L2_TUNER_RF,
...@@ -86,35 +87,44 @@ static struct hackrf_format formats[] = { ...@@ -86,35 +87,44 @@ static struct hackrf_format formats[] = {
static const unsigned int NUM_FORMATS = ARRAY_SIZE(formats); static const unsigned int NUM_FORMATS = ARRAY_SIZE(formats);
/* intermediate buffers with raw data from the USB device */ /* intermediate buffers with raw data from the USB device */
struct hackrf_frame_buf { struct hackrf_buffer {
/* common v4l buffer stuff -- must be first */
struct vb2_v4l2_buffer vb; struct vb2_v4l2_buffer vb;
struct list_head list; struct list_head list;
}; };
struct hackrf_dev { struct hackrf_dev {
#define POWER_ON 1 #define USB_STATE_URB_BUF 1 /* XXX: set manually */
#define USB_STATE_URB_BUF 2 /* XXX: set manually */ #define RX_ON 4
#define SAMPLE_RATE_SET 10 #define TX_ON 5
#define RX_BANDWIDTH 11 #define RX_ADC_FREQUENCY 11
#define RX_RF_FREQUENCY 12 #define TX_DAC_FREQUENCY 12
#define RX_RF_GAIN 13 #define RX_BANDWIDTH 13
#define RX_LNA_GAIN 14 #define TX_BANDWIDTH 14
#define RX_IF_GAIN 15 #define RX_RF_FREQUENCY 15
#define TX_RF_FREQUENCY 16
#define RX_RF_GAIN 17
#define TX_RF_GAIN 18
#define RX_IF_GAIN 19
#define RX_LNA_GAIN 20
#define TX_LNA_GAIN 21
unsigned long flags; unsigned long flags;
struct usb_interface *intf; struct usb_interface *intf;
struct device *dev; struct device *dev;
struct usb_device *udev; struct usb_device *udev;
struct video_device vdev; struct video_device rx_vdev;
struct video_device tx_vdev;
struct v4l2_device v4l2_dev; struct v4l2_device v4l2_dev;
/* videobuf2 queue and queued buffers list */ /* videobuf2 queue and queued buffers list */
struct vb2_queue vb_queue; struct vb2_queue rx_vb2_queue;
struct list_head queued_bufs; struct vb2_queue tx_vb2_queue;
spinlock_t queued_bufs_lock; /* Protects queued_bufs */ struct list_head rx_buffer_list;
struct list_head tx_buffer_list;
spinlock_t buffer_list_lock; /* Protects buffer_list */
unsigned sequence; /* Buffer sequence counter */ unsigned sequence; /* Buffer sequence counter */
unsigned int vb_full; /* vb is full and packets dropped */ unsigned int vb_full; /* vb is full and packets dropped */
unsigned int vb_empty; /* vb is empty and packets dropped */
/* Note if taking both locks v4l2_lock must always be locked first! */ /* Note if taking both locks v4l2_lock must always be locked first! */
struct mutex v4l2_lock; /* Protects everything else */ struct mutex v4l2_lock; /* Protects everything else */
...@@ -134,17 +144,24 @@ struct hackrf_dev { ...@@ -134,17 +144,24 @@ struct hackrf_dev {
/* Current configuration */ /* Current configuration */
unsigned int f_adc; unsigned int f_adc;
unsigned int f_rf; unsigned int f_dac;
unsigned int f_rx;
unsigned int f_tx;
u32 pixelformat; u32 pixelformat;
u32 buffersize; u32 buffersize;
/* Controls */ /* Controls */
struct v4l2_ctrl_handler hdl; struct v4l2_ctrl_handler rx_ctrl_handler;
struct v4l2_ctrl *bandwidth_auto; struct v4l2_ctrl *rx_bandwidth_auto;
struct v4l2_ctrl *bandwidth; struct v4l2_ctrl *rx_bandwidth;
struct v4l2_ctrl *rf_gain; struct v4l2_ctrl *rx_rf_gain;
struct v4l2_ctrl *lna_gain; struct v4l2_ctrl *rx_lna_gain;
struct v4l2_ctrl *if_gain; struct v4l2_ctrl *rx_if_gain;
struct v4l2_ctrl_handler tx_ctrl_handler;
struct v4l2_ctrl *tx_bandwidth_auto;
struct v4l2_ctrl *tx_bandwidth;
struct v4l2_ctrl *tx_rf_gain;
struct v4l2_ctrl *tx_lna_gain;
/* Sample rate calc */ /* Sample rate calc */
unsigned long jiffies_next; unsigned long jiffies_next;
...@@ -184,6 +201,7 @@ static int hackrf_ctrl_msg(struct hackrf_dev *dev, u8 request, u16 value, ...@@ -184,6 +201,7 @@ static int hackrf_ctrl_msg(struct hackrf_dev *dev, u8 request, u16 value,
case CMD_VERSION_STRING_READ: case CMD_VERSION_STRING_READ:
case CMD_SET_LNA_GAIN: case CMD_SET_LNA_GAIN:
case CMD_SET_VGA_GAIN: case CMD_SET_VGA_GAIN:
case CMD_SET_TXVGA_GAIN:
pipe = usb_rcvctrlpipe(dev->udev, 0); pipe = usb_rcvctrlpipe(dev->udev, 0);
requesttype = (USB_TYPE_VENDOR | USB_DIR_IN); requesttype = (USB_TYPE_VENDOR | USB_DIR_IN);
break; break;
...@@ -222,30 +240,8 @@ static int hackrf_set_params(struct hackrf_dev *dev) ...@@ -222,30 +240,8 @@ static int hackrf_set_params(struct hackrf_dev *dev)
int ret, i; int ret, i;
u8 buf[8], u8tmp; u8 buf[8], u8tmp;
unsigned int uitmp, uitmp1, uitmp2; unsigned int uitmp, uitmp1, uitmp2;
const bool rx = test_bit(RX_ON, &dev->flags);
if (!test_bit(POWER_ON, &dev->flags)) { const bool tx = test_bit(TX_ON, &dev->flags);
dev_dbg(&intf->dev, "device is sleeping\n");
return 0;
}
if (test_and_clear_bit(SAMPLE_RATE_SET, &dev->flags)) {
dev_dbg(&intf->dev, "ADC frequency=%u Hz\n", dev->f_adc);
uitmp1 = dev->f_adc;
uitmp2 = 1;
buf[0] = (uitmp1 >> 0) & 0xff;
buf[1] = (uitmp1 >> 8) & 0xff;
buf[2] = (uitmp1 >> 16) & 0xff;
buf[3] = (uitmp1 >> 24) & 0xff;
buf[4] = (uitmp2 >> 0) & 0xff;
buf[5] = (uitmp2 >> 8) & 0xff;
buf[6] = (uitmp2 >> 16) & 0xff;
buf[7] = (uitmp2 >> 24) & 0xff;
ret = hackrf_ctrl_msg(dev, CMD_SAMPLE_RATE_SET, 0, 0, buf, 8);
if (ret)
goto err;
}
if (test_and_clear_bit(RX_BANDWIDTH, &dev->flags)) {
static const struct { static const struct {
u32 freq; u32 freq;
} bandwidth_lut[] = { } bandwidth_lut[] = {
...@@ -267,10 +263,45 @@ static int hackrf_set_params(struct hackrf_dev *dev) ...@@ -267,10 +263,45 @@ static int hackrf_set_params(struct hackrf_dev *dev)
{28000000}, /* 28 MHz */ {28000000}, /* 28 MHz */
}; };
if (dev->bandwidth_auto->val == true) if (!rx && !tx) {
dev_dbg(&intf->dev, "device is sleeping\n");
return 0;
}
/* ADC / DAC frequency */
if (rx && test_and_clear_bit(RX_ADC_FREQUENCY, &dev->flags)) {
dev_dbg(&intf->dev, "RX ADC frequency=%u Hz\n", dev->f_adc);
uitmp1 = dev->f_adc;
uitmp2 = 1;
set_bit(TX_DAC_FREQUENCY, &dev->flags);
} else if (tx && test_and_clear_bit(TX_DAC_FREQUENCY, &dev->flags)) {
dev_dbg(&intf->dev, "TX DAC frequency=%u Hz\n", dev->f_dac);
uitmp1 = dev->f_dac;
uitmp2 = 1;
set_bit(RX_ADC_FREQUENCY, &dev->flags);
} else {
uitmp1 = uitmp2 = 0;
}
if (uitmp1 || uitmp2) {
buf[0] = (uitmp1 >> 0) & 0xff;
buf[1] = (uitmp1 >> 8) & 0xff;
buf[2] = (uitmp1 >> 16) & 0xff;
buf[3] = (uitmp1 >> 24) & 0xff;
buf[4] = (uitmp2 >> 0) & 0xff;
buf[5] = (uitmp2 >> 8) & 0xff;
buf[6] = (uitmp2 >> 16) & 0xff;
buf[7] = (uitmp2 >> 24) & 0xff;
ret = hackrf_ctrl_msg(dev, CMD_SAMPLE_RATE_SET, 0, 0, buf, 8);
if (ret)
goto err;
}
/* bandwidth */
if (rx && test_and_clear_bit(RX_BANDWIDTH, &dev->flags)) {
if (dev->rx_bandwidth_auto->val == true)
uitmp = dev->f_adc; uitmp = dev->f_adc;
else else
uitmp = dev->bandwidth->val; uitmp = dev->rx_bandwidth->val;
for (i = 0; i < ARRAY_SIZE(bandwidth_lut); i++) { for (i = 0; i < ARRAY_SIZE(bandwidth_lut); i++) {
if (uitmp <= bandwidth_lut[i].freq) { if (uitmp <= bandwidth_lut[i].freq) {
...@@ -278,29 +309,56 @@ static int hackrf_set_params(struct hackrf_dev *dev) ...@@ -278,29 +309,56 @@ static int hackrf_set_params(struct hackrf_dev *dev)
break; break;
} }
} }
dev->rx_bandwidth->val = uitmp;
dev->rx_bandwidth->cur.val = uitmp;
dev_dbg(&intf->dev, "RX bandwidth selected=%u\n", uitmp);
set_bit(TX_BANDWIDTH, &dev->flags);
} else if (tx && test_and_clear_bit(TX_BANDWIDTH, &dev->flags)) {
if (dev->tx_bandwidth_auto->val == true)
uitmp = dev->f_dac;
else
uitmp = dev->tx_bandwidth->val;
dev->bandwidth->val = uitmp; for (i = 0; i < ARRAY_SIZE(bandwidth_lut); i++) {
dev->bandwidth->cur.val = uitmp; if (uitmp <= bandwidth_lut[i].freq) {
uitmp = bandwidth_lut[i].freq;
dev_dbg(&intf->dev, "bandwidth selected=%u\n", uitmp); break;
}
uitmp1 = 0; }
dev->tx_bandwidth->val = uitmp;
dev->tx_bandwidth->cur.val = uitmp;
dev_dbg(&intf->dev, "TX bandwidth selected=%u\n", uitmp);
set_bit(RX_BANDWIDTH, &dev->flags);
} else {
uitmp = 0;
}
if (uitmp) {
uitmp1 = uitmp2 = 0;
uitmp1 |= ((uitmp >> 0) & 0xff) << 0; uitmp1 |= ((uitmp >> 0) & 0xff) << 0;
uitmp1 |= ((uitmp >> 8) & 0xff) << 8; uitmp1 |= ((uitmp >> 8) & 0xff) << 8;
uitmp2 = 0;
uitmp2 |= ((uitmp >> 16) & 0xff) << 0; uitmp2 |= ((uitmp >> 16) & 0xff) << 0;
uitmp2 |= ((uitmp >> 24) & 0xff) << 8; uitmp2 |= ((uitmp >> 24) & 0xff) << 8;
ret = hackrf_ctrl_msg(dev, CMD_BASEBAND_FILTER_BANDWIDTH_SET, ret = hackrf_ctrl_msg(dev, CMD_BASEBAND_FILTER_BANDWIDTH_SET,
uitmp1, uitmp2, NULL, 0); uitmp1, uitmp2, NULL, 0);
if (ret) if (ret)
goto err; goto err;
} }
if (test_and_clear_bit(RX_RF_FREQUENCY, &dev->flags)) { /* RX / TX RF frequency */
dev_dbg(&intf->dev, "RF frequency=%u Hz\n", dev->f_rf); if (rx && test_and_clear_bit(RX_RF_FREQUENCY, &dev->flags)) {
uitmp1 = dev->f_rf / 1000000; dev_dbg(&intf->dev, "RX RF frequency=%u Hz\n", dev->f_rx);
uitmp2 = dev->f_rf % 1000000; uitmp1 = dev->f_rx / 1000000;
uitmp2 = dev->f_rx % 1000000;
set_bit(TX_RF_FREQUENCY, &dev->flags);
} else if (tx && test_and_clear_bit(TX_RF_FREQUENCY, &dev->flags)) {
dev_dbg(&intf->dev, "TX RF frequency=%u Hz\n", dev->f_tx);
uitmp1 = dev->f_tx / 1000000;
uitmp2 = dev->f_tx % 1000000;
set_bit(RX_RF_FREQUENCY, &dev->flags);
} else {
uitmp1 = uitmp2 = 0;
}
if (uitmp1 || uitmp2) {
buf[0] = (uitmp1 >> 0) & 0xff; buf[0] = (uitmp1 >> 0) & 0xff;
buf[1] = (uitmp1 >> 8) & 0xff; buf[1] = (uitmp1 >> 8) & 0xff;
buf[2] = (uitmp1 >> 16) & 0xff; buf[2] = (uitmp1 >> 16) & 0xff;
...@@ -314,32 +372,59 @@ static int hackrf_set_params(struct hackrf_dev *dev) ...@@ -314,32 +372,59 @@ static int hackrf_set_params(struct hackrf_dev *dev)
goto err; goto err;
} }
if (test_and_clear_bit(RX_RF_GAIN, &dev->flags)) { /* RX RF gain */
dev_dbg(&intf->dev, "RF gain val=%d->%d\n", if (rx && test_and_clear_bit(RX_RF_GAIN, &dev->flags)) {
dev->rf_gain->cur.val, dev->rf_gain->val); dev_dbg(&intf->dev, "RX RF gain val=%d->%d\n",
dev->rx_rf_gain->cur.val, dev->rx_rf_gain->val);
u8tmp = (dev->rf_gain->val) ? 1 : 0; u8tmp = (dev->rx_rf_gain->val) ? 1 : 0;
ret = hackrf_ctrl_msg(dev, CMD_AMP_ENABLE, u8tmp, 0, NULL, 0); ret = hackrf_ctrl_msg(dev, CMD_AMP_ENABLE, u8tmp, 0, NULL, 0);
if (ret) if (ret)
goto err; goto err;
set_bit(TX_RF_GAIN, &dev->flags);
} }
if (test_and_clear_bit(RX_LNA_GAIN, &dev->flags)) { /* TX RF gain */
dev_dbg(dev->dev, "LNA gain val=%d->%d\n", if (tx && test_and_clear_bit(TX_RF_GAIN, &dev->flags)) {
dev->lna_gain->cur.val, dev->lna_gain->val); dev_dbg(&intf->dev, "TX RF gain val=%d->%d\n",
dev->tx_rf_gain->cur.val, dev->tx_rf_gain->val);
u8tmp = (dev->tx_rf_gain->val) ? 1 : 0;
ret = hackrf_ctrl_msg(dev, CMD_AMP_ENABLE, u8tmp, 0, NULL, 0);
if (ret)
goto err;
set_bit(RX_RF_GAIN, &dev->flags);
}
/* RX LNA gain */
if (rx && test_and_clear_bit(RX_LNA_GAIN, &dev->flags)) {
dev_dbg(dev->dev, "RX LNA gain val=%d->%d\n",
dev->rx_lna_gain->cur.val, dev->rx_lna_gain->val);
ret = hackrf_ctrl_msg(dev, CMD_SET_LNA_GAIN, 0, ret = hackrf_ctrl_msg(dev, CMD_SET_LNA_GAIN, 0,
dev->lna_gain->val, &u8tmp, 1); dev->rx_lna_gain->val, &u8tmp, 1);
if (ret) if (ret)
goto err; goto err;
} }
if (test_and_clear_bit(RX_IF_GAIN, &dev->flags)) { /* RX IF gain */
if (rx && test_and_clear_bit(RX_IF_GAIN, &dev->flags)) {
dev_dbg(&intf->dev, "IF gain val=%d->%d\n", dev_dbg(&intf->dev, "IF gain val=%d->%d\n",
dev->if_gain->cur.val, dev->if_gain->val); dev->rx_if_gain->cur.val, dev->rx_if_gain->val);
ret = hackrf_ctrl_msg(dev, CMD_SET_VGA_GAIN, 0, ret = hackrf_ctrl_msg(dev, CMD_SET_VGA_GAIN, 0,
dev->if_gain->val, &u8tmp, 1); dev->rx_if_gain->val, &u8tmp, 1);
if (ret)
goto err;
}
/* TX LNA gain */
if (tx && test_and_clear_bit(TX_LNA_GAIN, &dev->flags)) {
dev_dbg(&intf->dev, "TX LNA gain val=%d->%d\n",
dev->tx_lna_gain->cur.val, dev->tx_lna_gain->val);
ret = hackrf_ctrl_msg(dev, CMD_SET_TXVGA_GAIN, 0,
dev->tx_lna_gain->val, &u8tmp, 1);
if (ret) if (ret)
goto err; goto err;
} }
...@@ -351,24 +436,25 @@ static int hackrf_set_params(struct hackrf_dev *dev) ...@@ -351,24 +436,25 @@ static int hackrf_set_params(struct hackrf_dev *dev)
} }
/* Private functions */ /* Private functions */
static struct hackrf_frame_buf *hackrf_get_next_fill_buf(struct hackrf_dev *dev) static struct hackrf_buffer *hackrf_get_next_buffer(struct hackrf_dev *dev,
struct list_head *buffer_list)
{ {
unsigned long flags; unsigned long flags;
struct hackrf_frame_buf *buf = NULL; struct hackrf_buffer *buffer = NULL;
spin_lock_irqsave(&dev->queued_bufs_lock, flags); spin_lock_irqsave(&dev->buffer_list_lock, flags);
if (list_empty(&dev->queued_bufs)) if (list_empty(buffer_list))
goto leave; goto leave;
buf = list_entry(dev->queued_bufs.next, struct hackrf_frame_buf, list); buffer = list_entry(buffer_list->next, struct hackrf_buffer, list);
list_del(&buf->list); list_del(&buffer->list);
leave: leave:
spin_unlock_irqrestore(&dev->queued_bufs_lock, flags); spin_unlock_irqrestore(&dev->buffer_list_lock, flags);
return buf; return buffer;
} }
static unsigned int hackrf_convert_stream(struct hackrf_dev *dev, static void hackrf_copy_stream(struct hackrf_dev *dev, void *dst, void *src,
void *dst, void *src, unsigned int src_len) unsigned int src_len)
{ {
memcpy(dst, src, src_len); memcpy(dst, src, src_len);
...@@ -388,22 +474,21 @@ static unsigned int hackrf_convert_stream(struct hackrf_dev *dev, ...@@ -388,22 +474,21 @@ static unsigned int hackrf_convert_stream(struct hackrf_dev *dev,
/* total number of samples */ /* total number of samples */
dev->sample += src_len / 2; dev->sample += src_len / 2;
return src_len;
} }
/* /*
* This gets called for the bulk stream pipe. This is done in interrupt * This gets called for the bulk stream pipe. This is done in interrupt
* time, so it has to be fast, not crash, and not stall. Neat. * time, so it has to be fast, not crash, and not stall. Neat.
*/ */
static void hackrf_urb_complete(struct urb *urb) static void hackrf_urb_complete_in(struct urb *urb)
{ {
struct hackrf_dev *dev = urb->context; struct hackrf_dev *dev = urb->context;
struct hackrf_frame_buf *fbuf; struct usb_interface *intf = dev->intf;
struct hackrf_buffer *buffer;
unsigned int len;
dev_dbg_ratelimited(dev->dev, "status=%d length=%d/%d errors=%d\n", dev_dbg_ratelimited(&intf->dev, "status=%d length=%u/%u\n", urb->status,
urb->status, urb->actual_length, urb->actual_length, urb->transfer_buffer_length);
urb->transfer_buffer_length, urb->error_count);
switch (urb->status) { switch (urb->status) {
case 0: /* success */ case 0: /* success */
...@@ -414,33 +499,74 @@ static void hackrf_urb_complete(struct urb *urb) ...@@ -414,33 +499,74 @@ static void hackrf_urb_complete(struct urb *urb)
case -ESHUTDOWN: case -ESHUTDOWN:
return; return;
default: /* error */ default: /* error */
dev_err_ratelimited(dev->dev, "URB failed %d\n", urb->status); dev_err_ratelimited(&intf->dev, "URB failed %d\n", urb->status);
break; goto exit_usb_submit_urb;
} }
if (likely(urb->actual_length > 0)) { /* get buffer to write */
void *ptr; buffer = hackrf_get_next_buffer(dev, &dev->rx_buffer_list);
unsigned int len; if (unlikely(buffer == NULL)) {
/* get free framebuffer */
fbuf = hackrf_get_next_fill_buf(dev);
if (unlikely(fbuf == NULL)) {
dev->vb_full++; dev->vb_full++;
dev_notice_ratelimited(dev->dev, dev_notice_ratelimited(&intf->dev,
"videobuf is full, %d packets dropped\n", "buffer is full - %u packets dropped\n",
dev->vb_full); dev->vb_full);
goto skip; goto exit_usb_submit_urb;
} }
/* fill framebuffer */ len = min_t(unsigned long, vb2_plane_size(&buffer->vb.vb2_buf, 0),
ptr = vb2_plane_vaddr(&fbuf->vb.vb2_buf, 0);
len = hackrf_convert_stream(dev, ptr, urb->transfer_buffer,
urb->actual_length); urb->actual_length);
vb2_set_plane_payload(&fbuf->vb.vb2_buf, 0, len); hackrf_copy_stream(dev, vb2_plane_vaddr(&buffer->vb.vb2_buf, 0),
v4l2_get_timestamp(&fbuf->vb.timestamp); urb->transfer_buffer, len);
fbuf->vb.sequence = dev->sequence++; vb2_set_plane_payload(&buffer->vb.vb2_buf, 0, len);
vb2_buffer_done(&fbuf->vb.vb2_buf, VB2_BUF_STATE_DONE); buffer->vb.sequence = dev->sequence++;
v4l2_get_timestamp(&buffer->vb.timestamp);
vb2_buffer_done(&buffer->vb.vb2_buf, VB2_BUF_STATE_DONE);
exit_usb_submit_urb:
usb_submit_urb(urb, GFP_ATOMIC);
}
static void hackrf_urb_complete_out(struct urb *urb)
{
struct hackrf_dev *dev = urb->context;
struct usb_interface *intf = dev->intf;
struct hackrf_buffer *buffer;
unsigned int len;
dev_dbg_ratelimited(&intf->dev, "status=%d length=%u/%u\n", urb->status,
urb->actual_length, urb->transfer_buffer_length);
switch (urb->status) {
case 0: /* success */
case -ETIMEDOUT: /* NAK */
break;
case -ECONNRESET: /* kill */
case -ENOENT:
case -ESHUTDOWN:
return;
default: /* error */
dev_err_ratelimited(&intf->dev, "URB failed %d\n", urb->status);
}
/* get buffer to read */
buffer = hackrf_get_next_buffer(dev, &dev->tx_buffer_list);
if (unlikely(buffer == NULL)) {
dev->vb_empty++;
dev_notice_ratelimited(&intf->dev,
"buffer is empty - %u packets dropped\n",
dev->vb_empty);
urb->actual_length = 0;
goto exit_usb_submit_urb;
} }
skip:
len = min_t(unsigned long, urb->transfer_buffer_length,
vb2_get_plane_payload(&buffer->vb.vb2_buf, 0));
hackrf_copy_stream(dev, urb->transfer_buffer,
vb2_plane_vaddr(&buffer->vb.vb2_buf, 0), len);
urb->actual_length = len;
buffer->vb.sequence = dev->sequence++;
v4l2_get_timestamp(&buffer->vb.timestamp);
vb2_buffer_done(&buffer->vb.vb2_buf, VB2_BUF_STATE_DONE);
exit_usb_submit_urb:
usb_submit_urb(urb, GFP_ATOMIC); usb_submit_urb(urb, GFP_ATOMIC);
} }
...@@ -539,9 +665,19 @@ static int hackrf_free_urbs(struct hackrf_dev *dev) ...@@ -539,9 +665,19 @@ static int hackrf_free_urbs(struct hackrf_dev *dev)
return 0; return 0;
} }
static int hackrf_alloc_urbs(struct hackrf_dev *dev) static int hackrf_alloc_urbs(struct hackrf_dev *dev, bool rcv)
{ {
int i, j; int i, j;
unsigned int pipe;
usb_complete_t complete;
if (rcv) {
pipe = usb_rcvbulkpipe(dev->udev, 0x81);
complete = &hackrf_urb_complete_in;
} else {
pipe = usb_sndbulkpipe(dev->udev, 0x02);
complete = &hackrf_urb_complete_out;
}
/* allocate the URBs */ /* allocate the URBs */
for (i = 0; i < MAX_BULK_BUFS; i++) { for (i = 0; i < MAX_BULK_BUFS; i++) {
...@@ -555,10 +691,10 @@ static int hackrf_alloc_urbs(struct hackrf_dev *dev) ...@@ -555,10 +691,10 @@ static int hackrf_alloc_urbs(struct hackrf_dev *dev)
} }
usb_fill_bulk_urb(dev->urb_list[i], usb_fill_bulk_urb(dev->urb_list[i],
dev->udev, dev->udev,
usb_rcvbulkpipe(dev->udev, 0x81), pipe,
dev->buf_list[i], dev->buf_list[i],
BULK_BUFFER_SIZE, BULK_BUFFER_SIZE,
hackrf_urb_complete, dev); complete, dev);
dev->urb_list[i]->transfer_flags = URB_NO_TRANSFER_DMA_MAP; dev->urb_list[i]->transfer_flags = URB_NO_TRANSFER_DMA_MAP;
dev->urb_list[i]->transfer_dma = dev->dma_addr[i]; dev->urb_list[i]->transfer_dma = dev->dma_addr[i];
...@@ -568,25 +704,6 @@ static int hackrf_alloc_urbs(struct hackrf_dev *dev) ...@@ -568,25 +704,6 @@ static int hackrf_alloc_urbs(struct hackrf_dev *dev)
return 0; return 0;
} }
/* Must be called with vb_queue_lock hold */
static void hackrf_cleanup_queued_bufs(struct hackrf_dev *dev)
{
unsigned long flags;
dev_dbg(dev->dev, "\n");
spin_lock_irqsave(&dev->queued_bufs_lock, flags);
while (!list_empty(&dev->queued_bufs)) {
struct hackrf_frame_buf *buf;
buf = list_entry(dev->queued_bufs.next,
struct hackrf_frame_buf, list);
list_del(&buf->list);
vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR);
}
spin_unlock_irqrestore(&dev->queued_bufs_lock, flags);
}
/* The user yanked out the cable... */ /* The user yanked out the cable... */
static void hackrf_disconnect(struct usb_interface *intf) static void hackrf_disconnect(struct usb_interface *intf)
{ {
...@@ -600,7 +717,8 @@ static void hackrf_disconnect(struct usb_interface *intf) ...@@ -600,7 +717,8 @@ static void hackrf_disconnect(struct usb_interface *intf)
/* No need to keep the urbs around after disconnection */ /* No need to keep the urbs around after disconnection */
dev->udev = NULL; dev->udev = NULL;
v4l2_device_disconnect(&dev->v4l2_dev); v4l2_device_disconnect(&dev->v4l2_dev);
video_unregister_device(&dev->vdev); video_unregister_device(&dev->tx_vdev);
video_unregister_device(&dev->rx_vdev);
mutex_unlock(&dev->v4l2_lock); mutex_unlock(&dev->v4l2_lock);
mutex_unlock(&dev->vb_queue_lock); mutex_unlock(&dev->vb_queue_lock);
...@@ -608,6 +726,31 @@ static void hackrf_disconnect(struct usb_interface *intf) ...@@ -608,6 +726,31 @@ static void hackrf_disconnect(struct usb_interface *intf)
} }
/* Videobuf2 operations */ /* Videobuf2 operations */
static void hackrf_return_all_buffers(struct vb2_queue *vq,
enum vb2_buffer_state state)
{
struct hackrf_dev *dev = vb2_get_drv_priv(vq);
struct usb_interface *intf = dev->intf;
struct hackrf_buffer *buffer, *node;
struct list_head *buffer_list;
unsigned long flags;
dev_dbg(&intf->dev, "\n");
if (vq->type == V4L2_BUF_TYPE_SDR_CAPTURE)
buffer_list = &dev->rx_buffer_list;
else
buffer_list = &dev->tx_buffer_list;
spin_lock_irqsave(&dev->buffer_list_lock, flags);
list_for_each_entry_safe(buffer, node, buffer_list, list) {
dev_dbg(&intf->dev, "list_for_each_entry_safe\n");
vb2_buffer_done(&buffer->vb.vb2_buf, state);
list_del(&buffer->list);
}
spin_unlock_irqrestore(&dev->buffer_list_lock, flags);
}
static int hackrf_queue_setup(struct vb2_queue *vq, static int hackrf_queue_setup(struct vb2_queue *vq,
const void *parg, unsigned int *nbuffers, const void *parg, unsigned int *nbuffers,
unsigned int *nplanes, unsigned int sizes[], void *alloc_ctxs[]) unsigned int *nplanes, unsigned int sizes[], void *alloc_ctxs[])
...@@ -629,37 +772,61 @@ static int hackrf_queue_setup(struct vb2_queue *vq, ...@@ -629,37 +772,61 @@ static int hackrf_queue_setup(struct vb2_queue *vq,
static void hackrf_buf_queue(struct vb2_buffer *vb) static void hackrf_buf_queue(struct vb2_buffer *vb)
{ {
struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb); struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
struct hackrf_dev *dev = vb2_get_drv_priv(vb->vb2_queue); struct vb2_queue *vq = vb->vb2_queue;
struct hackrf_frame_buf *buf = struct hackrf_dev *dev = vb2_get_drv_priv(vq);
container_of(vbuf, struct hackrf_frame_buf, vb); struct hackrf_buffer *buffer = container_of(vbuf, struct hackrf_buffer, vb);
struct list_head *buffer_list;
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&dev->queued_bufs_lock, flags); dev_dbg_ratelimited(&dev->intf->dev, "\n");
list_add_tail(&buf->list, &dev->queued_bufs);
spin_unlock_irqrestore(&dev->queued_bufs_lock, flags); if (vq->type == V4L2_BUF_TYPE_SDR_CAPTURE)
buffer_list = &dev->rx_buffer_list;
else
buffer_list = &dev->tx_buffer_list;
spin_lock_irqsave(&dev->buffer_list_lock, flags);
list_add_tail(&buffer->list, buffer_list);
spin_unlock_irqrestore(&dev->buffer_list_lock, flags);
} }
static int hackrf_start_streaming(struct vb2_queue *vq, unsigned int count) static int hackrf_start_streaming(struct vb2_queue *vq, unsigned int count)
{ {
struct hackrf_dev *dev = vb2_get_drv_priv(vq); struct hackrf_dev *dev = vb2_get_drv_priv(vq);
struct usb_interface *intf = dev->intf;
int ret; int ret;
unsigned int mode;
dev_dbg(dev->dev, "\n"); dev_dbg(&intf->dev, "count=%i\n", count);
if (!dev->udev)
return -ENODEV;
mutex_lock(&dev->v4l2_lock); mutex_lock(&dev->v4l2_lock);
dev->sequence = 0; /* Allow only RX or TX, not both same time */
if (vq->type == V4L2_BUF_TYPE_SDR_CAPTURE) {
if (test_bit(TX_ON, &dev->flags)) {
ret = -EBUSY;
goto err_hackrf_return_all_buffers;
}
mode = 1;
set_bit(RX_ON, &dev->flags);
} else {
if (test_bit(RX_ON, &dev->flags)) {
ret = -EBUSY;
goto err_hackrf_return_all_buffers;
}
mode = 2;
set_bit(TX_ON, &dev->flags);
}
set_bit(POWER_ON, &dev->flags); dev->sequence = 0;
ret = hackrf_alloc_stream_bufs(dev); ret = hackrf_alloc_stream_bufs(dev);
if (ret) if (ret)
goto err; goto err;
ret = hackrf_alloc_urbs(dev); ret = hackrf_alloc_urbs(dev, (mode == 1));
if (ret) if (ret)
goto err; goto err;
...@@ -672,39 +839,32 @@ static int hackrf_start_streaming(struct vb2_queue *vq, unsigned int count) ...@@ -672,39 +839,32 @@ static int hackrf_start_streaming(struct vb2_queue *vq, unsigned int count)
goto err; goto err;
/* start hardware streaming */ /* start hardware streaming */
ret = hackrf_ctrl_msg(dev, CMD_SET_TRANSCEIVER_MODE, 1, 0, NULL, 0); ret = hackrf_ctrl_msg(dev, CMD_SET_TRANSCEIVER_MODE, mode, 0, NULL, 0);
if (ret) if (ret)
goto err; goto err;
goto exit_mutex_unlock; mutex_unlock(&dev->v4l2_lock);
return 0;
err: err:
hackrf_kill_urbs(dev); hackrf_kill_urbs(dev);
hackrf_free_urbs(dev); hackrf_free_urbs(dev);
hackrf_free_stream_bufs(dev); hackrf_free_stream_bufs(dev);
clear_bit(POWER_ON, &dev->flags); clear_bit(RX_ON, &dev->flags);
clear_bit(TX_ON, &dev->flags);
/* return all queued buffers to vb2 */ err_hackrf_return_all_buffers:
{ hackrf_return_all_buffers(vq, VB2_BUF_STATE_QUEUED);
struct hackrf_frame_buf *buf, *tmp;
list_for_each_entry_safe(buf, tmp, &dev->queued_bufs, list) {
list_del(&buf->list);
vb2_buffer_done(&buf->vb.vb2_buf,
VB2_BUF_STATE_QUEUED);
}
}
exit_mutex_unlock:
mutex_unlock(&dev->v4l2_lock); mutex_unlock(&dev->v4l2_lock);
dev_dbg(&intf->dev, "failed=%d\n", ret);
return ret; return ret;
} }
static void hackrf_stop_streaming(struct vb2_queue *vq) static void hackrf_stop_streaming(struct vb2_queue *vq)
{ {
struct hackrf_dev *dev = vb2_get_drv_priv(vq); struct hackrf_dev *dev = vb2_get_drv_priv(vq);
struct usb_interface *intf = dev->intf;
dev_dbg(dev->dev, "\n"); dev_dbg(&intf->dev, "\n");
mutex_lock(&dev->v4l2_lock); mutex_lock(&dev->v4l2_lock);
...@@ -715,9 +875,12 @@ static void hackrf_stop_streaming(struct vb2_queue *vq) ...@@ -715,9 +875,12 @@ static void hackrf_stop_streaming(struct vb2_queue *vq)
hackrf_free_urbs(dev); hackrf_free_urbs(dev);
hackrf_free_stream_bufs(dev); hackrf_free_stream_bufs(dev);
hackrf_cleanup_queued_bufs(dev); hackrf_return_all_buffers(vq, VB2_BUF_STATE_ERROR);
clear_bit(POWER_ON, &dev->flags); if (vq->type == V4L2_BUF_TYPE_SDR_CAPTURE)
clear_bit(RX_ON, &dev->flags);
else
clear_bit(TX_ON, &dev->flags);
mutex_unlock(&dev->v4l2_lock); mutex_unlock(&dev->v4l2_lock);
} }
...@@ -735,29 +898,46 @@ static int hackrf_querycap(struct file *file, void *fh, ...@@ -735,29 +898,46 @@ static int hackrf_querycap(struct file *file, void *fh,
struct v4l2_capability *cap) struct v4l2_capability *cap)
{ {
struct hackrf_dev *dev = video_drvdata(file); struct hackrf_dev *dev = video_drvdata(file);
struct usb_interface *intf = dev->intf;
struct video_device *vdev = video_devdata(file);
dev_dbg(dev->dev, "\n"); dev_dbg(&intf->dev, "\n");
if (vdev->vfl_dir == VFL_DIR_RX)
cap->device_caps = V4L2_CAP_SDR_CAPTURE | V4L2_CAP_TUNER |
V4L2_CAP_STREAMING | V4L2_CAP_READWRITE;
else
cap->device_caps = V4L2_CAP_SDR_OUTPUT | V4L2_CAP_MODULATOR |
V4L2_CAP_STREAMING | V4L2_CAP_READWRITE;
cap->capabilities = V4L2_CAP_SDR_CAPTURE | V4L2_CAP_TUNER |
V4L2_CAP_SDR_OUTPUT | V4L2_CAP_MODULATOR |
V4L2_CAP_STREAMING | V4L2_CAP_READWRITE |
V4L2_CAP_DEVICE_CAPS;
strlcpy(cap->driver, KBUILD_MODNAME, sizeof(cap->driver)); strlcpy(cap->driver, KBUILD_MODNAME, sizeof(cap->driver));
strlcpy(cap->card, dev->vdev.name, sizeof(cap->card)); strlcpy(cap->card, dev->rx_vdev.name, sizeof(cap->card));
usb_make_path(dev->udev, cap->bus_info, sizeof(cap->bus_info)); usb_make_path(dev->udev, cap->bus_info, sizeof(cap->bus_info));
cap->device_caps = V4L2_CAP_SDR_CAPTURE | V4L2_CAP_STREAMING |
V4L2_CAP_READWRITE | V4L2_CAP_TUNER;
cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
return 0; return 0;
} }
static int hackrf_s_fmt_sdr_cap(struct file *file, void *priv, static int hackrf_s_fmt_sdr(struct file *file, void *priv,
struct v4l2_format *f) struct v4l2_format *f)
{ {
struct hackrf_dev *dev = video_drvdata(file); struct hackrf_dev *dev = video_drvdata(file);
struct vb2_queue *q = &dev->vb_queue; struct video_device *vdev = video_devdata(file);
struct vb2_queue *q;
int i; int i;
dev_dbg(dev->dev, "pixelformat fourcc %4.4s\n", dev_dbg(dev->dev, "pixelformat fourcc %4.4s\n",
(char *)&f->fmt.sdr.pixelformat); (char *)&f->fmt.sdr.pixelformat);
if (vdev->vfl_dir == VFL_DIR_RX)
q = &dev->rx_vb2_queue;
else
q = &dev->tx_vb2_queue;
if (vb2_is_busy(q)) if (vb2_is_busy(q))
return -EBUSY; return -EBUSY;
...@@ -779,7 +959,7 @@ static int hackrf_s_fmt_sdr_cap(struct file *file, void *priv, ...@@ -779,7 +959,7 @@ static int hackrf_s_fmt_sdr_cap(struct file *file, void *priv,
return 0; return 0;
} }
static int hackrf_g_fmt_sdr_cap(struct file *file, void *priv, static int hackrf_g_fmt_sdr(struct file *file, void *priv,
struct v4l2_format *f) struct v4l2_format *f)
{ {
struct hackrf_dev *dev = video_drvdata(file); struct hackrf_dev *dev = video_drvdata(file);
...@@ -794,7 +974,7 @@ static int hackrf_g_fmt_sdr_cap(struct file *file, void *priv, ...@@ -794,7 +974,7 @@ static int hackrf_g_fmt_sdr_cap(struct file *file, void *priv,
return 0; return 0;
} }
static int hackrf_try_fmt_sdr_cap(struct file *file, void *priv, static int hackrf_try_fmt_sdr(struct file *file, void *priv,
struct v4l2_format *f) struct v4l2_format *f)
{ {
struct hackrf_dev *dev = video_drvdata(file); struct hackrf_dev *dev = video_drvdata(file);
...@@ -817,7 +997,7 @@ static int hackrf_try_fmt_sdr_cap(struct file *file, void *priv, ...@@ -817,7 +997,7 @@ static int hackrf_try_fmt_sdr_cap(struct file *file, void *priv,
return 0; return 0;
} }
static int hackrf_enum_fmt_sdr_cap(struct file *file, void *priv, static int hackrf_enum_fmt_sdr(struct file *file, void *priv,
struct v4l2_fmtdesc *f) struct v4l2_fmtdesc *f)
{ {
struct hackrf_dev *dev = video_drvdata(file); struct hackrf_dev *dev = video_drvdata(file);
...@@ -860,17 +1040,56 @@ static int hackrf_g_tuner(struct file *file, void *priv, struct v4l2_tuner *v) ...@@ -860,17 +1040,56 @@ static int hackrf_g_tuner(struct file *file, void *priv, struct v4l2_tuner *v)
if (v->index == 0) { if (v->index == 0) {
strlcpy(v->name, "HackRF ADC", sizeof(v->name)); strlcpy(v->name, "HackRF ADC", sizeof(v->name));
v->type = V4L2_TUNER_ADC; v->type = V4L2_TUNER_SDR;
v->capability = V4L2_TUNER_CAP_1HZ | V4L2_TUNER_CAP_FREQ_BANDS; v->capability = V4L2_TUNER_CAP_1HZ | V4L2_TUNER_CAP_FREQ_BANDS;
v->rangelow = bands_adc[0].rangelow; v->rangelow = bands_adc_dac[0].rangelow;
v->rangehigh = bands_adc[0].rangehigh; v->rangehigh = bands_adc_dac[0].rangehigh;
ret = 0; ret = 0;
} else if (v->index == 1) { } else if (v->index == 1) {
strlcpy(v->name, "HackRF RF", sizeof(v->name)); strlcpy(v->name, "HackRF RF", sizeof(v->name));
v->type = V4L2_TUNER_RF; v->type = V4L2_TUNER_RF;
v->capability = V4L2_TUNER_CAP_1HZ | V4L2_TUNER_CAP_FREQ_BANDS; v->capability = V4L2_TUNER_CAP_1HZ | V4L2_TUNER_CAP_FREQ_BANDS;
v->rangelow = bands_rf[0].rangelow; v->rangelow = bands_rx_tx[0].rangelow;
v->rangehigh = bands_rf[0].rangehigh; v->rangehigh = bands_rx_tx[0].rangehigh;
ret = 0;
} else {
ret = -EINVAL;
}
return ret;
}
static int hackrf_s_modulator(struct file *file, void *fh,
const struct v4l2_modulator *a)
{
struct hackrf_dev *dev = video_drvdata(file);
dev_dbg(dev->dev, "index=%d\n", a->index);
return a->index > 1 ? -EINVAL : 0;
}
static int hackrf_g_modulator(struct file *file, void *fh,
struct v4l2_modulator *a)
{
struct hackrf_dev *dev = video_drvdata(file);
int ret;
dev_dbg(dev->dev, "index=%d\n", a->index);
if (a->index == 0) {
strlcpy(a->name, "HackRF DAC", sizeof(a->name));
a->type = V4L2_TUNER_SDR;
a->capability = V4L2_TUNER_CAP_1HZ | V4L2_TUNER_CAP_FREQ_BANDS;
a->rangelow = bands_adc_dac[0].rangelow;
a->rangehigh = bands_adc_dac[0].rangehigh;
ret = 0;
} else if (a->index == 1) {
strlcpy(a->name, "HackRF RF", sizeof(a->name));
a->type = V4L2_TUNER_RF;
a->capability = V4L2_TUNER_CAP_1HZ | V4L2_TUNER_CAP_FREQ_BANDS;
a->rangelow = bands_rx_tx[0].rangelow;
a->rangehigh = bands_rx_tx[0].rangehigh;
ret = 0; ret = 0;
} else { } else {
ret = -EINVAL; ret = -EINVAL;
...@@ -884,19 +1103,33 @@ static int hackrf_s_frequency(struct file *file, void *priv, ...@@ -884,19 +1103,33 @@ static int hackrf_s_frequency(struct file *file, void *priv,
{ {
struct hackrf_dev *dev = video_drvdata(file); struct hackrf_dev *dev = video_drvdata(file);
struct usb_interface *intf = dev->intf; struct usb_interface *intf = dev->intf;
struct video_device *vdev = video_devdata(file);
int ret; int ret;
unsigned int uitmp;
dev_dbg(&intf->dev, "tuner=%d type=%d frequency=%u\n", dev_dbg(&intf->dev, "tuner=%d type=%d frequency=%u\n",
f->tuner, f->type, f->frequency); f->tuner, f->type, f->frequency);
if (f->tuner == 0) { if (f->tuner == 0) {
dev->f_adc = clamp_t(unsigned int, f->frequency, uitmp = clamp(f->frequency, bands_adc_dac[0].rangelow,
bands_adc[0].rangelow, bands_adc[0].rangehigh); bands_adc_dac[0].rangehigh);
set_bit(SAMPLE_RATE_SET, &dev->flags); if (vdev->vfl_dir == VFL_DIR_RX) {
dev->f_adc = uitmp;
set_bit(RX_ADC_FREQUENCY, &dev->flags);
} else {
dev->f_dac = uitmp;
set_bit(TX_DAC_FREQUENCY, &dev->flags);
}
} else if (f->tuner == 1) { } else if (f->tuner == 1) {
dev->f_rf = clamp_t(unsigned int, f->frequency, uitmp = clamp(f->frequency, bands_rx_tx[0].rangelow,
bands_rf[0].rangelow, bands_rf[0].rangehigh); bands_rx_tx[0].rangehigh);
if (vdev->vfl_dir == VFL_DIR_RX) {
dev->f_rx = uitmp;
set_bit(RX_RF_FREQUENCY, &dev->flags); set_bit(RX_RF_FREQUENCY, &dev->flags);
} else {
dev->f_tx = uitmp;
set_bit(TX_RF_FREQUENCY, &dev->flags);
}
} else { } else {
ret = -EINVAL; ret = -EINVAL;
goto err; goto err;
...@@ -916,22 +1149,32 @@ static int hackrf_g_frequency(struct file *file, void *priv, ...@@ -916,22 +1149,32 @@ static int hackrf_g_frequency(struct file *file, void *priv,
struct v4l2_frequency *f) struct v4l2_frequency *f)
{ {
struct hackrf_dev *dev = video_drvdata(file); struct hackrf_dev *dev = video_drvdata(file);
struct usb_interface *intf = dev->intf;
struct video_device *vdev = video_devdata(file);
int ret; int ret;
dev_dbg(dev->dev, "tuner=%d type=%d\n", f->tuner, f->type); dev_dbg(dev->dev, "tuner=%d type=%d\n", f->tuner, f->type);
if (f->tuner == 0) { if (f->tuner == 0) {
f->type = V4L2_TUNER_ADC; f->type = V4L2_TUNER_SDR;
if (vdev->vfl_dir == VFL_DIR_RX)
f->frequency = dev->f_adc; f->frequency = dev->f_adc;
ret = 0; else
f->frequency = dev->f_dac;
} else if (f->tuner == 1) { } else if (f->tuner == 1) {
f->type = V4L2_TUNER_RF; f->type = V4L2_TUNER_RF;
f->frequency = dev->f_rf; if (vdev->vfl_dir == VFL_DIR_RX)
ret = 0; f->frequency = dev->f_rx;
else
f->frequency = dev->f_tx;
} else { } else {
ret = -EINVAL; ret = -EINVAL;
goto err;
} }
return 0;
err:
dev_dbg(&intf->dev, "failed=%d\n", ret);
return ret; return ret;
} }
...@@ -945,17 +1188,17 @@ static int hackrf_enum_freq_bands(struct file *file, void *priv, ...@@ -945,17 +1188,17 @@ static int hackrf_enum_freq_bands(struct file *file, void *priv,
band->tuner, band->type, band->index); band->tuner, band->type, band->index);
if (band->tuner == 0) { if (band->tuner == 0) {
if (band->index >= ARRAY_SIZE(bands_adc)) { if (band->index >= ARRAY_SIZE(bands_adc_dac)) {
ret = -EINVAL; ret = -EINVAL;
} else { } else {
*band = bands_adc[band->index]; *band = bands_adc_dac[band->index];
ret = 0; ret = 0;
} }
} else if (band->tuner == 1) { } else if (band->tuner == 1) {
if (band->index >= ARRAY_SIZE(bands_rf)) { if (band->index >= ARRAY_SIZE(bands_rx_tx)) {
ret = -EINVAL; ret = -EINVAL;
} else { } else {
*band = bands_rf[band->index]; *band = bands_rx_tx[band->index];
ret = 0; ret = 0;
} }
} else { } else {
...@@ -968,10 +1211,15 @@ static int hackrf_enum_freq_bands(struct file *file, void *priv, ...@@ -968,10 +1211,15 @@ static int hackrf_enum_freq_bands(struct file *file, void *priv,
static const struct v4l2_ioctl_ops hackrf_ioctl_ops = { static const struct v4l2_ioctl_ops hackrf_ioctl_ops = {
.vidioc_querycap = hackrf_querycap, .vidioc_querycap = hackrf_querycap,
.vidioc_s_fmt_sdr_cap = hackrf_s_fmt_sdr_cap, .vidioc_s_fmt_sdr_cap = hackrf_s_fmt_sdr,
.vidioc_g_fmt_sdr_cap = hackrf_g_fmt_sdr_cap, .vidioc_g_fmt_sdr_cap = hackrf_g_fmt_sdr,
.vidioc_enum_fmt_sdr_cap = hackrf_enum_fmt_sdr_cap, .vidioc_enum_fmt_sdr_cap = hackrf_enum_fmt_sdr,
.vidioc_try_fmt_sdr_cap = hackrf_try_fmt_sdr_cap, .vidioc_try_fmt_sdr_cap = hackrf_try_fmt_sdr,
.vidioc_s_fmt_sdr_out = hackrf_s_fmt_sdr,
.vidioc_g_fmt_sdr_out = hackrf_g_fmt_sdr,
.vidioc_enum_fmt_sdr_out = hackrf_enum_fmt_sdr,
.vidioc_try_fmt_sdr_out = hackrf_try_fmt_sdr,
.vidioc_reqbufs = vb2_ioctl_reqbufs, .vidioc_reqbufs = vb2_ioctl_reqbufs,
.vidioc_create_bufs = vb2_ioctl_create_bufs, .vidioc_create_bufs = vb2_ioctl_create_bufs,
...@@ -979,6 +1227,7 @@ static const struct v4l2_ioctl_ops hackrf_ioctl_ops = { ...@@ -979,6 +1227,7 @@ static const struct v4l2_ioctl_ops hackrf_ioctl_ops = {
.vidioc_querybuf = vb2_ioctl_querybuf, .vidioc_querybuf = vb2_ioctl_querybuf,
.vidioc_qbuf = vb2_ioctl_qbuf, .vidioc_qbuf = vb2_ioctl_qbuf,
.vidioc_dqbuf = vb2_ioctl_dqbuf, .vidioc_dqbuf = vb2_ioctl_dqbuf,
.vidioc_expbuf = vb2_ioctl_expbuf,
.vidioc_streamon = vb2_ioctl_streamon, .vidioc_streamon = vb2_ioctl_streamon,
.vidioc_streamoff = vb2_ioctl_streamoff, .vidioc_streamoff = vb2_ioctl_streamoff,
...@@ -986,6 +1235,9 @@ static const struct v4l2_ioctl_ops hackrf_ioctl_ops = { ...@@ -986,6 +1235,9 @@ static const struct v4l2_ioctl_ops hackrf_ioctl_ops = {
.vidioc_s_tuner = hackrf_s_tuner, .vidioc_s_tuner = hackrf_s_tuner,
.vidioc_g_tuner = hackrf_g_tuner, .vidioc_g_tuner = hackrf_g_tuner,
.vidioc_s_modulator = hackrf_s_modulator,
.vidioc_g_modulator = hackrf_g_modulator,
.vidioc_s_frequency = hackrf_s_frequency, .vidioc_s_frequency = hackrf_s_frequency,
.vidioc_g_frequency = hackrf_g_frequency, .vidioc_g_frequency = hackrf_g_frequency,
.vidioc_enum_freq_bands = hackrf_enum_freq_bands, .vidioc_enum_freq_bands = hackrf_enum_freq_bands,
...@@ -1000,6 +1252,7 @@ static const struct v4l2_file_operations hackrf_fops = { ...@@ -1000,6 +1252,7 @@ static const struct v4l2_file_operations hackrf_fops = {
.open = v4l2_fh_open, .open = v4l2_fh_open,
.release = vb2_fop_release, .release = vb2_fop_release,
.read = vb2_fop_read, .read = vb2_fop_read,
.write = vb2_fop_write,
.poll = vb2_fop_poll, .poll = vb2_fop_poll,
.mmap = vb2_fop_mmap, .mmap = vb2_fop_mmap,
.unlocked_ioctl = video_ioctl2, .unlocked_ioctl = video_ioctl2,
...@@ -1016,15 +1269,18 @@ static void hackrf_video_release(struct v4l2_device *v) ...@@ -1016,15 +1269,18 @@ static void hackrf_video_release(struct v4l2_device *v)
{ {
struct hackrf_dev *dev = container_of(v, struct hackrf_dev, v4l2_dev); struct hackrf_dev *dev = container_of(v, struct hackrf_dev, v4l2_dev);
v4l2_ctrl_handler_free(&dev->hdl); dev_dbg(dev->dev, "\n");
v4l2_ctrl_handler_free(&dev->rx_ctrl_handler);
v4l2_ctrl_handler_free(&dev->tx_ctrl_handler);
v4l2_device_unregister(&dev->v4l2_dev); v4l2_device_unregister(&dev->v4l2_dev);
kfree(dev); kfree(dev);
} }
static int hackrf_s_ctrl(struct v4l2_ctrl *ctrl) static int hackrf_s_ctrl_rx(struct v4l2_ctrl *ctrl)
{ {
struct hackrf_dev *dev = container_of(ctrl->handler, struct hackrf_dev *dev = container_of(ctrl->handler,
struct hackrf_dev, hdl); struct hackrf_dev, rx_ctrl_handler);
struct usb_interface *intf = dev->intf; struct usb_interface *intf = dev->intf;
int ret; int ret;
...@@ -1059,8 +1315,47 @@ static int hackrf_s_ctrl(struct v4l2_ctrl *ctrl) ...@@ -1059,8 +1315,47 @@ static int hackrf_s_ctrl(struct v4l2_ctrl *ctrl)
return ret; return ret;
} }
static const struct v4l2_ctrl_ops hackrf_ctrl_ops = { static int hackrf_s_ctrl_tx(struct v4l2_ctrl *ctrl)
.s_ctrl = hackrf_s_ctrl, {
struct hackrf_dev *dev = container_of(ctrl->handler,
struct hackrf_dev, tx_ctrl_handler);
struct usb_interface *intf = dev->intf;
int ret;
switch (ctrl->id) {
case V4L2_CID_RF_TUNER_BANDWIDTH_AUTO:
case V4L2_CID_RF_TUNER_BANDWIDTH:
set_bit(TX_BANDWIDTH, &dev->flags);
break;
case V4L2_CID_RF_TUNER_LNA_GAIN:
set_bit(TX_LNA_GAIN, &dev->flags);
break;
case V4L2_CID_RF_TUNER_RF_GAIN:
set_bit(TX_RF_GAIN, &dev->flags);
break;
default:
dev_dbg(&intf->dev, "unknown ctrl: id=%d name=%s\n",
ctrl->id, ctrl->name);
ret = -EINVAL;
goto err;
}
ret = hackrf_set_params(dev);
if (ret)
goto err;
return 0;
err:
dev_dbg(&intf->dev, "failed=%d\n", ret);
return ret;
}
static const struct v4l2_ctrl_ops hackrf_ctrl_ops_rx = {
.s_ctrl = hackrf_s_ctrl_rx,
};
static const struct v4l2_ctrl_ops hackrf_ctrl_ops_tx = {
.s_ctrl = hackrf_s_ctrl_tx,
}; };
static int hackrf_probe(struct usb_interface *intf, static int hackrf_probe(struct usb_interface *intf,
...@@ -1071,20 +1366,29 @@ static int hackrf_probe(struct usb_interface *intf, ...@@ -1071,20 +1366,29 @@ static int hackrf_probe(struct usb_interface *intf,
u8 u8tmp, buf[BUF_SIZE]; u8 u8tmp, buf[BUF_SIZE];
dev = kzalloc(sizeof(*dev), GFP_KERNEL); dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (dev == NULL) if (!dev) {
return -ENOMEM; ret = -ENOMEM;
goto err;
}
mutex_init(&dev->v4l2_lock); mutex_init(&dev->v4l2_lock);
mutex_init(&dev->vb_queue_lock); mutex_init(&dev->vb_queue_lock);
spin_lock_init(&dev->queued_bufs_lock); spin_lock_init(&dev->buffer_list_lock);
INIT_LIST_HEAD(&dev->queued_bufs); INIT_LIST_HEAD(&dev->rx_buffer_list);
INIT_LIST_HEAD(&dev->tx_buffer_list);
dev->intf = intf; dev->intf = intf;
dev->dev = &intf->dev; dev->dev = &intf->dev;
dev->udev = interface_to_usbdev(intf); dev->udev = interface_to_usbdev(intf);
dev->f_adc = bands_adc[0].rangelow;
dev->f_rf = bands_rf[0].rangelow;
dev->pixelformat = formats[0].pixelformat; dev->pixelformat = formats[0].pixelformat;
dev->buffersize = formats[0].buffersize; dev->buffersize = formats[0].buffersize;
dev->f_adc = bands_adc_dac[0].rangelow;
dev->f_dac = bands_adc_dac[0].rangelow;
dev->f_rx = bands_rx_tx[0].rangelow;
dev->f_tx = bands_rx_tx[0].rangelow;
set_bit(RX_ADC_FREQUENCY, &dev->flags);
set_bit(TX_DAC_FREQUENCY, &dev->flags);
set_bit(RX_RF_FREQUENCY, &dev->flags);
set_bit(TX_RF_FREQUENCY, &dev->flags);
/* Detect device */ /* Detect device */
ret = hackrf_ctrl_msg(dev, CMD_BOARD_ID_READ, 0, 0, &u8tmp, 1); ret = hackrf_ctrl_msg(dev, CMD_BOARD_ID_READ, 0, 0, &u8tmp, 1);
...@@ -1093,85 +1397,143 @@ static int hackrf_probe(struct usb_interface *intf, ...@@ -1093,85 +1397,143 @@ static int hackrf_probe(struct usb_interface *intf,
buf, BUF_SIZE); buf, BUF_SIZE);
if (ret) { if (ret) {
dev_err(dev->dev, "Could not detect board\n"); dev_err(dev->dev, "Could not detect board\n");
goto err_free_mem; goto err_kfree;
} }
buf[BUF_SIZE - 1] = '\0'; buf[BUF_SIZE - 1] = '\0';
dev_info(dev->dev, "Board ID: %02x\n", u8tmp); dev_info(dev->dev, "Board ID: %02x\n", u8tmp);
dev_info(dev->dev, "Firmware version: %s\n", buf); dev_info(dev->dev, "Firmware version: %s\n", buf);
/* Init videobuf2 queue structure */ /* Init vb2 queue structure for receiver */
dev->vb_queue.type = V4L2_BUF_TYPE_SDR_CAPTURE; dev->rx_vb2_queue.type = V4L2_BUF_TYPE_SDR_CAPTURE;
dev->vb_queue.io_modes = VB2_MMAP | VB2_USERPTR | VB2_READ; dev->rx_vb2_queue.io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF |
dev->vb_queue.drv_priv = dev; VB2_READ;
dev->vb_queue.buf_struct_size = sizeof(struct hackrf_frame_buf); dev->rx_vb2_queue.ops = &hackrf_vb2_ops;
dev->vb_queue.ops = &hackrf_vb2_ops; dev->rx_vb2_queue.mem_ops = &vb2_vmalloc_memops;
dev->vb_queue.mem_ops = &vb2_vmalloc_memops; dev->rx_vb2_queue.drv_priv = dev;
dev->vb_queue.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; dev->rx_vb2_queue.buf_struct_size = sizeof(struct hackrf_buffer);
ret = vb2_queue_init(&dev->vb_queue); dev->rx_vb2_queue.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
ret = vb2_queue_init(&dev->rx_vb2_queue);
if (ret) { if (ret) {
dev_err(dev->dev, "Could not initialize vb2 queue\n"); dev_err(dev->dev, "Could not initialize rx vb2 queue\n");
goto err_free_mem; goto err_kfree;
} }
/* Init video_device structure */ /* Init vb2 queue structure for transmitter */
dev->vdev = hackrf_template; dev->tx_vb2_queue.type = V4L2_BUF_TYPE_SDR_OUTPUT;
dev->vdev.queue = &dev->vb_queue; dev->tx_vb2_queue.io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF |
dev->vdev.queue->lock = &dev->vb_queue_lock; VB2_WRITE;
video_set_drvdata(&dev->vdev, dev); dev->tx_vb2_queue.ops = &hackrf_vb2_ops;
dev->tx_vb2_queue.mem_ops = &vb2_vmalloc_memops;
dev->tx_vb2_queue.drv_priv = dev;
dev->tx_vb2_queue.buf_struct_size = sizeof(struct hackrf_buffer);
dev->tx_vb2_queue.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
ret = vb2_queue_init(&dev->tx_vb2_queue);
if (ret) {
dev_err(dev->dev, "Could not initialize tx vb2 queue\n");
goto err_kfree;
}
/* Register controls for receiver */
v4l2_ctrl_handler_init(&dev->rx_ctrl_handler, 5);
dev->rx_bandwidth_auto = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_BANDWIDTH_AUTO,
0, 1, 0, 1);
dev->rx_bandwidth = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_BANDWIDTH,
1750000, 28000000, 50000, 1750000);
v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
dev->rx_rf_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_RF_GAIN, 0, 12, 12, 0);
dev->rx_lna_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_LNA_GAIN, 0, 40, 8, 0);
dev->rx_if_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_IF_GAIN, 0, 62, 2, 0);
if (dev->rx_ctrl_handler.error) {
ret = dev->rx_ctrl_handler.error;
dev_err(dev->dev, "Could not initialize controls\n");
goto err_v4l2_ctrl_handler_free_rx;
}
v4l2_ctrl_handler_setup(&dev->rx_ctrl_handler);
/* Register controls for transmitter */
v4l2_ctrl_handler_init(&dev->tx_ctrl_handler, 4);
dev->tx_bandwidth_auto = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
&hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_BANDWIDTH_AUTO,
0, 1, 0, 1);
dev->tx_bandwidth = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
&hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_BANDWIDTH,
1750000, 28000000, 50000, 1750000);
v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
dev->tx_lna_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
&hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_LNA_GAIN, 0, 47, 1, 0);
dev->tx_rf_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
&hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_RF_GAIN, 0, 15, 15, 0);
if (dev->tx_ctrl_handler.error) {
ret = dev->tx_ctrl_handler.error;
dev_err(dev->dev, "Could not initialize controls\n");
goto err_v4l2_ctrl_handler_free_tx;
}
v4l2_ctrl_handler_setup(&dev->tx_ctrl_handler);
/* Register the v4l2_device structure */ /* Register the v4l2_device structure */
dev->v4l2_dev.release = hackrf_video_release; dev->v4l2_dev.release = hackrf_video_release;
ret = v4l2_device_register(&intf->dev, &dev->v4l2_dev); ret = v4l2_device_register(&intf->dev, &dev->v4l2_dev);
if (ret) { if (ret) {
dev_err(dev->dev, "Failed to register v4l2-device (%d)\n", ret); dev_err(dev->dev, "Failed to register v4l2-device (%d)\n", ret);
goto err_free_mem; goto err_v4l2_ctrl_handler_free_tx;
} }
/* Register controls */ /* Init video_device structure for receiver */
v4l2_ctrl_handler_init(&dev->hdl, 5); dev->rx_vdev = hackrf_template;
dev->bandwidth_auto = v4l2_ctrl_new_std(&dev->hdl, &hackrf_ctrl_ops, dev->rx_vdev.queue = &dev->rx_vb2_queue;
V4L2_CID_RF_TUNER_BANDWIDTH_AUTO, 0, 1, 1, 1); dev->rx_vdev.queue->lock = &dev->vb_queue_lock;
dev->bandwidth = v4l2_ctrl_new_std(&dev->hdl, &hackrf_ctrl_ops, dev->rx_vdev.v4l2_dev = &dev->v4l2_dev;
V4L2_CID_RF_TUNER_BANDWIDTH, dev->rx_vdev.ctrl_handler = &dev->rx_ctrl_handler;
1750000, 28000000, 50000, 1750000); dev->rx_vdev.lock = &dev->v4l2_lock;
v4l2_ctrl_auto_cluster(2, &dev->bandwidth_auto, 0, false); dev->rx_vdev.vfl_dir = VFL_DIR_RX;
dev->rf_gain = v4l2_ctrl_new_std(&dev->hdl, &hackrf_ctrl_ops, video_set_drvdata(&dev->rx_vdev, dev);
V4L2_CID_RF_TUNER_RF_GAIN, 0, 12, 12, 0); ret = video_register_device(&dev->rx_vdev, VFL_TYPE_SDR, -1);
dev->lna_gain = v4l2_ctrl_new_std(&dev->hdl, &hackrf_ctrl_ops, if (ret) {
V4L2_CID_RF_TUNER_LNA_GAIN, 0, 40, 8, 0); dev_err(dev->dev,
dev->if_gain = v4l2_ctrl_new_std(&dev->hdl, &hackrf_ctrl_ops, "Failed to register as video device (%d)\n", ret);
V4L2_CID_RF_TUNER_IF_GAIN, 0, 62, 2, 0); goto err_v4l2_device_unregister;
if (dev->hdl.error) {
ret = dev->hdl.error;
dev_err(dev->dev, "Could not initialize controls\n");
goto err_free_controls;
} }
dev_info(dev->dev, "Registered as %s\n",
v4l2_ctrl_handler_setup(&dev->hdl); video_device_node_name(&dev->rx_vdev));
dev->v4l2_dev.ctrl_handler = &dev->hdl; /* Init video_device structure for transmitter */
dev->vdev.v4l2_dev = &dev->v4l2_dev; dev->tx_vdev = hackrf_template;
dev->vdev.lock = &dev->v4l2_lock; dev->tx_vdev.queue = &dev->tx_vb2_queue;
dev->tx_vdev.queue->lock = &dev->vb_queue_lock;
ret = video_register_device(&dev->vdev, VFL_TYPE_SDR, -1); dev->tx_vdev.v4l2_dev = &dev->v4l2_dev;
dev->tx_vdev.ctrl_handler = &dev->tx_ctrl_handler;
dev->tx_vdev.lock = &dev->v4l2_lock;
dev->tx_vdev.vfl_dir = VFL_DIR_TX;
video_set_drvdata(&dev->tx_vdev, dev);
ret = video_register_device(&dev->tx_vdev, VFL_TYPE_SDR, -1);
if (ret) { if (ret) {
dev_err(dev->dev, "Failed to register as video device (%d)\n", dev_err(dev->dev,
ret); "Failed to register as video device (%d)\n", ret);
goto err_unregister_v4l2_dev; goto err_video_unregister_device_rx;
} }
dev_info(dev->dev, "Registered as %s\n", dev_info(dev->dev, "Registered as %s\n",
video_device_node_name(&dev->vdev)); video_device_node_name(&dev->tx_vdev));
dev_notice(dev->dev, "SDR API is still slightly experimental and functionality changes may follow\n"); dev_notice(dev->dev, "SDR API is still slightly experimental and functionality changes may follow\n");
return 0; return 0;
err_video_unregister_device_rx:
err_free_controls: video_unregister_device(&dev->rx_vdev);
v4l2_ctrl_handler_free(&dev->hdl); err_v4l2_device_unregister:
err_unregister_v4l2_dev:
v4l2_device_unregister(&dev->v4l2_dev); v4l2_device_unregister(&dev->v4l2_dev);
err_free_mem: err_v4l2_ctrl_handler_free_tx:
v4l2_ctrl_handler_free(&dev->tx_ctrl_handler);
err_v4l2_ctrl_handler_free_rx:
v4l2_ctrl_handler_free(&dev->rx_ctrl_handler);
err_kfree:
kfree(dev); kfree(dev);
err:
dev_dbg(dev->dev, "failed=%d\n", ret);
return ret; return ret;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7