Commit 8cfd36a0 authored by Benjamin Beichler's avatar Benjamin Beichler Committed by Johannes Berg

mac80211_hwsim: fix use-after-free bug in hwsim_exit_net

When destroying a net namespace, all hwsim interfaces, which are not
created in default namespace are deleted. But the async deletion of the
interfaces could last longer than the actual destruction of the
namespace, which results to an use after free bug. Therefore use
synchronous deletion in this case.

Fixes: 100cb9ff ("mac80211_hwsim: Allow managing radios from non-initial namespaces")
Reported-by: syzbot+70ce058e01259de7bb1d@syzkaller.appspotmail.com
Signed-off-by: default avatarBenjamin Beichler <benjamin.beichler@uni-rostock.de>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 796e1112
...@@ -3528,8 +3528,12 @@ static void __net_exit hwsim_exit_net(struct net *net) ...@@ -3528,8 +3528,12 @@ static void __net_exit hwsim_exit_net(struct net *net)
list_del(&data->list); list_del(&data->list);
rhashtable_remove_fast(&hwsim_radios_rht, &data->rht, rhashtable_remove_fast(&hwsim_radios_rht, &data->rht,
hwsim_rht_params); hwsim_rht_params);
INIT_WORK(&data->destroy_work, destroy_radio); hwsim_radios_generation++;
queue_work(hwsim_wq, &data->destroy_work); spin_unlock_bh(&hwsim_radio_lock);
mac80211_hwsim_del_radio(data,
wiphy_name(data->hw->wiphy),
NULL);
spin_lock_bh(&hwsim_radio_lock);
} }
spin_unlock_bh(&hwsim_radio_lock); spin_unlock_bh(&hwsim_radio_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment