Commit 8d026465 authored by Daniel Wagner's avatar Daniel Wagner Committed by Greg Kroah-Hartman

ti-st: Fix complete_all() wrong usage

complete_all() should only be called once, doing it twice is a clear bug.

8565adbc ("drivers/misc/ti-st: fix read fw version cmd") added the
additional complete_all() call. Since we call complete_all() when
leaving the function we can drop the complete_all() call inside
true branch of the if statement.
Signed-off-by: default avatarDaniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Pavan Savoy <pavan_savoy@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 66b58edf
...@@ -78,7 +78,6 @@ static void validate_firmware_response(struct kim_data_s *kim_gdata) ...@@ -78,7 +78,6 @@ static void validate_firmware_response(struct kim_data_s *kim_gdata)
memcpy(kim_gdata->resp_buffer, memcpy(kim_gdata->resp_buffer,
kim_gdata->rx_skb->data, kim_gdata->rx_skb->data,
kim_gdata->rx_skb->len); kim_gdata->rx_skb->len);
complete_all(&kim_gdata->kim_rcvd);
kim_gdata->rx_state = ST_W4_PACKET_TYPE; kim_gdata->rx_state = ST_W4_PACKET_TYPE;
kim_gdata->rx_skb = NULL; kim_gdata->rx_skb = NULL;
kim_gdata->rx_count = 0; kim_gdata->rx_count = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment