cpufreq: intel_pstate: Calculate guaranteed performance for HWP

When HWP is active, turbo activation ratio is not used to calculate max
non turbo ratio. But on these systems the max non turbo ratio is decided
by config TDP settings.

This change removes usage of MSR_TURBO_ACTIVATION_RATIO for HWP systems,
instead directly use TDP ratios, when more than one TDPs are available.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

drivers/cpufreq/intel_pstate.c

@@ -1454,48 +1454,71 @@ static int core_get_max_pstate_physical(void)
 	return (value >> 8) & 0xFF;
 }
 
-static int core_get_max_pstate(void)
+static int core_get_tdp_ratio(u64 plat_info)
 {
-	u64 tar;
-	u64 plat_info;
-	int max_pstate;
-	int err;
-
-	rdmsrl(MSR_PLATFORM_INFO, plat_info);
-	max_pstate = (plat_info >> 8) & 0xFF;
-
-	err = rdmsrl_safe(MSR_TURBO_ACTIVATION_RATIO, &tar);
-	if (!err) {
-		/* Do some sanity checking for safety */
+	/* Check how many TDP levels present */
 	if (plat_info & 0x600000000) {
 		u64 tdp_ctrl;
 		u64 tdp_ratio;
 		int tdp_msr;
+		int err;
 
+		/* Get the TDP level (0, 1, 2) to get ratios */
 		err = rdmsrl_safe(MSR_CONFIG_TDP_CONTROL, &tdp_ctrl);
 		if (err)
-				goto skip_tar;
+			return err;
 
-			tdp_msr = MSR_CONFIG_TDP_NOMINAL + (tdp_ctrl & 0x3);
+		/* TDP MSR are continuous starting at 0x648 */
+		tdp_msr = MSR_CONFIG_TDP_NOMINAL + (tdp_ctrl & 0x03);
 		err = rdmsrl_safe(tdp_msr, &tdp_ratio);
 		if (err)
-				goto skip_tar;
+			return err;
 
 		/* For level 1 and 2, bits[23:16] contain the ratio */
-			if (tdp_ctrl)
+		if (tdp_ctrl & 0x03)
 			tdp_ratio >>= 16;
 
 		tdp_ratio &= 0xff; /* ratios are only 8 bits long */
-			if (tdp_ratio - 1 == tar) {
-				max_pstate = tar;
-				pr_debug("max_pstate=TAC %x\n", max_pstate);
-			} else {
-				goto skip_tar;
+		pr_debug("tdp_ratio %x\n", (int)tdp_ratio);
+
+		return (int)tdp_ratio;
+	}
+
+	return -ENXIO;
+}
+
+static int core_get_max_pstate(void)
+{
+	u64 tar;
+	u64 plat_info;
+	int max_pstate;
+	int tdp_ratio;
+	int err;
+
+	rdmsrl(MSR_PLATFORM_INFO, plat_info);
+	max_pstate = (plat_info >> 8) & 0xFF;
+
+	tdp_ratio = core_get_tdp_ratio(plat_info);
+	if (tdp_ratio <= 0)
+		return max_pstate;
+
+	if (hwp_active) {
+		/* Turbo activation ratio is not used on HWP platforms */
+		return tdp_ratio;
 	}
+
+	err = rdmsrl_safe(MSR_TURBO_ACTIVATION_RATIO, &tar);
+	if (!err) {
+		int tar_levels;
+
+		/* Do some sanity checking for safety */
+		tar_levels = tar & 0xff;
+		if (tdp_ratio - 1 == tar_levels) {
+			max_pstate = tar_levels;
+			pr_debug("max_pstate=TAC %x\n", max_pstate);
 		}
 	}
 
-skip_tar:
 	return max_pstate;
 }