Commit 919b4765 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jiri Slaby

scsi: zfcp: spin_lock_irqsave() is not nestable

commit e7cb08e8 upstream.

We accidentally overwrite the original saved value of "flags" so that we
can't re-enable IRQs at the end of the function.  Presumably this
function is mostly called with IRQs disabled or it would be obvious in
testing.

Fixes: aceeffbb ("zfcp: trace full payload of all SAN records (req,resp,iels)")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSteffen Maier <maier@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent 6f5790ba
...@@ -384,7 +384,7 @@ void zfcp_dbf_san(char *tag, struct zfcp_dbf *dbf, ...@@ -384,7 +384,7 @@ void zfcp_dbf_san(char *tag, struct zfcp_dbf *dbf,
/* if (len > rec_len): /* if (len > rec_len):
* dump data up to cap_len ignoring small duplicate in rec->payload * dump data up to cap_len ignoring small duplicate in rec->payload
*/ */
spin_lock_irqsave(&dbf->pay_lock, flags); spin_lock(&dbf->pay_lock);
memset(payload, 0, sizeof(*payload)); memset(payload, 0, sizeof(*payload));
memcpy(payload->area, paytag, ZFCP_DBF_TAG_LEN); memcpy(payload->area, paytag, ZFCP_DBF_TAG_LEN);
payload->fsf_req_id = req_id; payload->fsf_req_id = req_id;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment